From: Christian Marangi <ansuelsmth@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH net-next] net: dsa: qca8k: convert to regmap read/write API
Date: Fri, 19 Aug 2022 13:43:57 +0200 [thread overview]
Message-ID: <62ff7b28.170a0220.91820.52c8@mx.google.com> (raw)
In-Reply-To: <20220818165119.c5cgk5og7jhmzpo6@skbuf>
On Thu, Aug 18, 2022 at 07:51:19PM +0300, Vladimir Oltean wrote:
> On Sat, Aug 06, 2022 at 09:22:53PM +0200, Christian Marangi wrote:
> > Convert qca8k to regmap read/write bulk API. The mgmt eth can write up
> > to 16 bytes of data at times. Currently we use a custom function to do
> > it but regmap now supports declaration of read/write bulk even without a
> > bus.
> >
> > Drop the custom function and rework the regmap function to this new
> > implementation.
> >
> > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> > ---
>
> Nothing in this change jumps out as wrong to me, but maybe you should
> copy Mark Brown too when you submit it proper, as the first user of the
> bulk regmap read/write over Ethernet, IIUC.
Should I send a v2 without RFC and CC Mark or CC directly here in the
RFC? This is ready so v2 won't have changes.
--
Ansuel
next prev parent reply other threads:[~2022-08-19 11:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-06 19:22 [RFC PATCH net-next] net: dsa: qca8k: convert to regmap read/write API Christian Marangi
2022-08-18 16:51 ` Vladimir Oltean
2022-08-19 11:43 ` Christian Marangi [this message]
2022-08-25 23:53 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62ff7b28.170a0220.91820.52c8@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).