From: Jan Beulich <jbeulich@suse.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: james@dingwall.me.uk, xen-devel@lists.xenproject.org,
Juergen Gross <jgross@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH] x86/xen: Return from panic notifier
Date: Wed, 2 Oct 2019 16:59:16 +0200 [thread overview]
Message-ID: <63155d02-1082-3f26-6c2f-76aa3b753302@suse.com> (raw)
In-Reply-To: <9d6b6b00-a3b1-95b4-7633-597c0094ab90@oracle.com>
On 02.10.2019 16:14, Boris Ostrovsky wrote:
> On 10/2/19 9:42 AM, Jan Beulich wrote:
>>
>> I can only guess that the thinking probably was that e.g. external
>> dumping (by the tool stack) would be more reliable (including but
>> not limited to this meaning less change of state from when the
>> original crash reason was detected) than having the domain dump
>> itself.
>
>
> We could register an external dumper (controlled by a boot option
> perhaps, off by default) that will call directly into hypervisor with
> SHUTDOWN_crash. That will guarantee that we will complete the notifier
> chain without relying on priorities. (Of course this still won't address
> a possible new feature in panic() that might be called post-dumping)
>
> If you think it's worth doing this can be easily added.
Well, I think this is the better option than potentially
pingponging between the two extremes, because one wants it the
way it currently is and another wants it the way this patch
changes things to.
Jan
prev parent reply other threads:[~2019-10-02 14:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 15:16 [PATCH] x86/xen: Return from panic notifier Boris Ostrovsky
2019-10-02 4:36 ` Jürgen Groß
2019-10-02 7:40 ` [Xen-devel] " Jan Beulich
2019-10-02 13:24 ` Boris Ostrovsky
2019-10-02 13:42 ` Jan Beulich
2019-10-02 14:14 ` Boris Ostrovsky
2019-10-02 14:59 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63155d02-1082-3f26-6c2f-76aa3b753302@suse.com \
--to=jbeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=james@dingwall.me.uk \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).