From: Jarkko Sakkinen <jarkko@kernel.org>
To: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>,
Elvira Khabirova <e.khabirova@omp.ru>,
keyrings@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
davem@davemloft.net, herbert@gondor.apana.org.au,
dhowells@redhat.com, vt@altlinux.org
Subject: Re: [PATCH] pkcs7: support EC-RDSA/streebog in SignerInfo
Date: Wed, 22 Sep 2021 00:07:25 +0300 [thread overview]
Message-ID: <6318b58cf9ede0ffcda396cd14572d0143f6a04e.camel@kernel.org> (raw)
In-Reply-To: <59bf7fdf-b06e-1533-865a-06c612f4a19c@linux.alibaba.com>
On Sat, 2021-09-18 at 10:39 +0800, Tianjia Zhang wrote:
> ping.
>
> On 5/11/21 10:47 PM, Elvira Khabirova wrote:
> > Allow using EC-RDSA/streebog in pkcs7 certificates in a similar way
> > to how it's done in the x509 parser.
> >
> > This is needed e.g. for loading kernel modules signed with EC-RDSA.
> >
> > Signed-off-by: Elvira Khabirova <e.khabirova@omp.ru>
> > ---
> > crypto/asymmetric_keys/pkcs7_parser.c | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/crypto/asymmetric_keys/pkcs7_parser.c b/crypto/asymmetric_keys/pkcs7_parser.c
> > index 967329e0a07b..39c260a04167 100644
> > --- a/crypto/asymmetric_keys/pkcs7_parser.c
> > +++ b/crypto/asymmetric_keys/pkcs7_parser.c
> > @@ -248,6 +248,12 @@ int pkcs7_sig_note_digest_algo(void *context, size_t hdrlen,
> > case OID_sha224:
> > ctx->sinfo->sig->hash_algo = "sha224";
> > break;
> > + case OID_gost2012Digest256:
> > + ctx->sinfo->sig->hash_algo = "streebog256";
> > + break;
> > + case OID_gost2012Digest512:
> > + ctx->sinfo->sig->hash_algo = "streebog512";
> > + break;
> > default:
> > printk("Unsupported digest algo: %u\n", ctx->last_oid);
> > return -ENOPKG;
> > @@ -269,6 +275,11 @@ int pkcs7_sig_note_pkey_algo(void *context, size_t hdrlen,
> > ctx->sinfo->sig->pkey_algo = "rsa";
> > ctx->sinfo->sig->encoding = "pkcs1";
> > break;
> > + case OID_gost2012PKey256:
> > + case OID_gost2012PKey512:
> > + ctx->sinfo->sig->pkey_algo = "ecrdsa";
> > + ctx->sinfo->sig->encoding = "raw";
> > + break;
> > default:
> > printk("Unsupported pkey algo: %u\n", ctx->last_oid);
> > return -ENOPKG;
> >
Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
/Jarkko
prev parent reply other threads:[~2021-09-21 21:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 14:47 [PATCH] pkcs7: support EC-RDSA/streebog in SignerInfo Elvira Khabirova
2021-05-12 14:23 ` Vitaly Chikunov
2021-07-03 2:07 ` Tianjia Zhang
2021-09-18 2:39 ` Tianjia Zhang
2021-09-21 21:07 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6318b58cf9ede0ffcda396cd14572d0143f6a04e.camel@kernel.org \
--to=jarkko@kernel.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=e.khabirova@omp.ru \
--cc=herbert@gondor.apana.org.au \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tianjia.zhang@linux.alibaba.com \
--cc=vt@altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).