linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Zyngier <marc.zyngier@arm.com>
To: Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>,
	Bjorn Helgaas <helgaas@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"Janusz.Dziedzic@tieto.com" <Janusz.Dziedzic@tieto.com>,
	"rmanohar@qti.qualcomm.com" <rmanohar@qti.qualcomm.com>,
	Kalle Valo <kvalo@codeaurora.org>,
	"ath9k-devel@qca.qualcomm.com" <ath9k-devel@qca.qualcomm.com>
Subject: Re: ATH9 driver issues on ARM64
Date: Fri, 9 Dec 2016 11:24:00 +0000	[thread overview]
Message-ID: <634133ba-f77e-bc80-751d-b77a7816dec4@arm.com> (raw)
In-Reply-To: <8520D5D51A55D047800579B094147198263A7F11@XAP-PVEXMBX02.xlnx.xilinx.com>

On 09/12/16 11:04, Bharat Kumar Gogada wrote:
>> On 09/12/16 02:07, Bharat Kumar Gogada wrote:
>>>> On 08/12/16 18:33, Bharat Kumar Gogada wrote:
>>>>>> On 08/12/16 15:29, Bharat Kumar Gogada wrote:
>>>>>>> 218:         61          0          0          0     GICv2  81 Level     mmc0
>>>>>>> 219:          0          0          0          0     GICv2 187 Level     arm-smmu global
>> fault
>>>>>>> 220:        471          0          0          0     GICv2  53 Level     xuartps
>>>>>>> 223:          0          0          0          0     GICv2 154 Level     fd4c0000.dma
>>>>>>> 224:          3          0          0          0     dummy   1 Edge      ath9k
>>>>>>
>>>>>> What is this "dummy" controller? And if that's supposed to be a
>>>>>> legacy interrupt from the PCI device, it has the wrong trigger.
>>>>>
>>>>> Yes it is for legacy interrupt, wrong trigger means ?
>>>>
>>>> Aren't legacy interrupts supposed to be *level* triggered, and not edge?
>>>>
>>> Yes agreed.
>>> For legacy interrupts im using irq_set_chained_handler_and_data so the
>>> irq line between bridge and GIC Will not be shown here. The above how
>>> is virq for legacy, which is given by kernel, not sure why its state is set to edge.
>>
>> Well, you should try and find out. Edge triggering for legacy interrupts is a real
>> bug, and I don't think it has anything to do with arm64 (despite what the subject
>> says).
>>
> Thanks Marc. Here is the ARM32 bit log for cat /proc/interrupts, 
> Here also it shows edge but still scan works successfully.

Because it works doesn't mean it is right.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

      reply	other threads:[~2016-12-09 11:24 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-08 13:49 ATH9 driver issues on ARM64 Bharat Kumar Gogada
2016-12-08 14:56 ` Bjorn Helgaas
2016-12-08 15:29   ` Bharat Kumar Gogada
2016-12-08 17:36     ` Kalle Valo
2016-12-09  5:00       ` Bharat Kumar Gogada
2016-12-09  6:55         ` Bharat Kumar Gogada
2016-12-09 14:22       ` Tobias Klausmann
2016-12-09 14:35         ` Bharat Kumar Gogada
2016-12-10 14:40         ` Bharat Kumar Gogada
2016-12-12 16:31           ` Bjorn Helgaas
2016-12-14  5:09             ` Bharat Kumar Gogada
2016-12-22  7:19               ` Bharat Kumar Gogada
2016-12-08 18:07     ` Marc Zyngier
2016-12-08 18:33       ` Bharat Kumar Gogada
2016-12-08 19:09         ` Marc Zyngier
2016-12-09  2:07           ` Bharat Kumar Gogada
2016-12-09  2:39             ` Bharat Kumar Gogada
2016-12-09 10:50             ` Marc Zyngier
2016-12-09 11:04               ` Bharat Kumar Gogada
2016-12-09 11:24                 ` Marc Zyngier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=634133ba-f77e-bc80-751d-b77a7816dec4@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=Janusz.Dziedzic@tieto.com \
    --cc=ath9k-devel@qca.qualcomm.com \
    --cc=bharat.kumar.gogada@xilinx.com \
    --cc=helgaas@kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=rmanohar@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).