From: Sibi Sankar <sibis@codeaurora.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: viresh.kumar@linaro.org, sboyd@kernel.org,
georgi.djakov@linaro.org, saravanak@google.com, nm@ti.com,
bjorn.andersson@linaro.org, agross@kernel.org,
david.brown@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com,
rjw@rjwysocki.net, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, dianders@chromium.org,
vincent.guittot@linaro.org, amit.kucheria@linaro.org,
ulf.hansson@linaro.org
Subject: Re: [RFC v3 04/10] OPP: Add and export helper to update voltage
Date: Wed, 29 Jan 2020 19:19:47 +0530 [thread overview]
Message-ID: <634183c54f18b4500da6aa16e9cf4185@codeaurora.org> (raw)
In-Reply-To: <20200128213336.GH46072@google.com>
On 2020-01-29 03:03, Matthias Kaehlcke wrote:
> Hi Sibi,
>
> On Tue, Jan 28, 2020 at 01:33:44AM +0530, Sibi Sankar wrote:
>> Add and export 'dev_pm_opp_update_voltage' to find and update voltage
>> of an opp for a given frequency. This will be useful to update the
>> opps
>> with voltages read back from firmware.
>>
>> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
>> ---
>> drivers/opp/core.c | 55
>> ++++++++++++++++++++++++++++++++++++++++++
>> include/linux/pm_opp.h | 10 ++++++++
>> 2 files changed, 65 insertions(+)
>>
>> diff --git a/drivers/opp/core.c b/drivers/opp/core.c
>> index 9aa2a44a5d638..f241e83ec926a 100644
>> --- a/drivers/opp/core.c
>> +++ b/drivers/opp/core.c
>> @@ -2503,6 +2503,61 @@ int dev_pm_opp_disable(struct device *dev,
>> unsigned long freq)
>> }
>> EXPORT_SYMBOL_GPL(dev_pm_opp_disable);
>>
>> +/**
>> + * dev_pm_opp_update_voltage() - Find and update voltage
>
> The comment should mention that this is done for an OPP.
>
> Maybe omit the 'find' part here and just say 'Update the voltage of
> an OPP'?
sure makes sense
>
>> + * @dev: device for which we do this operation
>> + * @freq: OPP frequency to update voltage
>> + * @u_volt: voltage requested for this opp
>> + *
>> + * Find and update voltage of a disabled opp corresponding to the
>> given
>> + * frequency. This is useful only for devices with single power
>> supply.
>> + *
>> + * Return: 0 if modification was successful or a negative error
>> value.
>> + */
>> +int dev_pm_opp_update_voltage(struct device *dev, unsigned long freq,
>> + unsigned long u_volt)
>> +{
>> + struct dev_pm_opp *opp = ERR_PTR(-ENODEV);
>
> initialization is not needed
>
>> + struct opp_table *opp_table;
>> + unsigned long tol;
>> + int ret = 0;
>> +
>> + /* Find the opp_table */
>
> Drop the comment, it's obvious from the code.
>
>> + opp_table = _find_opp_table(dev);
>> + if (IS_ERR(opp_table)) {
>> + ret = PTR_ERR(opp_table);
>> + dev_err(dev, "%s: OPP table not found (%d)\n", __func__, ret);
>> + return PTR_ERR(opp_table);
>
> return ret;
missed that :(
>
>> + }
>> +
>> + opp = dev_pm_opp_find_freq_exact(dev, freq, false);
>> + if (IS_ERR(opp)) {
>> + ret = PTR_ERR(opp);
>> + goto put_table;
>> + }
>> +
>> + mutex_lock(&opp_table->lock);
>> +
>> + /* update only if the opp is disabled */
>> + if (opp->available) {
>> + ret = -EBUSY;
>> + goto unlock;
>> + }
>> +
>> + tol = u_volt * opp_table->voltage_tolerance_v1 / 100;
>> + opp->supplies[0].u_volt_min = u_volt - tol;
>> + opp->supplies[0].u_volt = u_volt;
>> + opp->supplies[0].u_volt_min = u_volt + tol;
>
> .u_volt_max =
>
> I suppose the assignments need to be done for all possible supplies,
> i.e. 0 to (opp_table->regulator_count - 1).
a single value for all possible
supplies seems wrong. Anyway
will wait to see what Viresh
thinks about it.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2020-01-29 13:49 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 20:03 [RFC v3 00/10] DDR/L3 Scaling support on SDM845 and SC7180 SoCs Sibi Sankar
2020-01-27 20:03 ` [RFC v3 01/10] arm64: dts: qcom: sdm845: Add SoC compatible to MTP Sibi Sankar
2020-01-28 20:40 ` Matthias Kaehlcke
2020-01-29 13:45 ` Sibi Sankar
2020-01-27 20:03 ` [RFC v3 02/10] cpufreq: blacklist SDM845 in cpufreq-dt-platdev Sibi Sankar
2020-01-28 20:44 ` Matthias Kaehlcke
2020-01-29 13:46 ` Sibi Sankar
2020-01-30 11:40 ` Sudeep Holla
2020-02-01 12:21 ` Sibi Sankar
2020-01-27 20:03 ` [RFC v3 03/10] cpufreq: blacklist SC7180 " Sibi Sankar
2020-01-28 20:45 ` Matthias Kaehlcke
2020-01-27 20:03 ` [RFC v3 04/10] OPP: Add and export helper to update voltage Sibi Sankar
2020-01-28 21:33 ` Matthias Kaehlcke
2020-01-29 13:49 ` Sibi Sankar [this message]
2020-01-27 20:03 ` [RFC v3 05/10] opp: of: export _opp_of_get_opp_desc_node Sibi Sankar
2020-01-27 20:03 ` [RFC v3 06/10] opp: Allow multiple opp_tables to be mapped to a single device Sibi Sankar
2020-01-27 20:03 ` [RFC v3 07/10] opp: Remove multiple attached opp tables from a device Sibi Sankar
2020-01-27 20:03 ` [RFC v3 08/10] cpufreq: qcom: Update the bandwidth levels on frequency change Sibi Sankar
2020-01-29 9:35 ` Lukasz Luba
2020-01-29 14:27 ` Sibi Sankar
2020-01-27 20:03 ` [RFC v3 09/10] arm64: dts: qcom: sdm845: Add cpu OPP tables Sibi Sankar
2020-01-29 1:24 ` Matthias Kaehlcke
2020-01-29 14:05 ` Sibi Sankar
2020-01-29 18:18 ` Matthias Kaehlcke
2020-01-27 20:03 ` [RFC v3 10/10] arm64: dts: qcom: sc7180: " Sibi Sankar
2020-01-29 2:54 ` [RFC v3 00/10] DDR/L3 Scaling support on SDM845 and SC7180 SoCs Rob Clark
2020-01-29 14:21 ` Sibi Sankar
2020-01-29 9:46 ` Lukasz Luba
2020-01-29 14:37 ` Sibi Sankar
2020-01-29 15:47 ` Lukasz Luba
2020-03-17 20:43 ` Sibi Sankar
2020-03-18 3:42 ` Viresh Kumar
2020-03-19 9:42 ` Rajendra Nayak
2020-03-19 10:11 ` Sibi Sankar
2020-03-19 10:24 ` Viresh Kumar
2020-03-19 10:53 ` Rajendra Nayak
2020-03-19 11:08 ` Viresh Kumar
2020-03-19 11:33 ` Rajendra Nayak
2020-03-20 8:01 ` Viresh Kumar
2020-03-19 10:57 ` Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=634183c54f18b4500da6aa16e9cf4185@codeaurora.org \
--to=sibis@codeaurora.org \
--cc=agross@kernel.org \
--cc=amit.kucheria@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).