From: Logan Gunthorpe <logang@deltatee.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
Wesley Sheng <wesley.sheng@microchip.com>
Cc: kurt.schwemmer@microsemi.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, wesleyshenggit@sina.com,
kelvin.cao@microchip.com
Subject: Re: [PATCH 1/2] switchtec: Fix false maximum supported PCIe function number issue
Date: Tue, 9 Apr 2019 17:32:13 -0600 [thread overview]
Message-ID: <634db3fa-286d-1136-b2af-1bf45501275f@deltatee.com> (raw)
In-Reply-To: <20190409223642.GD256045@google.com>
On 2019-04-09 4:36 p.m., Bjorn Helgaas wrote:
> Hi Wesley,
>
> On Mon, Apr 08, 2019 at 10:34:47PM +0800, Wesley Sheng wrote:
>> The hardware supports up to 255 PFFs and the driver only supports 48, so
>> this patch updates the driver to support them all.
>> To be backward compatible, a new ioctl and corresponding data
>> structure are created, while keep the deprecated one.
>
> The above is either one paragraph that needs to be rewrapped, or two
> paragraphs that need a blank line between.
Wesley can address this.
> What's a PFF?
PFF is really a concept internal to the Switchtec device. It stands for
PCIe Function Framework. Essentially, there is a bank of registers for
every PCIe Function (aka endpoint) in the switch. When I originally
wrote the driver, I assumed incorrectly there would only ever be one PFF
per port and the maximum number of ports for Switchtec parts is 48. In
fact, the hardware supports up to 255 and there are typically two PFFs
per upstream port (one for the port itself and one for the management
endpoint).
Logan
next prev parent reply other threads:[~2019-04-09 23:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 14:34 [PATCH 0/2] Fix two bugs of switchtec module Wesley Sheng
2019-04-08 14:34 ` [PATCH 1/2] switchtec: Fix false maximum supported PCIe function number issue Wesley Sheng
2019-04-09 22:36 ` Bjorn Helgaas
2019-04-09 23:32 ` Logan Gunthorpe [this message]
2019-04-08 14:34 ` [PATCH 2/2] switchtec: Fix unintended mask of MRPC event Wesley Sheng
2019-04-08 16:00 ` [PATCH 0/2] Fix two bugs of switchtec module Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=634db3fa-286d-1136-b2af-1bf45501275f@deltatee.com \
--to=logang@deltatee.com \
--cc=helgaas@kernel.org \
--cc=kelvin.cao@microchip.com \
--cc=kurt.schwemmer@microsemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=wesley.sheng@microchip.com \
--cc=wesleyshenggit@sina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).