From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Yangtao Li <tiny.windzz@gmail.com>
Cc: daniel.lezcano@linaro.org, shc_work@mail.ru,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] cpuidle: kirkwood: convert to devm_platform_ioremap_resource
Date: Mon, 16 Dec 2019 12:21:07 +0100 [thread overview]
Message-ID: <6350875.0eM1BVzdex@kreacher> (raw)
In-Reply-To: <20191215130206.30265-2-tiny.windzz@gmail.com>
On Sunday, December 15, 2019 2:02:06 PM CET Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/cpuidle/cpuidle-kirkwood.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/cpuidle/cpuidle-kirkwood.c b/drivers/cpuidle/cpuidle-kirkwood.c
> index d23d8f468c12..511c4f46027a 100644
> --- a/drivers/cpuidle/cpuidle-kirkwood.c
> +++ b/drivers/cpuidle/cpuidle-kirkwood.c
> @@ -55,10 +55,7 @@ static struct cpuidle_driver kirkwood_idle_driver = {
> /* Initialize CPU idle by registering the idle states */
> static int kirkwood_cpuidle_probe(struct platform_device *pdev)
> {
> - struct resource *res;
> -
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - ddr_operation_base = devm_ioremap_resource(&pdev->dev, res);
> + ddr_operation_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(ddr_operation_base))
> return PTR_ERR(ddr_operation_base);
>
>
Daniel, any concerns here?
next prev parent reply other threads:[~2019-12-16 11:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-15 13:02 [PATCH] cpuidle: clps711x: convert to devm_platform_ioremap_resource Yangtao Li
2019-12-15 13:02 ` [PATCH 1/2] cpuidle: kirkwood: " Yangtao Li
2019-12-15 15:01 ` Andrew Lunn
2019-12-16 11:21 ` Rafael J. Wysocki [this message]
2019-12-16 15:45 ` Daniel Lezcano
2019-12-20 9:16 ` Rafael J. Wysocki
2019-12-16 11:20 ` [PATCH] cpuidle: clps711x: " Rafael J. Wysocki
2019-12-16 15:44 ` Daniel Lezcano
2019-12-20 9:17 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6350875.0eM1BVzdex@kreacher \
--to=rjw@rjwysocki.net \
--cc=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=shc_work@mail.ru \
--cc=tiny.windzz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).