From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751944AbdGAQEs (ORCPT ); Sat, 1 Jul 2017 12:04:48 -0400 Received: from gloria.sntech.de ([95.129.55.99]:38466 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751822AbdGAQEr (ORCPT ); Sat, 1 Jul 2017 12:04:47 -0400 From: Heiko Stuebner To: Jacob Chen Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, kever.yang@rock-chips.com Subject: Re: [PATCH 1/3] arm64: dts: rockchip: add ARM Mali GPU node for rk3399 Date: Sat, 01 Jul 2017 18:04:26 +0200 Message-ID: <6356522.W9n5LLYRuo@phil> User-Agent: KMail/5.2.3 (Linux/4.9.0-2-amd64; KDE/5.28.0; x86_64; ; ) In-Reply-To: <1498913770-16519-1-git-send-email-jacob-chen@iotwrt.com> References: <1498913770-16519-1-git-send-email-jacob-chen@iotwrt.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jacob, Am Samstag, 1. Juli 2017, 20:56:08 CEST schrieb Jacob Chen: > Add Mali GPU device tree node for the rk3399 SoC. > Tested with rockchip-forwardports repo. > > Signed-off-by: Jacob Chen > --- > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index 1cbd7a2..e795135 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -1443,6 +1443,18 @@ > status = "disabled"; > }; > > + gpu: mali@ff9a0000 { > + compatible = "rockchip,rk3399-mali", "arm,mali-t860", "arm,mali-midgard"; this is missing a separate patch adding rockchip,rk3399-mali to Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt Also arm,mali-midgard is not part of the binding. I just saw that it slipped into the example in the binding file and also the rk3288.dtsi - which should be fixed. But the driver should bind against the arm,mali-t860 alone, not the mali-midgard. Heiko