From: <Ludovic.Desroches@microchip.com>
To: <mirq-linux@rere.qmqm.pl>, <ulf.hansson@linaro.org>,
<adrian.hunter@intel.com>, <Nicolas.Ferre@microchip.com>,
<alexandre.belloni@bootlin.com>
Cc: <linux-mmc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: sdhci-of-at91: fix cd-gpios for SAMA5D2
Date: Mon, 23 Mar 2020 20:23:51 +0000 [thread overview]
Message-ID: <635a5f5f-fb52-d9ef-a905-3e09ee1f4f18@microchip.com> (raw)
In-Reply-To: <8d10950d9940468577daef4772b82a071b204716.1584290561.git.mirq-linux@rere.qmqm.pl>
Hi,
On 3/15/2020 5:44 PM, Michał Mirosław wrote
> SAMA5D2x doesn't drive CMD line if GPIO is used as CD line (at least
> SAMA5D27 doesn't). Fix this by forcing card-detect in the module
> if module-controlled CD is not used.
>
> Fixed commit addresses the problem only for non-removable cards. This
> amends it to also cover gpio-cd case.
>
> Cc: stable@vger.kernel.org
> Fixes: 7a1e3f143176 ("mmc: sdhci-of-at91: force card detect value for non removable devices")
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Even if it's too late, I agree with this patch. Thanks, I didn't expect
someone will use a GPIO CD instead of the
one of the controller so this case was missing.
In fact, the whole SAMA5D2 family is concerned depending on the revision
of the SoC. From the top of my head,
for rev A, if the pin is muxed to another function than the SDMMC
controller, the default value is card present.
For rev B and later, the default value is no card present, that's why
the CMD line is not driven.
Regards
Ludovic
> ---
> drivers/mmc/host/sdhci-of-at91.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c
> index d90f4ed18283..8f8da2fe48a9 100644
> --- a/drivers/mmc/host/sdhci-of-at91.c
> +++ b/drivers/mmc/host/sdhci-of-at91.c
> @@ -185,7 +185,8 @@ static void sdhci_at91_reset(struct sdhci_host *host, u8 mask)
>
> sdhci_reset(host, mask);
>
> - if (host->mmc->caps & MMC_CAP_NONREMOVABLE)
> + if ((host->mmc->caps & MMC_CAP_NONREMOVABLE)
> + || mmc_gpio_get_cd(host->mmc) >= 0)
> sdhci_at91_set_force_card_detect(host);
>
> if (priv->cal_always_on && (mask & SDHCI_RESET_ALL))
> @@ -487,8 +488,11 @@ static int sdhci_at91_probe(struct platform_device *pdev)
> * detection procedure using the SDMCC_CD signal is bypassed.
> * This bit is reset when a software reset for all command is performed
> * so we need to implement our own reset function to set back this bit.
> + *
> + * WA: SAMA5D2 doesn't drive CMD if using CD GPIO line.
> */
> - if (host->mmc->caps & MMC_CAP_NONREMOVABLE)
> + if ((host->mmc->caps & MMC_CAP_NONREMOVABLE)
> + || mmc_gpio_get_cd(host->mmc) >= 0)
> sdhci_at91_set_force_card_detect(host);
>
> pm_runtime_put_autosuspend(&pdev->dev);
> --
> 2.20.1
>
prev parent reply other threads:[~2020-03-23 20:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-15 16:44 [PATCH] mmc: sdhci-of-at91: fix cd-gpios for SAMA5D2 Michał Mirosław
2020-03-17 9:57 ` Adrian Hunter
2020-03-17 11:58 ` Ulf Hansson
2020-03-23 20:23 ` Ludovic.Desroches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=635a5f5f-fb52-d9ef-a905-3e09ee1f4f18@microchip.com \
--to=ludovic.desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=adrian.hunter@intel.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).