From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A15DCC433E3 for ; Mon, 20 Jul 2020 09:38:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B5A0208E4 for ; Mon, 20 Jul 2020 09:38:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728234AbgGTJiA convert rfc822-to-8bit (ORCPT ); Mon, 20 Jul 2020 05:38:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727901AbgGTJh7 (ORCPT ); Mon, 20 Jul 2020 05:37:59 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9ED11C061794 for ; Mon, 20 Jul 2020 02:37:59 -0700 (PDT) Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jxSF6-0005P5-Ui; Mon, 20 Jul 2020 11:37:52 +0200 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1jxSF5-0005vr-7y; Mon, 20 Jul 2020 11:37:51 +0200 Message-ID: <636380f452ff696ab4505ad09dcea951283be06b.camel@pengutronix.de> Subject: Re: [Patch v1 2/4] dma: tegra: Adding Tegra GPC DMA controller driver From: Philipp Zabel To: Rajesh Gumasta , ldewangan@nvidia.com, jonathanh@nvidia.com, vkoul@kernel.org, dan.j.williams@intel.com, thierry.reding@gmail.com, dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kyarlagadda@nvidia.com, Pavan Kunapuli Date: Mon, 20 Jul 2020 11:37:51 +0200 In-Reply-To: <1595226856-19241-3-git-send-email-rgumasta@nvidia.com> References: <1595226856-19241-1-git-send-email-rgumasta@nvidia.com> <1595226856-19241-3-git-send-email-rgumasta@nvidia.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rajesh, On Mon, 2020-07-20 at 12:04 +0530, Rajesh Gumasta wrote: > + > + tdma->rst = devm_reset_control_get(&pdev->dev, "gpcdma"); Please use devm_reset_control_get_exclusive() directly. > + if (IS_ERR(tdma->rst)) { > + dev_err(&pdev->dev, "Missing controller reset\n"); You might want to suppress this message if the error is EPROBE_DEFER. > + return PTR_ERR(tdma->rst); > + } > + reset_control_reset(tdma->rst); regards Philipp