From: Christian Eggers <ceggers@arri.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Mark Brown <broonie@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>, <linux-spi@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] spi: imx: Revert "spi: imx: enable runtime pm support"
Date: Fri, 9 Oct 2020 09:48:29 +0200 [thread overview]
Message-ID: <6367849.hfWVFoRi9M@n95hx1g2> (raw)
In-Reply-To: <20201009073944.GA11648@pengutronix.de>
Hi Sascha,
On Friday, 9 October 2020, 09:39:44 CEST, Sascha Hauer wrote:
> On Fri, Oct 09, 2020 at 06:27:38AM +0200, Christian Eggers wrote:
> > This reverts commit 525c9e5a32bd7951eae3f06d9d077fea51718a6c.
> >
> > If CONFIG_PM is disabled, the system completely freezes on probe as
> > nothing enables the clock of the SPI peripheral.
>
> Instead of reverting it, why not just fix it?
I expect that 5.9 will be released soon. I think that in this late stage
reverting is more safe than fixing...
> Normally the device should be brought to active state manually in probe
> before pm_runtime takes over, then CONFIG_PM disabled doesn't hurt.
> Using pm_runtime to put the device to active state initially has the
> problem you describe.
Thanks for the hint. I've no experience in runtime power management. If you
could provide a patch against the current version, I can make a quick test. I
can also try to fix it myself, but this will take until next week.
Best regards
Christian
next prev parent reply other threads:[~2020-10-09 7:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 4:27 [PATCH] spi: imx: Revert "spi: imx: enable runtime pm support" Christian Eggers
2020-10-09 7:39 ` Sascha Hauer
2020-10-09 7:48 ` Christian Eggers [this message]
2020-10-12 14:07 ` Sascha Hauer
2020-10-13 11:58 ` Christian Eggers
2020-10-14 12:15 ` Mark Brown
2020-10-12 10:59 ` Christian Eggers
2020-10-12 13:28 ` Sascha Hauer
2020-10-12 13:42 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6367849.hfWVFoRi9M@n95hx1g2 \
--to=ceggers@arri.de \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).