From: John Garry <john.garry@huawei.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
<mark.rutland@arm.com>, <alexander.shishkin@linux.intel.com>,
<namhyung@kernel.org>, <will@kernel.org>, <ak@linux.intel.com>,
<linuxarm@huawei.com>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <suzuki.poulose@arm.com>,
<james.clark@arm.com>, <zhangshaokun@hisilicon.com>,
<robin.murphy@arm.com>
Subject: Re: [PATCH RFC 5/7] perf pmu: Support matching by sysid
Date: Mon, 10 Feb 2020 16:22:56 +0000 [thread overview]
Message-ID: <63799909-067b-e5f4-dcf1-9ba1ec145348@huawei.com> (raw)
In-Reply-To: <20200210120759.GG1907700@krava>
Hi jirka,
>
>> + fclose(file);
>> + pr_debug("gets failed for file %s\n", path);
>> + free(buf);
>> + return NULL;
>> + }
>> + fclose(file);
>> +
>> + /* Remove any whitespace, this could be from ACPI HID */
>> + s = strlen(buf);
>> + for (i = 0; i < s; i++) {
>> + if (buf[i] == ' ') {
>> + buf[i] = 0;
>> + break;
>> + };
>> + }
>> +
>> + return buf;
>> +}
>> +
I have another series to add kernel support for a system identifier
sysfs entry, which I sent after this series:
https://lore.kernel.org/linux-acpi/1580210059-199540-1-git-send-email-john.garry@huawei.com/
It is different to what I am relying on here - it uses a kernel soc
driver for firmware ACPI PPTT identifier. Progress is somewhat blocked
at the moment however and I may have to use a different method:
https://lore.kernel.org/linux-acpi/20200128123415.GB36168@bogus/
>> +static char *perf_pmu__getsysid(void)
>> +{
>> + char *sysid;
>> + static bool printed;
>> +
>> + sysid = getenv("PERF_SYSID");
>> + if (sysid)
>> + sysid = strdup(sysid);
>> +
>> + if (!sysid)
>> + sysid = get_sysid_str();
>> + if (!sysid)
>> + return NULL;
>> +
>> + if (!printed) {
>> + pr_debug("Using SYSID %s\n", sysid);
>> + printed = true;
>> + }
>> + return sysid;
>> +}
>
> this part is getting complicated and AFAIK we have no tests for it
>
> if you could think of any tests that'd be great.. Perhaps we could
> load 'our' json test files and check appropriate events/aliasses
> via in pmu object.. or via parse_events interface.. those test aliases
> would have to be part of perf, but we have tests compiled in anyway
Sorry, I don't fully follow.
Are you suggesting that we could load the specific JSONs tables for a
system from the host filesystem?
Thanks,
John
next prev parent reply other threads:[~2020-02-10 16:23 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 14:34 [PATCH RFC 0/7] perf pmu-events: Support event aliasing for system PMUs John Garry
2020-01-24 14:34 ` [PATCH RFC 1/7] perf jevents: Add support for an extra directory level John Garry
2020-02-10 12:07 ` Jiri Olsa
2020-02-10 15:47 ` John Garry
2020-01-24 14:35 ` [PATCH RFC 2/7] perf vendor events arm64: Relocate hip08 core events John Garry
2020-01-24 14:35 ` [PATCH RFC 3/7] perf jevents: Add support for a system events PMU John Garry
2020-02-10 12:07 ` Jiri Olsa
2020-02-10 12:07 ` Jiri Olsa
2020-02-10 15:55 ` John Garry
2020-02-11 14:46 ` Jiri Olsa
2020-01-24 14:35 ` [PATCH RFC 4/7] perf pmu: Rename uncore symbols to include system PMUs John Garry
2020-02-10 12:07 ` Jiri Olsa
2020-02-10 15:44 ` John Garry
2020-02-11 14:43 ` Jiri Olsa
2020-02-11 15:36 ` John Garry
2020-02-12 12:08 ` Jiri Olsa
2020-01-24 14:35 ` [PATCH RFC 5/7] perf pmu: Support matching by sysid John Garry
2020-02-10 12:07 ` Jiri Olsa
2020-02-10 16:22 ` John Garry [this message]
2020-02-11 13:47 ` Jiri Olsa
2020-02-11 15:07 ` John Garry
2020-02-12 10:08 ` John Garry
2020-02-12 12:16 ` Jiri Olsa
2020-02-12 12:24 ` John Garry
2020-01-24 14:35 ` [PATCH RFC 6/7] perf vendor events arm64: Relocate uncore events for hip08 John Garry
2020-01-24 14:35 ` [PATCH RFC 7/7] perf vendor events arm64: Add hip08 SMMUv3 PMCG IMP DEF events John Garry
2020-02-11 15:24 ` [PATCH RFC 0/7] perf pmu-events: Support event aliasing for system PMUs James Clark
2020-02-11 15:41 ` John Garry
2020-02-18 12:57 ` Will Deacon
2020-02-18 13:24 ` John Garry
2020-02-18 13:39 ` Will Deacon
2020-02-18 16:19 ` John Garry
2020-02-18 17:08 ` Mark Rutland
2020-02-18 17:58 ` John Garry
2020-02-18 18:13 ` Mark Rutland
2020-02-19 1:55 ` Joakim Zhang
2020-02-19 8:44 ` John Garry
2020-02-19 12:40 ` Joakim Zhang
2020-02-19 14:28 ` John Garry
2020-02-19 8:50 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63799909-067b-e5f4-dcf1-9ba1ec145348@huawei.com \
--to=john.garry@huawei.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=james.clark@arm.com \
--cc=jolsa@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=robin.murphy@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).