From: Dan Williams <dan.j.williams@intel.com>
To: Shiyang Ruan <ruansy.fnst@fujitsu.com>,
<linux-kernel@vger.kernel.org>, <linux-xfs@vger.kernel.org>,
<nvdimm@lists.linux.dev>, <linux-fsdevel@vger.kernel.org>
Cc: <djwong@kernel.org>, <david@fromorbit.com>,
<dan.j.williams@intel.com>, <akpm@linux-foundation.org>
Subject: RE: [PATCH 0/2] fsdax,xfs: fix warning messages
Date: Tue, 29 Nov 2022 19:59:14 -0800 [thread overview]
Message-ID: <6386d512ce3fc_c9572944e@dwillia2-mobl3.amr.corp.intel.com.notmuch> (raw)
In-Reply-To: <1669301694-16-1-git-send-email-ruansy.fnst@fujitsu.com>
[ add Andrew ]
Shiyang Ruan wrote:
> Many testcases failed in dax+reflink mode with warning message in dmesg.
> This also effects dax+noreflink mode if we run the test after a
> dax+reflink test. So, the most urgent thing is solving the warning
> messages.
>
> Patch 1 fixes some mistakes and adds handling of CoW cases not
> previously considered (srcmap is HOLE or UNWRITTEN).
> Patch 2 adds the implementation of unshare for fsdax.
>
> With these fixes, most warning messages in dax_associate_entry() are
> gone. But honestly, generic/388 will randomly failed with the warning.
> The case shutdown the xfs when fsstress is running, and do it for many
> times. I think the reason is that dax pages in use are not able to be
> invalidated in time when fs is shutdown. The next time dax page to be
> associated, it still remains the mapping value set last time. I'll keep
> on solving it.
>
> The warning message in dax_writeback_one() can also be fixed because of
> the dax unshare.
Thank you for digging in on this, I had been pinned down on CXL tasks
and worried that we would need to mark FS_DAX broken for a cycle, so
this is timely.
My only concern is that these patches look to have significant collisions with
the fsdax page reference counting reworks pending in linux-next. Although,
those are still sitting in mm-unstable:
http://lore.kernel.org/r/20221108162059.2ee440d5244657c4f16bdca0@linux-foundation.org
My preference would be to move ahead with both in which case I can help
rebase these fixes on top. In that scenario everything would go through
Andrew.
However, if we are getting too late in the cycle for that path I think
these dax-fixes take precedence, and one more cycle to let the page
reference count reworks sit is ok.
> Shiyang Ruan (2):
> fsdax,xfs: fix warning messages at dax_[dis]associate_entry()
> fsdax,xfs: port unshare to fsdax
>
> fs/dax.c | 166 ++++++++++++++++++++++++++++++-------------
> fs/xfs/xfs_iomap.c | 6 +-
> fs/xfs/xfs_reflink.c | 8 ++-
> include/linux/dax.h | 2 +
> 4 files changed, 129 insertions(+), 53 deletions(-)
>
> --
> 2.38.1
next prev parent reply other threads:[~2022-11-30 4:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 14:54 [PATCH 0/2] fsdax,xfs: fix warning messages Shiyang Ruan
2022-11-24 14:54 ` [PATCH 1/2] fsdax,xfs: fix warning messages at dax_[dis]associate_entry() Shiyang Ruan
2022-11-30 4:08 ` Darrick J. Wong
2022-11-30 8:58 ` Shiyang Ruan
2022-11-30 16:28 ` Darrick J. Wong
2022-11-30 4:12 ` Dan Williams
2022-11-24 14:54 ` [PATCH 2/2] fsdax,xfs: port unshare to fsdax Shiyang Ruan
2022-11-30 3:28 ` Darrick J. Wong
2022-11-27 18:38 ` [PATCH 0/2] fsdax,xfs: fix warning messages Darrick J. Wong
2022-11-28 2:16 ` Shiyang Ruan
2022-11-28 23:08 ` Darrick J. Wong
2022-11-30 3:59 ` Dan Williams [this message]
2022-11-30 4:16 ` Darrick J. Wong
2022-11-30 7:05 ` Dan Williams
2022-11-30 21:08 ` Darrick J. Wong
2022-12-01 15:39 ` Shiyang Ruan
2022-12-01 17:47 ` Darrick J. Wong
2022-11-30 21:27 ` Andrew Morton
2022-11-30 21:48 ` Dan Williams
2022-11-30 23:08 ` Darrick J. Wong
2022-11-30 23:58 ` Dan Williams
2022-11-30 10:30 ` [PATCH 0/2] fsdax,xfs: fix warning messages #forregzbot Thorsten Leemhuis
2022-12-12 7:06 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6386d512ce3fc_c9572944e@dwillia2-mobl3.amr.corp.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=ruansy.fnst@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).