From: tanmay@codeaurora.org
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Stephen Boyd <swboyd@chromium.org>,
Rob Clark <robdclark@gmail.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
freedreno <freedreno@lists.freedesktop.org>,
Sean Paul <seanpaul@chromium.org>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
aravindh@codeaurora.org, Abhinav Kumar <abhinavk@codeaurora.org>,
khsieh@codeaurora.org, Chandan Uddaraju <chandanu@codeaurora.org>,
Vara Reddy <varar@codeaurora.org>
Subject: Re: [PATCH v9 3/5] drm/msm/dp: add support for DP PLL driver
Date: Tue, 11 Aug 2020 12:49:00 -0700 [thread overview]
Message-ID: <639438051c1b2fe1d9bec5f6343a6dec@codeaurora.org> (raw)
In-Reply-To: <75acac5a-b4a5-9c5a-4404-fb936d738e46@infradead.org>
On 2020-08-07 13:28, Randy Dunlap wrote:
> On 8/7/20 1:24 PM, Stephen Boyd wrote:
>> Quoting Rob Clark (2020-08-07 08:51:48)
>>> On Fri, Aug 7, 2020 at 8:27 AM Randy Dunlap <rdunlap@infradead.org>
>>> wrote:
>>>>
>>>> On 8/7/20 12:17 AM, Tanmay Shah wrote:
>>>>> diff --git a/drivers/gpu/drm/msm/Kconfig
>>>>> b/drivers/gpu/drm/msm/Kconfig
>>>>> index ea3c4d094d09..cc1392b29022 100644
>>>>> --- a/drivers/gpu/drm/msm/Kconfig
>>>>> +++ b/drivers/gpu/drm/msm/Kconfig
>>>>> @@ -60,6 +60,7 @@ config DRM_MSM_HDMI_HDCP
>>>>> config DRM_MSM_DP
>>>>> bool "Enable DP support in MSM DRM driver"
>>>>> depends on DRM_MSM
>>>>> + default y
>>>>> help
>>>>> Compile in support for DP driver in msm drm driver. DP
>>>>> external
>>>>> display support is enabled through this config option. It
>>>>> can
>>>>
>>>> Hi,
>>>>
>>>> You need a very strong justification to make an optional part of a
>>>> driver
>>>> to be "default y".
>>>
>>> My opinion is that if the driver is built, everything should be
>>> built.
>>> This is what makes sense for distro's. It is only the embedded case
>>> where you want to trim down unneeded features where you might want to
>>> disable some parts. So 'default y' makes sense to me.
>
> We don't set defaults for distro convenience.
>
>>
>> Maybe use 'default DRM_MSM' so that it doesn't trigger the 'default y'
>> filters people have?
>
> Most people can figure that one out. ;)
> I don't have any automated filters.
After after further reviews, I agree with Rob. Display Port is required
module as of now so it makes sense to keep 'default y'.
next prev parent reply other threads:[~2020-08-11 19:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 7:17 [PATCH v9 0/5] Add support for DisplayPort driver on SnapDragon Tanmay Shah
2020-08-07 7:17 ` [PATCH v9 1/5] drm: add constant N value in helper file Tanmay Shah
2020-08-07 7:17 ` [PATCH v9 2/5] drm/msm/dp: add displayPort driver support Tanmay Shah
2020-08-07 15:37 ` Randy Dunlap
2020-08-07 15:49 ` Rob Clark
2020-08-07 16:11 ` Guenter Roeck
2020-08-07 16:09 ` Guenter Roeck
2020-08-07 16:21 ` Randy Dunlap
2020-08-07 7:17 ` [PATCH v9 3/5] drm/msm/dp: add support for DP PLL driver Tanmay Shah
2020-08-07 15:27 ` Randy Dunlap
2020-08-07 15:51 ` Rob Clark
2020-08-07 20:24 ` Stephen Boyd
2020-08-07 20:28 ` Randy Dunlap
2020-08-11 19:49 ` tanmay [this message]
2020-08-11 20:21 ` Randy Dunlap
2020-08-11 22:09 ` [Freedreno] " Tanmay Shah
2020-08-07 15:54 ` tanmay
2020-08-07 7:17 ` [PATCH v9 4/5] drm/msm/dpu: add display port support in DPU Tanmay Shah
2020-08-07 7:17 ` [PATCH v9 5/5] drm/msm/dp: Add Display Port HPD feature Tanmay Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=639438051c1b2fe1d9bec5f6343a6dec@codeaurora.org \
--to=tanmay@codeaurora.org \
--cc=abhinavk@codeaurora.org \
--cc=airlied@linux.ie \
--cc=aravindh@codeaurora.org \
--cc=chandanu@codeaurora.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=khsieh@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=robdclark@gmail.com \
--cc=seanpaul@chromium.org \
--cc=swboyd@chromium.org \
--cc=varar@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).