From: Josh Poimboeuf <jpoimboe@redhat.com>
To: x86@kernel.org
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Vince Weaver <vincent.weaver@maine.edu>, Dave Jones <dsj@fb.com>,
Jann Horn <jannh@google.com>, Miroslav Benes <mbenes@suse.cz>,
Andy Lutomirski <luto@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH 07/14] x86/unwind/orc: Convert global variables to static
Date: Thu, 12 Mar 2020 12:30:26 -0500 [thread overview]
Message-ID: <63b5cab2e28b9c08854fc57f5b512a9ccf76ad95.1584033751.git.jpoimboe@redhat.com> (raw)
In-Reply-To: <cover.1584033751.git.jpoimboe@redhat.com>
These variables aren't used outside of unwind_orc.c, make them static.
Also annotate some of them with '__ro_after_init', as applicable.
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
---
arch/x86/kernel/unwind_orc.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/x86/kernel/unwind_orc.c b/arch/x86/kernel/unwind_orc.c
index e9cc182aa97e..64889da666f4 100644
--- a/arch/x86/kernel/unwind_orc.c
+++ b/arch/x86/kernel/unwind_orc.c
@@ -15,12 +15,12 @@ extern int __stop_orc_unwind_ip[];
extern struct orc_entry __start_orc_unwind[];
extern struct orc_entry __stop_orc_unwind[];
-static DEFINE_MUTEX(sort_mutex);
-int *cur_orc_ip_table = __start_orc_unwind_ip;
-struct orc_entry *cur_orc_table = __start_orc_unwind;
+static bool orc_init __ro_after_init;
+static unsigned int lookup_num_blocks __ro_after_init;
-unsigned int lookup_num_blocks;
-bool orc_init;
+static DEFINE_MUTEX(sort_mutex);
+static int *cur_orc_ip_table = __start_orc_unwind_ip;
+static struct orc_entry *cur_orc_table = __start_orc_unwind;
static inline unsigned long orc_ip(const int *ip)
{
--
2.21.1
next prev parent reply other threads:[~2020-03-12 17:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 17:30 [PATCH 00/14] x86/unwind/orc: ORC fixes Josh Poimboeuf
2020-03-12 17:30 ` [PATCH 01/14] x86/dumpstack: Add SHOW_REGS_IRET mode Josh Poimboeuf
2020-03-13 11:10 ` Miroslav Benes
2020-03-12 17:30 ` [PATCH 02/14] objtool: Fix stack offset tracking for indirect CFAs Josh Poimboeuf
2020-03-12 17:30 ` [PATCH 03/14] x86/entry/64: Fix unwind hints in register clearing code Josh Poimboeuf
2020-03-12 19:29 ` Andy Lutomirski
2020-03-12 19:57 ` Josh Poimboeuf
2020-03-12 20:07 ` Peter Zijlstra
2020-03-12 21:24 ` Jann Horn
2020-03-12 17:30 ` [PATCH 04/14] x86/entry/64: Fix unwind hints in kernel exit path Josh Poimboeuf
2020-03-12 17:30 ` [PATCH 05/14] x86/entry/64: Fix unwind hints in __switch_to_asm() Josh Poimboeuf
2020-03-12 17:30 ` [PATCH 06/14] x86/entry/64: Fix unwind hints in rewind_stack_do_exit() Josh Poimboeuf
2020-03-12 17:30 ` Josh Poimboeuf [this message]
2020-03-12 17:30 ` [PATCH 08/14] x86/unwind: Prevent false warnings for non-current tasks Josh Poimboeuf
2020-03-12 17:30 ` [PATCH 09/14] x86/unwind/orc: Don't skip the first frame for inactive tasks Josh Poimboeuf
2020-03-12 17:30 ` [PATCH 10/14] x86/unwind/orc: Prevent unwinding before ORC initialization Josh Poimboeuf
2020-03-13 12:24 ` Miroslav Benes
2020-03-12 17:30 ` [PATCH 11/14] x86/unwind/orc: Fix error path for bad ORC entry type Josh Poimboeuf
2020-03-12 17:30 ` [PATCH 12/14] x86/unwind/orc: Fix premature unwind stoppage due to IRET frames Josh Poimboeuf
2020-03-12 17:30 ` [PATCH 13/14] x86/unwind/orc: Add more unwinder warnings Josh Poimboeuf
2020-03-12 19:12 ` Jann Horn
2020-03-12 19:20 ` Josh Poimboeuf
2020-03-12 17:30 ` [PATCH 14/14] x86/unwind/orc: Add 'unwind_debug' cmdline option Josh Poimboeuf
2020-03-12 19:15 ` [PATCH 00/14] x86/unwind/orc: ORC fixes Peter Zijlstra
2020-03-13 14:00 ` Miroslav Benes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63b5cab2e28b9c08854fc57f5b512a9ccf76ad95.1584033751.git.jpoimboe@redhat.com \
--to=jpoimboe@redhat.com \
--cc=dsj@fb.com \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mbenes@suse.cz \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vincent.weaver@maine.edu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).