From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762997AbdEVXgI (ORCPT ); Mon, 22 May 2017 19:36:08 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:60840 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759940AbdEVXgB (ORCPT ); Mon, 22 May 2017 19:36:01 -0400 Subject: Re: [PATCH net-next 2/2] samples/bpf: add samples for HW_CACHE / RAW events To: David Miller References: <20170522224840.810121-1-ast@fb.com> <20170522224840.810121-3-ast@fb.com> <20170522.192651.252662920166760334.davem@davemloft.net> CC: , , , , , , From: Alexei Starovoitov Message-ID: <63c0ec55-9cb7-50a0-2020-fe17283e532b@fb.com> Date: Mon, 22 May 2017 16:35:07 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170522.192651.252662920166760334.davem@davemloft.net> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [2620:10d:c090:180::1:b527] X-ClientProxiedBy: BN6PR04CA0023.namprd04.prod.outlook.com (10.172.194.33) To DM3PR15MB0969.namprd15.prod.outlook.com (10.166.159.151) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM3PR15MB0969: X-MS-Office365-Filtering-Correlation-Id: 0b0d734a-b774-4afb-f4bb-08d4a16b320a X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:DM3PR15MB0969; X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB0969;3:KHjbmTnFczvcDQZGwPFKPjJO1RtINNHxA9SkmZPUqeJJajjOujitbOxV757GQUMgNEKdAav6E3e1FGtCfUHZ4kW77z9dMsYdNGyyJt0GoKUjhSmTTZzC1mNcka9w9cllXLxT+iXbF+fyaCRKqBrLjbIJ/sl8GVEK/JntMXR/pp8hZX/XolCE3rka2mYckYem8amxJVNTryOAixK7t56mG6C7YPzjAyUEZzYoGY/t1xWHOKu0qkrHGsnHdfsdwEoIjZiNNcJcfRdb/r5tTl+tEw3bgGn3wKNS3o1f+1W9nPem4HRWNpOwHokUTyaCJIOhURAF6gWBl3WP17oQ084HIg==;25:0cH2leQtfXIFZncQU/dueO2LQM2KYrJGXI3r1fYhKVEGyLCw3zORVPvcZXgCFNHs7Nn1ngMbaw6E6qjkMq3dkvbINLRy7ePxgwmp8j/wTtsRVCwJAqYdgEnv2MMRAo8T0+FFMqqKmDzfvC/ejHB9TMAMALa2PvpsybZtRGLYIGgAt+8lu4M9fdPyAk5AjK+NycVZl4u4HzSzABnI7VPntacnzwup4ddcjcscK0NNBElhUbwNoQex7oNBhxkzTroiPNVIASLdITpJeOnDn/O31sQ18SsaakZPumzV/DunlsF67/lG/lJSZK/BKPaepY9D2LMITdxu6yIwCe6dnR8wdxZSrH7WgXxo+iXw+syT9jaVhahSVtoFYFuJb1NF3dF4/gtdLRrB0Ur5oEHQJoAzQ4nlq1VUo0y32Q3G4AmCUlRatX/uEsNM88pbr+LGmVirirsoP9ZHf59w7F36tRKzBqHlpwu2a6aDAuDkDRnMLc0= X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB0969;31:gt1qOon/U8Gj7ghIsmUBRJwx9vIDZ/dtYuegn3BCPu90fl3lcZqbBxQEhMYJzNjPy6IFiGNT+2CuhuZesoaSiywB6J9nqkcC8eTY4vW4xrFImPv01xFQEGhxAXme2sbYc8v3kL9NtdBipKnoIHwfSTTj1ZxsvzeAfpIg5nj2B0teX1U+qwv6NsU1gjb27L5C0vtOsEhIZg2t4sqnSfFdmap84qt5673ONHtFG8dKSTE=;20:dnfNMn9/C8toNym+4WpMxUM1z4AHLc7E7fSUloNShy8x0hNPGx3BjKBeo9vQJAd48kcnP4hhXdaw1uk9IBlzfm2dI62za78ZPnl6hGDHU8fM4eQt+npEnJ0t+sSYfxWP2p4N6LG7R4R7IpERWc/kY2BMMPTpL1b9xibbmtuiXqh/Yr0+PREd5NDtWn8r72NwGhbo/vio2Sis1QQRlqProI3adWVlWjoN3cql/0pJhQDDNgV197OI2Xk+6w3IM/mXTIcGi1eKkz2cE36vpoBCkZ8XCEt28HJm2gU5jiEcBkVTHrPfj79bveb7ZQLo3uqZ/t2fKRADSH7RyzCmm5sdnonMGz+3sWOPTkz6CcNiaEL1dGkkcTiIJgd5kEcV3PLPP5WbudALxeOmVUHi7IfB090XrJrp2ptUhlnBmBYEkfpsOBAMV3JF1L4c7/hQ6l6A/+QmuyuJ5+RdTvGEakD+2FvswjrIYfHOLFmP5Uy30fax1xPK3+kCoQ56K7IZD6J+ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(67672495146484); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123558100)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(6072148);SRVR:DM3PR15MB0969;BCL:0;PCL:0;RULEID:;SRVR:DM3PR15MB0969; X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB0969;4:ih8Zd+1OkLkWb2V5yDaH7rB4FPODtpmLhsUhOeuqlzFOQoYifCiSs7QVtXxN61mbkrTVUK76NBR5oqlNA4AHZ5cNQVMW6xC1ENGXDwNx7neUk1LbP8u+C05v+D1xyfkoPSEO/zF6AzyiKxzvdnWUPfK+zg6SyNpm8ZBYLOYZfhiYuX1T+9SuTknHf+/BZjOH717t9uHnei2HtddtBF2oEWjl5d3pWG6GtJArlcuT/TCrVqN9wdHkLx6vFtNsxPfTJ5aNCYNEP4p9fi9e3KDpXWOZMNpseSQqFZnB7Kifv1yyG/V0GuJjNt1zM0jy7VDiLu3JZFgbuq+b9wbisNt3K5nVAXO0nNYDPdNdLkmtZM/5+12Ic8oyfDa2mIF180EFZ0KtsbkRuj50/hM/K9zDM9WnmkyKDsXnhDIc0sw8vsGWi/y6DNwm74PCacOCNLw+8XqmschCOhHkx4wqWtMoGluSbbz4PFqtJCRevvZwxpf3Vn5yOeBlG3ebNUyg+kCcQ+Bz2J7jvBcOEBHqwSq2rr+J/s8ys66bWcAT/yMwvFw+2cdLSN0ayUsuFiSBj4k2JWQoZpspLINwJ3L7AAnNu/s02GqNVIUg7l4AO3fAH4fn0FjxfUbuQ4GGAwxhN5j8BNlWWH5yizDTEOfAOXz51HkvgX9tDF6csX90XDWUcWMC5KD4rhhGTBLEoSGn5iNWqET8yHHox4TabCju2h0qvPcZ4lQw7KLNsdBPOvwYOfaETPw6eMcAKcbeKMMY+6PCJwSzP8biZhrk759Vmq5UsOYWgv/D8jawfC70ccTc11OvwHlTq8ubZR1VkiKeYX9lfJPlLc4D8YzSgQpZSOqTJw== X-Forefront-PRVS: 03152A99FF X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(39850400002)(39450400003)(39840400002)(39400400002)(39410400002)(377454003)(24454002)(83506001)(6246003)(6116002)(229853002)(47776003)(65806001)(65956001)(53936002)(189998001)(50466002)(76176999)(31696002)(64126003)(230700001)(38730400002)(50986999)(8676002)(81166006)(86362001)(110136004)(36756003)(54356999)(2950100002)(6916009)(478600001)(5660300001)(4001350100001)(23746002)(33646002)(2906002)(7736002)(25786009)(42186005)(6486002)(4326008)(6666003)(53546009)(305945005)(31686004)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM3PR15MB0969;H:[IPv6:2620:10d:c081:1132::10e1];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DM3PR15MB0969;23:WcAvcDu2nYGgIFXTfq7QMqGmSO/cXxE1qqn6J?= =?Windows-1252?Q?GJD0zM6/dXcrFXGgSUq2w8zJ0iiMsLcUk7gvWZ2ejSrZPpjz997dwuWg?= =?Windows-1252?Q?Qpdur0h07BPT9vrznA/1bY2LgCvkQnX6Rdg3gZEG08qm5qxuC5h/tj9W?= =?Windows-1252?Q?Tu1CCEGlA808jOj5zeXnUwk7Ue2td8Db4pMkGGazWGBjAiZfyiADQWJt?= =?Windows-1252?Q?xKzurVtQJAKWvXSu6HI/y1OGXeA5NULSePww5OKArxGyL1XpFAXxd8KW?= =?Windows-1252?Q?9c7QA6xm3JAmLteRld005YZWdPA9o3q5otg4oGLXWwfnUjNTMlTBu8I8?= =?Windows-1252?Q?tWs0FQwlloFjJK+Ny7RpKXAZFM0Nv0WLUiHA6FKYTv/ZrqpEsw2WYGka?= =?Windows-1252?Q?30vjLoIPv9ji82Vu7yC5enp+oRdtdKTUIOhsZGc+yloMgWxTGn7jLiJq?= =?Windows-1252?Q?bbJF4KwPBBJXE3o1FRz9QaRmSHnwoUeDrVXbt3MqELPUzY3oiGpIFbud?= =?Windows-1252?Q?eqwq4Pw3VJRuyHRaPTDlbMyeDVMV29rtve4xr5FOcMXHm1U0AI+r9blV?= =?Windows-1252?Q?7EEdL3cW7r50aJYp/DYsKSFgeftrdNXF9esXDgPdamuC0DfTSjnnpjIm?= =?Windows-1252?Q?6m7y6JGZAkoNTcP0286n6e9QFAZ0UCbEUvWznt0FzysqH5uolYb14pxD?= =?Windows-1252?Q?+qFAh/xLCzbuQePEhWV+1i4AMQgvsQieYDVoDLDwj0wNCwrobSP8dpip?= =?Windows-1252?Q?Pj+oSrtayoTslJiXOLT1nyROWqI1v30tG3058uQZ9eosCMaLR5ZyJ/SQ?= =?Windows-1252?Q?EkT+PrrePESOR8yo8YUWAa2quN9FUOLtmEbv7lJ3/zPe75VkLwwk/PcF?= =?Windows-1252?Q?dJNW6bfkAVSJknvj/rgHLuG7EV0XYxdBZhyGXErSEOo8XJ3Nlqkj2++8?= =?Windows-1252?Q?8r773gFlxSp12T4v6TfkiJLYVbrb6u2GkzhkWPCgOm9ehWrVLj+rI7vl?= =?Windows-1252?Q?UD1wdIP2eXTNY0lAYy4aQM+Fdy/XjzKuxcrYcLrC3sumII4TbDSJo6li?= =?Windows-1252?Q?QJsgt2tBIFKTU2sEx0L+m8/LGch4l1AUag3m97ymJApsKEUpjajjwUvS?= =?Windows-1252?Q?B2mOzwfRN5XeYT3z1d9myeBpu/NAujG4IL8+xbk7GeK3n6SL8/QNfGgf?= =?Windows-1252?Q?Sq8ij8ZOdjJVhptGFSui+KaOWkQ7CU11Imc4zLrIuoDyxeiHecH6FRje?= =?Windows-1252?Q?bwsciVMA5m5Ou1Sl+b4Cb4M+T1kgc/HYMQZpFnmEQsWxJ4w1OQkCIeYo?= =?Windows-1252?Q?d6K5PpeLT3+J2kKtvwbX0s0fw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB0969;6:iJwpceqhoalglIhmcFU/Uszd57ZUbgFiX1LXaAIIg8T0/0DBxyRfduD1fDNGy6RsyFaf4wdOaQ3X2Ef3ZznbrWtb1wRPxDpQBSs7NEfFPVep1jjrq24+rW8bsjIiXKW+EnoKmP/7iOjE+gbZFb9dsUTWLUK7l4bDFFHmjGrh8LZTVsiwte4rINoqxV0BuQr8B+vyp7n69vkZsqc2ojwV1Tb7Zdh52lhTCBNxs8hGEm3nBWZepRXyznIkHzwX+kQmoyJ7+gH6SCJ7wXpLH+pzgoTQAUbx+OXRYEbE11HOITPtLNeseUZ4m8wgwlk8lL5i7uUJxMhps9MS2/jdvNu6J7cAtMiFWP3c8/qSR4hryB2uEXSQ0N577+HvlPmJw9ir/ujSzqKKcniquMHAPFQfk3YHkn05EknQnY0ITc7imbg7qYpsRl1RoD6knUSjgKLpy6DXB5zVn9Lm9pDbi5NkDlcTOxFgc0/9i/hgla9mSwDIPfLNoUBgvk2iVDPX8D1Wqe01DwoQnL/uyRJKhRHvgA==;5:8gW16foUEDsfNbjjz8C+q2GY/w5pTCVARQG70vHxQOt1C9uQebRfm3+lIGlj+33tuCRjLZ1yQJp7e8HPgyEEcxBoNMNRU5MSbbWdPXe9EpgcuGygH+uCcsEpdmSlFjOw5YfaUJZZjMjieNAagKVWNQ==;24:SFaU9Dxgo7HgWi7uDOojhOJQWKfiI2xYAX9NvjrZwuQQfdu7gqglZzSfOW/p1s4HENZAlp9P/2XtzGLMERGZyFH1bYYfR64dabpsa4OJW/A= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB0969;7:pLe30qvGtMedcj0WS+v3OnYbCd26THbd8BAXGIv5nAJuGHZvK0R7wOxey4OKtUONOj6J5FyevUtK+w1w09uznz/3j9Tn/RTsWffQIJ8Up42hmVoutoRLAbzQSCtjoNOeAmPndVQkJMfQI1xfBkJBgyPPlg858VBmlVNXybhuT+DcBnG/FNPqX8iIfRj/YmxcTkioQLhlLrXkOC+BSXe3mja0x/apVN4iwqHwTUbrpP52/3RNfYHp0kSdQ0IHSygMd15qdJU5jA9NlSlUQluyvMtmBE9j2SYxUUylLYt9lBO7owPYzsOGf93UWRCGpIYy2Jre2YAjEniEbrClUAxi4w==;20:20Cv4yl/0//VascNfkq5JuntNkMJu+EO8ff7HYpUBKTuG4zQARfcMNZqB8ScbofmzgUE7EkqkLbHcZqBKpi7ic5Bv4mqdUYIcte3dp1oLVbBEvN7ydHgfyKasZWPjFf5I52V2FmLnEl7zunINIuPOjmMHuev/3Q7CkVjBUstiJE= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2017 23:35:12.4471 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR15MB0969 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-22_12:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/22/17 4:26 PM, David Miller wrote: > From: Alexei Starovoitov > Date: Mon, 22 May 2017 15:48:40 -0700 > >> @@ -31,7 +31,7 @@ static unsigned long long (*bpf_get_current_uid_gid)(void) = >> (void *) BPF_FUNC_get_current_uid_gid; >> static int (*bpf_get_current_comm)(void *buf, int buf_size) = >> (void *) BPF_FUNC_get_current_comm; >> -static int (*bpf_perf_event_read)(void *map, int index) = >> +static u64 (*bpf_perf_event_read)(void *map, u64 flags) = >> (void *) BPF_FUNC_perf_event_read; > > If the second argument really is "u64 flags", then please update > the comments in tools/include/uapi/linux/bpf.h as well. of course. As independent patch, I assume. For both tools/include/uapi/...bpf.h and include/uapi/...bpf.h It has some info: /* BPF_FUNC_perf_event_output and BPF_FUNC_perf_event_read flags. */ #define BPF_F_INDEX_MASK 0xffffffffULL #define BPF_F_CURRENT_CPU BPF_F_INDEX_MASK yet perf_event_read() is least documented. hmm. * u64 bpf_perf_event_read(&map, index) * Return: Number events read or error code that needs to be fixed.