From: David Lechner <david@lechnology.com>
To: "Noralf Trønnes" <noralf@tronnes.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org
Cc: limor@ladyada.net, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] drm/tinydrm: add driver for ST7735R panels
Date: Fri, 8 Dec 2017 15:25:09 -0600 [thread overview]
Message-ID: <63ca5df1-3908-fcba-9391-ce9ef035086f@lechnology.com> (raw)
In-Reply-To: <455f5c7a-9f3c-c019-9418-94f0c2015afd@tronnes.org>
On 12/06/2017 12:27 PM, Noralf Trønnes wrote:
>
> Den 29.11.2017 04.01, skrev David Lechner:
>> This adds a new driver for Sitronix ST7735R display panels.
>>
>> This has been tested using an Adafruit 1.8" TFT.
>>
>> Signed-off-by: David Lechner <david@lechnology.com>
>> ---
>> MAINTAINERS | 6 +
>> drivers/gpu/drm/tinydrm/Kconfig | 10 ++
>> drivers/gpu/drm/tinydrm/Makefile | 1 +
>> drivers/gpu/drm/tinydrm/st7735r.c | 237
>> ++++++++++++++++++++++++++++++++++++++
>> 4 files changed, 254 insertions(+)
>> create mode 100644 drivers/gpu/drm/tinydrm/st7735r.c
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index a174632..9c7707e 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -4462,6 +4462,12 @@ S: Maintained
>> F: drivers/gpu/drm/tinydrm/st7586.c
>> F: Documentation/devicetree/bindings/display/st7586.txt
>> +DRM DRIVER FOR SITRONIX ST7735R PANELS
>> +M: David Lechner <david@lechnology.com>
>
> I know we haven't done this in the other tinydrm drivers, but I think
> we should start adding which tree the development is happening in:
>
> T: git git://anongit.freedesktop.org/drm/drm-misc
This is inherited, just like L:, so get_maintainers.pl --scm returns git
git://anongit.freedesktop.org/drm/drm-misc already. So there doesn't
seem to be a need to add this line.
>
>> +S: Maintained
>> +F: drivers/gpu/drm/tinydrm/st7735r.c
>> +F: Documentation/devicetree/bindings/display/st7735r.txt
<snip>
>> +}
>> +
>> +static void st7735r_pipe_disable(struct drm_simple_display_pipe *pipe)
>> +{
>> + struct tinydrm_device *tdev = pipe_to_tinydrm(pipe);
>> + struct mipi_dbi *mipi = mipi_dbi_from_tinydrm(tdev);
>> +
>
> Please use mipi_dbi_pipe_disable() here.
>
>> + DRM_DEBUG_KMS("\n");
>> +
>> + if (!mipi->enabled)
>> + return;
>> +
>> + tinydrm_disable_backlight(mipi->backlight);
>> +
>> + mipi_dbi_command(mipi, MIPI_DCS_SET_DISPLAY_OFF);
>
> You turn off the panel, have you checked what it looks like if you don't
> turn off backlight (which is optional in this driver)?
>
> On the displays I have tried this on, all pixels turn white when they're
> not driven, letting backlight through, giving an all white display.
> That's why I have that blanking code in mipi_dbi_pipe_disable() when we
> don't have backlight control and the reason I don't turn off the panel.
> The power savings of not driving the panel is negligible AFAICR.
>
> If you don't need DISPLAY_OFF, you can just use mipi_dbi_pipe_disable()
> directly as the callback.
>
I tested this and you are right, it causes the panel to go white when a
backlight is not specified, so I will just use mipi_dbi_pipe_disable().
next prev parent reply other threads:[~2017-12-08 21:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 3:01 [PATCH v1 0/2] DRM driver for Sitronix ST7735R display panels David Lechner
2017-11-29 3:01 ` [PATCH v1 1/2] dt-bindings: Add binding " David Lechner
2017-12-01 2:04 ` Rob Herring
2017-12-08 21:41 ` Noralf Trønnes
2017-12-10 19:33 ` David Lechner
2017-11-29 3:01 ` [PATCH v1 2/2] drm/tinydrm: add driver for ST7735R panels David Lechner
2017-12-06 18:27 ` Noralf Trønnes
2017-12-08 14:11 ` Noralf Trønnes
2017-12-08 21:25 ` David Lechner [this message]
2017-12-09 12:21 ` Noralf Trønnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63ca5df1-3908-fcba-9391-ce9ef035086f@lechnology.com \
--to=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=limor@ladyada.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=noralf@tronnes.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).