From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux ACPI <linux-acpi@vger.kernel.org>
Cc: alsa-devel@alsa-project.org, Linux PM <linux-pm@vger.kernel.org>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Vinod Koul <vkoul@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Sanyog Kale <sanyog.r.kale@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH v1 14/16] soundwire: Use acpi_dev_for_each_child()
Date: Thu, 9 Jun 2022 10:22:39 -0500 [thread overview]
Message-ID: <63d7f3ed-b5a9-c869-5d25-a33a1d4e63c8@linux.intel.com> (raw)
In-Reply-To: <5296779.Sb9uPGUboI@kreacher>
Thanks Rafael. This looks mostly good but I have a doubt on the error
handling, see below.
> +static int sdw_acpi_check_duplicate(struct acpi_device *adev, void *data)
> +{
> + struct sdw_acpi_child_walk_data *cwd = data;
> + struct sdw_bus *bus = cwd->bus;
> + struct sdw_slave_id id;
> +
> + if (adev == cwd->adev)
> + return 0;
> +
> + if (!find_slave(bus, adev, &id))
> + return 0;
> +
> + if (cwd->id.sdw_version != id.sdw_version || cwd->id.mfg_id != id.mfg_id ||
> + cwd->id.part_id != id.part_id || cwd->id.class_id != id.class_id)
> + return 0;
> +
> + if (cwd->id.unique_id != id.unique_id) {
> + dev_dbg(bus->dev,
> + "Valid unique IDs 0x%x 0x%x for Slave mfg_id 0x%04x, part_id 0x%04x\n",
> + cwd->id.unique_id, id.unique_id, cwd->id.mfg_id,
> + cwd->id.part_id);
> + cwd->ignore_unique_id = false;
> + return 0;
> + }
> +
> + dev_err(bus->dev,
> + "Invalid unique IDs 0x%x 0x%x for Slave mfg_id 0x%04x, part_id 0x%04x\n",
> + cwd->id.unique_id, id.unique_id, cwd->id.mfg_id, cwd->id.part_id);
> + return -ENODEV;
if this error happens, I would guess it's reported ....
> +}
> +
> +static int sdw_acpi_find_one(struct acpi_device *adev, void *data)
> +{
> + struct sdw_bus *bus = data;
> + struct sdw_acpi_child_walk_data cwd = {
> + .bus = bus,
> + .adev = adev,
> + .ignore_unique_id = true,
> + };
> + int ret;
> +
> + if (!find_slave(bus, adev, &cwd.id))
> + return 0;
> +
> + /* Brute-force O(N^2) search for duplicates. */
> + ret = acpi_dev_for_each_child(ACPI_COMPANION(bus->dev),
> + sdw_acpi_check_duplicate, &cwd);
> + if (ret)
> + return ret;
... here, but I don't see this being propagated further...
> +
> + if (cwd.ignore_unique_id)
> + cwd.id.unique_id = SDW_IGNORED_UNIQUE_ID;
> +
> + /* Ignore errors and continue. */
> + sdw_slave_add(bus, &cwd.id, acpi_fwnode_handle(adev));
> + return 0;
> +}
> +
> /*
> * sdw_acpi_find_slaves() - Find Slave devices in Master ACPI node
> * @bus: SDW bus instance
> @@ -135,8 +200,7 @@ static bool find_slave(struct sdw_bus *b
> */
> int sdw_acpi_find_slaves(struct sdw_bus *bus)
> {
> - struct acpi_device *adev, *parent;
> - struct acpi_device *adev2, *parent2;
> + struct acpi_device *parent;
>
> parent = ACPI_COMPANION(bus->dev);
> if (!parent) {
> @@ -144,52 +208,7 @@ int sdw_acpi_find_slaves(struct sdw_bus
> return -ENODEV;
> }
>
> - list_for_each_entry(adev, &parent->children, node) {
> - struct sdw_slave_id id;
> - struct sdw_slave_id id2;
> - bool ignore_unique_id = true;
> -
> - if (!find_slave(bus, adev, &id))
> - continue;
> -
> - /* brute-force O(N^2) search for duplicates */
> - parent2 = parent;
> - list_for_each_entry(adev2, &parent2->children, node) {
> -
> - if (adev == adev2)
> - continue;
> -
> - if (!find_slave(bus, adev2, &id2))
> - continue;
> -
> - if (id.sdw_version != id2.sdw_version ||
> - id.mfg_id != id2.mfg_id ||
> - id.part_id != id2.part_id ||
> - id.class_id != id2.class_id)
> - continue;
> -
> - if (id.unique_id != id2.unique_id) {
> - dev_dbg(bus->dev,
> - "Valid unique IDs 0x%x 0x%x for Slave mfg_id 0x%04x, part_id 0x%04x\n",
> - id.unique_id, id2.unique_id, id.mfg_id, id.part_id);
> - ignore_unique_id = false;
> - } else {
> - dev_err(bus->dev,
> - "Invalid unique IDs 0x%x 0x%x for Slave mfg_id 0x%04x, part_id 0x%04x\n",
> - id.unique_id, id2.unique_id, id.mfg_id, id.part_id);
> - return -ENODEV;
> - }
> - }
> -
> - if (ignore_unique_id)
> - id.unique_id = SDW_IGNORED_UNIQUE_ID;
> -
> - /*
> - * don't error check for sdw_slave_add as we want to continue
> - * adding Slaves
> - */
> - sdw_slave_add(bus, &id, acpi_fwnode_handle(adev));
> - }
> + acpi_dev_for_each_child(parent, sdw_acpi_find_one, bus);
... here?
It looks like a change in the error handling flow where
sdw_acpi_find_slaves() is now returning 0 (success) always?
Shouldn't the return of sdw_acpi_find_one() be trapped, e.g. with
return acpi_dev_for_each_child(parent, sdw_acpi_find_one, bus);
>
> return 0;
> }
>
>
>
next prev parent reply other threads:[~2022-06-09 15:23 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 13:44 [PATCH v1 00/16] ACPI: Get rid of the list of children in struct acpi_device Rafael J. Wysocki
2022-06-09 13:47 ` [PATCH v1 01/16] ACPI: glue: Use acpi_dev_for_each_child() Rafael J. Wysocki
2022-06-09 13:49 ` [PATCH v1 02/16] ACPI: glue: Introduce acpi_dev_has_children() Rafael J. Wysocki
2022-06-09 13:54 ` [PATCH v1 03/16] ACPI: glue: Introduce acpi_find_child_by_adr() Rafael J. Wysocki
2022-06-09 13:54 ` [PATCH v1 04/16] thunderbolt: ACPI: Use acpi_find_child_by_adr() Rafael J. Wysocki
2022-06-09 15:25 ` Andy Shevchenko
2022-06-09 15:36 ` Rafael J. Wysocki
2022-06-10 6:46 ` Heikki Krogerus
2022-06-10 13:12 ` Rafael J. Wysocki
2022-06-09 13:56 ` [PATCH v1 05/16] USB: " Rafael J. Wysocki
2022-06-09 15:27 ` Andy Shevchenko
2022-06-09 15:37 ` Rafael J. Wysocki
2022-06-10 6:47 ` Heikki Krogerus
2022-06-10 13:14 ` Rafael J. Wysocki
2022-06-09 13:58 ` [PATCH v1 06/16] ACPI: container: Use acpi_dev_for_each_child() Rafael J. Wysocki
2022-06-09 15:29 ` Andy Shevchenko
2022-06-09 15:58 ` Rafael J. Wysocki
2022-06-09 13:59 ` [PATCH v1 07/16] ACPI: property: Use acpi_dev_for_each_child() for child lookup Rafael J. Wysocki
2022-06-09 14:02 ` [PATCH v1 08/16] ACPI: bus: Export acpi_dev_for_each_child() to modules Rafael J. Wysocki
2022-06-09 14:03 ` [PATCH v1 09/16] ACPI: video: Use acpi_dev_for_each_child() Rafael J. Wysocki
2022-06-09 15:40 ` Andy Shevchenko
2022-06-09 14:06 ` [PATCH v1 10/16] ACPI: bus: Introduce acpi_dev_for_each_child_reverse() Rafael J. Wysocki
2022-06-09 15:40 ` Andy Shevchenko
2022-06-09 14:07 ` [PATCH v1 11/16] ACPI: scan: Walk ACPI device's children using driver core Rafael J. Wysocki
2022-06-09 14:09 ` [PATCH v1 12/16] platform/x86/thinkpad_acpi: Use acpi_dev_for_each_child() Rafael J. Wysocki
2022-06-09 15:48 ` Andy Shevchenko
2022-06-09 15:56 ` Rafael J. Wysocki
2022-06-09 14:12 ` [PATCH v1 13/16] mfd: core: " Rafael J. Wysocki
2022-06-09 14:16 ` [PATCH v1 14/16] soundwire: " Rafael J. Wysocki
2022-06-09 15:22 ` Pierre-Louis Bossart [this message]
2022-06-09 16:13 ` Rafael J. Wysocki
2022-06-09 16:21 ` Pierre-Louis Bossart
2022-06-09 17:35 ` Rafael J. Wysocki
2022-06-09 19:08 ` Pierre-Louis Bossart
2022-06-09 14:18 ` [PATCH v1 15/16] ACPI / MMC: PM: Unify fixing up device power Rafael J. Wysocki
2022-06-09 15:33 ` Adrian Hunter
2022-06-10 12:16 ` Ulf Hansson
2022-06-09 14:19 ` [PATCH v1 16/16] ACPI: bus: Drop unused list heads from struct acpi_device Rafael J. Wysocki
2022-06-09 15:12 ` [PATCH v1 00/16] ACPI: Get rid of the list of children in " Andy Shevchenko
2022-06-09 20:24 ` Frank Rowand
2022-06-09 15:56 ` Andy Shevchenko
2022-06-09 15:59 ` Rafael J. Wysocki
2022-06-13 18:03 ` [PATCH v2 " Rafael J. Wysocki
2022-06-13 18:05 ` [PATCH v2 01/16] ACPI: glue: Use acpi_dev_for_each_child() Rafael J. Wysocki
2022-06-13 18:06 ` [PATCH v2 02/16] ACPI: glue: Introduce acpi_dev_has_children() Rafael J. Wysocki
2022-06-13 18:10 ` [PATCH v2 03/16] ACPI: glue: Introduce acpi_find_child_by_adr() Rafael J. Wysocki
2022-06-13 18:11 ` [PATCH v2 04/16] thunderbolt: ACPI: Replace tb_acpi_find_port() with acpi_find_child_by_adr() Rafael J. Wysocki
2022-06-13 18:55 ` Andy Shevchenko
2022-06-14 6:07 ` Mika Westerberg
2022-06-14 18:25 ` Rafael J. Wysocki
2022-06-15 6:27 ` Mika Westerberg
2022-06-15 19:52 ` Rafael J. Wysocki
2022-06-14 7:36 ` Heikki Krogerus
2022-06-13 18:15 ` [PATCH v2 06/16] ACPI: container: Use acpi_dev_for_each_child() Rafael J. Wysocki
2022-06-13 18:16 ` [PATCH v2 07/16] ACPI: property: Use acpi_dev_for_each_child() for child lookup Rafael J. Wysocki
2022-06-13 18:26 ` [PATCH v2 08/16] ACPI: bus: Export acpi_dev_for_each_child() to modules Rafael J. Wysocki
2022-06-13 18:26 ` [PATCH v2 09/16] ACPI: video: Use acpi_dev_for_each_child() Rafael J. Wysocki
2022-06-13 18:26 ` [PATCH v2 10/16] ACPI: bus: Introduce acpi_dev_for_each_child_reverse() Rafael J. Wysocki
2022-06-13 18:27 ` [PATCH v2 11/16] ACPI: scan: Walk ACPI device's children using driver core Rafael J. Wysocki
2022-06-13 18:30 ` [PATCH v2 12/16] platform/x86/thinkpad_acpi: Use acpi_dev_for_each_child() Rafael J. Wysocki
2022-06-13 18:54 ` Andy Shevchenko
2022-06-13 20:50 ` Hans de Goede
2022-06-13 18:31 ` [PATCH v2 13/16] mfd: core: " Rafael J. Wysocki
2022-06-15 22:39 ` Lee Jones
2022-06-16 17:31 ` Rafael J. Wysocki
2022-06-27 11:38 ` [GIT PULL] Immutable branch between MFD and ACPI due for the v5.20 merge window Lee Jones
2022-06-27 12:15 ` Rafael J. Wysocki
2022-06-13 18:35 ` [PATCH v2 14/16] soundwire: Use acpi_dev_for_each_child() Rafael J. Wysocki
2022-06-23 8:10 ` Vinod Koul
2022-06-23 12:29 ` Rafael J. Wysocki
2022-06-23 12:41 ` Vinod Koul
2022-06-23 13:26 ` Rafael J. Wysocki
2022-06-13 18:36 ` [PATCH v2 15/16] ACPI / MMC: PM: Unify fixing up device power Rafael J. Wysocki
2022-06-13 18:38 ` [PATCH v2 16/16] ACPI: bus: Drop unused list heads from struct acpi_device Rafael J. Wysocki
2022-06-13 18:39 ` [PATCH v2 05/16] USB: ACPI: Replace usb_acpi_find_port() with acpi_find_child_by_adr() Rafael J. Wysocki
2022-06-13 18:53 ` Andy Shevchenko
2022-06-14 7:37 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63d7f3ed-b5a9-c869-5d25-a33a1d4e63c8@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=sakari.ailus@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).