From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752405AbdLLPPF (ORCPT ); Tue, 12 Dec 2017 10:15:05 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:39146 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751274AbdLLPPB (ORCPT ); Tue, 12 Dec 2017 10:15:01 -0500 Subject: Re: [Xen-devel] [PATCH V3 2/2] Xen/PCIback: Implement PCI flr/slot/bus reset with 'reset' SysFS attribute To: Jan Beulich Cc: Juergen Gross , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, bhelgaas@google.com, xen-devel@lists.xenproject.org, boris.ostrovsky@Oracle.COM, roger.pau@citrix.com References: <20171207222145.9769-1-Govinda.Tatti@Oracle.COM> <20171207222145.9769-3-Govinda.Tatti@Oracle.COM> <5A2A6AB10200007800195D4F@prv-mh.provo.novell.com> <8a3bc517-1255-4547-d244-5c400e44cc77@Oracle.COM> <5A2FFD690200007800196DFB@prv-mh.provo.novell.com> From: Govinda Tatti Organization: Oracle Corporation Message-ID: <63e8c7c7-8c7d-3307-22bc-3c27f327b62a@Oracle.COM> Date: Tue, 12 Dec 2017 09:14:09 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <5A2FFD690200007800196DFB@prv-mh.provo.novell.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8742 signatures=668644 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1712120219 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/12/2017 9:01 AM, Jan Beulich wrote: >>>> On 12.12.17 at 15:48, wrote: >> Thanks Jan for your review comments. Please see below for my comments. > First of all - can you please do something about your reply style? > HTML mail should be avoided. You'll see that the (plain text) reply > as a result is rather hard to follow, too. Sorry about it. I had an issue with my Thunderbird setting. > >> --- a/Documentation/ABI/testing/sysfs-driver-pciback >> +++ b/Documentation/ABI/testing/sysfs-driver-pciback >> @@ -11,3 +11,18 @@ Description: >> #echo 00:19.0-E0:2:FF > /sys/bus/pci/drivers/pciback/quirks >> will allow the guest to read and write to the configuration >> register 0x0E. >> + >> +What: /sys/bus/pci/drivers/pciback/reset >> +Date: Dec 2017 >> +KernelVersion: 4.15 >> +Contact: xen-devel@lists.xenproject.org >> +Description: >> + An option to perform a flr/slot/bus reset when a PCI device >> + is owned by Xen PCI backend. Writing a string of DDDD:BB:DD.F >> SSSS:BB:DD.F (or else the D-s are ambiguous, the more that "domain" >> in Xen code is ambiguous anyway - I continue to be mislead by struct >> pcistub_device_id's domain field) Thanks for catching this issue. I will >> fix it. >> >> >> Also I assume the SSSS part is optional (default zero), which >> probably can and should be expressed in some way. SSSS can be 0 or >> non-zero, subject to system configuration. > The question isn't system configuration, but whether the field can > be omitted on input, with zero being assumed in such a case. That's > a common shorthand, considering that the vast majority of x86 > (and maybe other) systems aren't using segments other than zero Yes, it can be omitted if SSSS is zero.I will add this information to above documentation file. Cheers GOVINDA