From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FA97C433F5 for ; Mon, 1 Nov 2021 09:59:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3862960F58 for ; Mon, 1 Nov 2021 09:59:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233213AbhKAKCW (ORCPT ); Mon, 1 Nov 2021 06:02:22 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:45864 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232326AbhKAKBu (ORCPT ); Mon, 1 Nov 2021 06:01:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635760756; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hfsAd90+4jizRuGcBnuq4ot5/47tw4BZNKDc8svp9+g=; b=aDwbjOs+bTdkMLGDwSdmX681w6TYveKbDA5xh3P4SPy+CnPQ2OwP9rzJu+adZ0x93+PpG8 prLqI7ul+0BI3Sr+Ey32EKMVAt0Wb3DXBXwpL7YGTBhUohrNGDvvYpArek/czyoBfEQd51 DBdvu/tvaLNlmIhGrFDnhBMUPqKhpfs= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-508-Z-m5aKZlN8iU6Urypj9HGQ-1; Mon, 01 Nov 2021 05:59:15 -0400 X-MC-Unique: Z-m5aKZlN8iU6Urypj9HGQ-1 Received: by mail-ed1-f69.google.com with SMTP id x13-20020a05640226cd00b003dd4720703bso15068451edd.8 for ; Mon, 01 Nov 2021 02:59:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=hfsAd90+4jizRuGcBnuq4ot5/47tw4BZNKDc8svp9+g=; b=Vr+r8re5v4rTLihQsbszr/D0d2prxFOSJ5FNwleTA3UUKG9BZJYyiRvJ5S7APhID31 qoSnszjRhLOagt+Mte2SPSNSCJ/qg4dn7MVd5oSO2DDUG4CmHGB83TGl3RGJTwYxUegS u89KLZ/3R/sWSbMnQqJPqnMjRNUO15TeVAw1XAtj4VBoMi1FUq70woHjjGNm9LU2Q4Xo H3JTeOjgHQHMsD+0d9jDkYT32U2XDh6UaQUpIWEZfvOl/Ax7eGe5qS4krZmPm3nAI1Ff qTZLUcqnACj16JoFmAiEodn0ACLyAkgimDG2SVXpZnBt4qopnEna4KhjdKc0pu3I+QQn c/+w== X-Gm-Message-State: AOAM530VhTsOgrNT7h/B8diWOTIY1s+y8EbqSttmoi1zcN2QNllUgRlE f7+9iI2Y7KxqIHbrttR3zxCiWjvfiG75skY1Zt4G1qOtFJb/k0qX5hoRIvr6o71y1lRyjP9sdOS M+hjZC3knwN7d5hgIV1ypwHCe X-Received: by 2002:aa7:de83:: with SMTP id j3mr40456472edv.312.1635760754585; Mon, 01 Nov 2021 02:59:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJziGpk6WpH6FTsaUWwlnifY+tohOpCDtMhNBv1GE+RVBp3kKeqI+oP5WfFtBjUYpuANxJFQQg== X-Received: by 2002:aa7:de83:: with SMTP id j3mr40456447edv.312.1635760754419; Mon, 01 Nov 2021 02:59:14 -0700 (PDT) Received: from [10.40.1.223] ([81.30.35.201]) by smtp.gmail.com with ESMTPSA id b2sm6772338ejj.124.2021.11.01.02.59.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Nov 2021 02:59:14 -0700 (PDT) Message-ID: <63ee77e1-dac9-ee09-6e11-4d8a091193f1@redhat.com> Date: Mon, 1 Nov 2021 10:59:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH 6/6] platform/x86: isthp_eclite: only load for matching devices Content-Language: en-US To: =?UTF-8?Q?Thomas_Wei=c3=9fschuh?= , linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Srinivas Pandruvada , K@troy.t-8ch.de, Naduvalath@troy.t-8ch.de, Sumesh , Jiri Kosina , Benjamin Tissoires , Mark Gross , platform-driver-x86@vger.kernel.org References: <20211029152901.297939-1-linux@weissschuh.net> <20211029152901.297939-2-linux@weissschuh.net> <20211029152901.297939-3-linux@weissschuh.net> <20211029152901.297939-4-linux@weissschuh.net> <20211029152901.297939-5-linux@weissschuh.net> <20211029152901.297939-6-linux@weissschuh.net> <20211029152901.297939-7-linux@weissschuh.net> From: Hans de Goede In-Reply-To: <20211029152901.297939-7-linux@weissschuh.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 10/29/21 17:29, Thomas Weißschuh wrote: > Previously it was loaded for all ISHTP devices. > > Signed-off-by: Thomas Weißschuh Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > > --- > > Cc: Srinivas Pandruvada > Cc: K Naduvalath, Sumesh > Cc: Jiri Kosina > Cc: Benjamin Tissoires > Cc: Hans de Goede > Cc: Mark Gross > Cc: linux-input@vger.kernel.org > Cc: platform-driver-x86@vger.kernel.org > --- > drivers/platform/x86/intel/ishtp_eclite.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/intel/ishtp_eclite.c b/drivers/platform/x86/intel/ishtp_eclite.c > index 12fc98a48657..b9fb8f28fd63 100644 > --- a/drivers/platform/x86/intel/ishtp_eclite.c > +++ b/drivers/platform/x86/intel/ishtp_eclite.c > @@ -681,6 +681,12 @@ static struct ishtp_cl_driver ecl_ishtp_cl_driver = { > .driver.pm = &ecl_ishtp_pm_ops, > }; > > +static const struct ishtp_device_id ecl_ishtp_id_table[] = { > + { ecl_ishtp_guid }, > + { } > +}; > +MODULE_DEVICE_TABLE(ishtp, ecl_ishtp_id_table); > + > static int __init ecl_ishtp_init(void) > { > return ishtp_cl_driver_register(&ecl_ishtp_cl_driver, THIS_MODULE); > @@ -698,4 +704,3 @@ MODULE_DESCRIPTION("ISH ISHTP eclite client opregion driver"); > MODULE_AUTHOR("K Naduvalath, Sumesh "); > > MODULE_LICENSE("GPL v2"); > -MODULE_ALIAS("ishtp:*"); >