From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29C61C43387 for ; Thu, 10 Jan 2019 05:50:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EB256206B7 for ; Thu, 10 Jan 2019 05:50:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="NEzs4/8f" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727214AbfAJFul (ORCPT ); Thu, 10 Jan 2019 00:50:41 -0500 Received: from lelv0143.ext.ti.com ([198.47.23.248]:39718 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725915AbfAJFuk (ORCPT ); Thu, 10 Jan 2019 00:50:40 -0500 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x0A5oHWK069173; Wed, 9 Jan 2019 23:50:17 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1547099417; bh=5AM9w8DKHn7sr8xi/A/jL8BaWMoPviU7ebwpWRMWGgE=; h=Subject:From:To:CC:References:Date:In-Reply-To; b=NEzs4/8fODQnCkrzO5bFI39UmLB83+bZSydworOxqBGufzlCTm1BPz/pHfsBrhA09 nM4MdH9LdYebCdOHErMfbEMmKCNkS7NY3NRTZtSMHURPWBopRe23v/cNKDmfUI+xO2 inbHgKr+ycYVF0IVPtzv6YEhNMbd9YHtX5ePYMB4= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x0A5oH5X034080 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 9 Jan 2019 23:50:17 -0600 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Wed, 9 Jan 2019 23:50:16 -0600 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Wed, 9 Jan 2019 23:50:16 -0600 Received: from [172.24.191.45] (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id x0A5oA1s007190; Wed, 9 Jan 2019 23:50:11 -0600 Subject: Re: Regression in v4.20 with net phy soft reset changes From: Keerthy To: Tony Lindgren , Heiner Kallweit , Sekhar Nori CC: Florian Fainelli , "David S. Miller" , Andrew Lunn , Bartosz Golaszewski , Chris Healy , Clemens Gruber , Ivan Khoronzhuk , Murali Karicheri , Rex Chang , Tero Kristo , WingMan Kwok , , , , References: <20190109190650.GT5544@atomide.com> <20190109213611.GU5544@atomide.com> <5bdce91b-cd56-75eb-c6d2-5542869b716e@ti.com> Message-ID: <63ffba1c-47c1-a32b-68d6-0c3c31b74dd8@ti.com> Date: Thu, 10 Jan 2019 11:20:10 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <5bdce91b-cd56-75eb-c6d2-5542869b716e@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 10 January 2019 10:36 AM, Keerthy wrote: > > > On Thursday 10 January 2019 03:06 AM, Tony Lindgren wrote: >> Hi, >> >> * Heiner Kallweit [190109 19:28]: >>> On 09.01.2019 20:06, Tony Lindgren wrote: >>>> Commit 6e2d85ec0559 ("net: phy: Stop with excessive soft reset") caused >>>> a regression where suspend resume cycle fails to bring up Ethernet on at >>>> least cpsw on am437x-sk-evm. >>>> >>> What kind of PHY and which PHY driver is used with this board? >>> I found one schematics of am437x where a KSZ9031RN PHY is used. >>> Is it the same on your board? >> >> Yes that's the phy. >> >>> As described in the commit message of this commit you would have >>> the option to implement the soft_reset callback in the PHY driver. >>> Can you try to add .soft_reset = genphy_soft_reset to the >>> KSZ9031 driver config in drivers/net/phy/micrel.c and check whether >>> it fixes the issue? >> >> Yes that seems to work based on a quick test of five suspend >> resume cycles. > Removing Grygorii as the e-mail no longer exists To add to Tony's observations. I ran a 100 time suspend/resume adding the soft_reset hook to the phy_driver structs in drivers/net/phy/micrel.c and suspend/resume (DS0) works nicely. > >> >> I wonder what all hardware this issue affects though? >> >> It's probably best that the network folks check what all >> hardare needs patching. >> >> For TI hardware, Sekhar and TI network folks, can you guys >> please check the various TI SoCs for multiple suspend resume >> cycles with v5.0-rc1 and patch accordingly? See also below >> for something else to check, 10 seconds to resume a phy >> seems very long to me :) >> >>>> Keerthy noticed this may not happen on the first resume, but usually >>>> happens after few suspend resume cycles. The most working suspend resume >>>> cycles I've seen with the commit above is three. >> ... >>>> Note that unrelated to the commit above, there may be other issues too >>>> as the cpsw phy LED seems to come on only after about five seconds with >>>> about total of 10 seconds before the Ethernet is up again. >> >> Regards, >> >> Tony >>