linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Achatz <erazor_de@users.sourceforge.net>
To: jkosina@suse.cz, gregkh@suse.de
Cc: erazor_de@users.sourceforge.net, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Aw: Re: [PATCH 0/3] HID: roccat: finishing usage of sysfs_create_bin_group()
Date: Tue, 16 Nov 2010 08:03:40 +0100 (CET)	[thread overview]
Message-ID: <640538250.3216351289891020338.JavaMail.ngmail@webmail08.arcor-online.net> (raw)
In-Reply-To: <alpine.LNX.2.00.1011152330540.7420@pobox.suse.cz>

> On Mon, 15 Nov 2010, Greg KH wrote:
> 
> > > These patches are against the newest roccat file versions (after
> > > applying everything I released the last days).
> > > They fix some inattentive (though not critical) failures from previous
> > > patches and change hid-roccat-koneplus and hid-roccat-pyra to use the
> > > new sysfs_create_bin_group()
> > > koneplus should be finished now (until I find errors)
> > 
> > Wait, they still don't resolve the main problem of this api is still
> > racy and I can't accept it.
> 
> Yeah, I have already pointed Stefan to
> 
> 	 http://lkml.org/lkml/2010/11/13/174
> 
> which he might have missed.

Hello again,

I don't see why these patches can't be applied. The bin attribute group functions standing for themself seem to be useful. The kone driver is already in the stable kernel and has less code with these patches. Though this does not change its functionality its a code cleanup. Thats also true for pyra and koneplus. So for me these are clear improvements until I make progress in the race problem. I will do it, but being a newbe I don't know where to start (feel free to point me to something), so it might take quite some time and sure needs some questions asked.

Have a nice day
Stefan

  parent reply	other threads:[~2010-11-16  7:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-15 20:32 [PATCH 0/3] HID: roccat: finishing usage of sysfs_create_bin_group() Stefan Achatz
2010-11-15 22:08 ` Greg KH
2010-11-15 22:31   ` Jiri Kosina
2010-11-16  7:03   ` Stefan Achatz [this message]
2010-11-16 11:01     ` Aw: " Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=640538250.3216351289891020338.JavaMail.ngmail@webmail08.arcor-online.net \
    --to=erazor_de@users.sourceforge.net \
    --cc=gregkh@suse.de \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).