From: "yebin (H)" <yebin10@huawei.com>
To: Benjamin Block <bblock@linux.ibm.com>, Ye Bin <yebin@huaweicloud.com>
Cc: <jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: fix hung_task when change host from recovery to running via sysfs
Date: Wed, 22 Mar 2023 09:24:32 +0800 [thread overview]
Message-ID: <641A58D0.1020205@huawei.com> (raw)
In-Reply-To: <20230321142237.GC311313@t480-pf1aa2c2.fritz.box>
On 2023/3/21 22:22, Benjamin Block wrote:
> On Tue, Mar 21, 2023 at 04:42:04PM +0800, Ye Bin wrote:
>> From: Ye Bin <yebin10@huawei.com>
>>
>> When do follow test:
>> Step1: echo "recovery" > /sys/class/scsi_host/host0/state
> Hmm, that make me wonder, what potential use-case this is for? Just
> testing?
Thank you for your reply.
Actually, I'm looking for a way to temporarily stop sending IO to the
driver.
Setting the state of the host to recovery can do this, but I changed the
state to
running and found that the process could not be woken up.
I don't know what the purpose of designing this sysfs interface was. But
this
modification can solve the effect I want to achieve.
> For SDEVs we explicitly filter what states can be set from user-space.
> Only `SDEV_RUNNING` and `SDEV_OFFLINE` can be set in
> `store_state_field()`.
> There is probably quite a few other bad things you can do with this
> interface by using any of the other states used for device destruction
> or EH, and then trigger I/O or said destruction/EH otherwise.
> Not sure handling this one special case of `SHOST_RECOVERY` is quite
> enough.
>
>
>> diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
>> index ee28f73af4d4..ae6b1476b869 100644
>> --- a/drivers/scsi/scsi_sysfs.c
>> +++ b/drivers/scsi/scsi_sysfs.c
>> @@ -216,6 +216,9 @@ store_shost_state(struct device *dev, struct device_attribute *attr,
>>
>> if (scsi_host_set_state(shost, state))
>> return -EINVAL;
>> + else
>> + wake_up(&shost->host_wait);
>> +
>> return count;
>> }
>>
>> --
>> 2.31.1
>>
next prev parent reply other threads:[~2023-03-22 1:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 8:42 [PATCH] scsi: fix hung_task when change host from recovery to running via sysfs Ye Bin
2023-03-21 14:22 ` Benjamin Block
2023-03-22 1:24 ` yebin (H) [this message]
2023-03-23 10:21 ` Benjamin Block
2023-03-23 15:57 ` Mike Christie
2023-03-23 16:12 ` Mike Christie
2023-03-24 1:41 ` yebin (H)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=641A58D0.1020205@huawei.com \
--to=yebin10@huawei.com \
--cc=bblock@linux.ibm.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yebin@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).