From: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Frank Rowand <frowand.list@gmail.com>
Cc: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>,
robh+dt@kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
nfont@linux.vnet.ibm.com, mpe@ellerman.id.au, mingo@redhat.com
Subject: Re: [PATCH] of: introduce event tracepoints for dynamic device_node lifecyle
Date: Wed, 19 Apr 2017 11:45:07 -0700 [thread overview]
Message-ID: <641aa8ee-9b54-716a-77a1-076cafb95e3a@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170418224953.685943a3@grimm.local.home>
On 04/18/2017 07:49 PM, Steven Rostedt wrote:
> On Tue, 18 Apr 2017 18:42:32 -0700
> Frank Rowand <frowand.list@gmail.com> wrote:
>
>> And of course the other issue with using tracepoints is the extra space
>> required to hold the tracepoint info. With the pr_debug() approach, the
>> space usage can be easily removed for a production kernel via a config
>> option.
>
> Now if you are saying you want to be able to enable debugging without
> the tracing infrastructure I would agree. As the tracing infrastructure
> is large. But I'm working on shrinking it more.
The primary consumers of OF_DYNAMIC seem to be pseries and powernv where
we are generally going to see the trace infrastructure enabled by
default in production.
-Tyrel
>
>>
>> Tracepoints are wonderful technology, but not always the proper tool to
>> use for debug info.
>
> But if you are going to have tracing enabled regardless, adding a few
> more tracepoints isn't going to make the difference.
>
> -- Steve
>
>>
>>> If Rob wants to convert printk() style data to trace data (and I can't
>>> convince him otherwise) then I will have further comments on this specific
>>> patch.
>>>
next prev parent reply other threads:[~2017-04-19 18:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 0:32 [PATCH] of: introduce event tracepoints for dynamic device_node lifecyle Tyrel Datwyler
2017-04-18 0:35 ` Tyrel Datwyler
2017-04-18 16:46 ` Rob Herring
2017-04-19 2:30 ` Oliver O'Halloran
2017-04-19 10:13 ` Michael Ellerman
2017-04-19 21:13 ` Tyrel Datwyler
2017-04-19 0:07 ` Frank Rowand
2017-04-19 1:31 ` Michael Ellerman
2017-04-19 2:31 ` Frank Rowand
2017-04-19 18:33 ` Tyrel Datwyler
2017-04-19 23:27 ` Tyrel Datwyler
2017-04-20 2:33 ` Steven Rostedt
2017-04-20 4:47 ` Frank Rowand
2017-04-20 5:24 ` Tyrel Datwyler
2017-04-20 13:37 ` Steven Rostedt
2017-04-20 4:43 ` Frank Rowand
2017-04-20 5:13 ` Frank Rowand
2017-04-20 16:51 ` Tyrel Datwyler
2017-04-20 19:34 ` Frank Rowand
2017-04-21 1:57 ` Michael Ellerman
2017-04-19 1:42 ` Frank Rowand
2017-04-19 2:49 ` Steven Rostedt
2017-04-19 18:45 ` Tyrel Datwyler [this message]
2017-04-20 2:37 ` Frank Rowand
2017-04-20 10:44 ` Frank Rowand
2017-04-19 2:46 ` Steven Rostedt
2017-04-19 3:12 ` Frank Rowand
2017-04-19 17:44 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=641aa8ee-9b54-716a-77a1-076cafb95e3a@linux.vnet.ibm.com \
--to=tyreld@linux.vnet.ibm.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=nfont@linux.vnet.ibm.com \
--cc=robh+dt@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).