From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754825AbcLaUYK (ORCPT ); Sat, 31 Dec 2016 15:24:10 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:64597 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750717AbcLaUYJ (ORCPT ); Sat, 31 Dec 2016 15:24:09 -0500 From: Arnd Bergmann To: Florian Fainelli Cc: Greentime Hu , netdev@vger.kernel.org, devicetree@vger.kernel.org, andrew@lunn.ch, linux-kernel@vger.kernel.org, jiri@resnulli.us Subject: Re: [PATCH v3] net: ethernet: faraday: To support device tree usage. Date: Sat, 31 Dec 2016 21:23:58 +0100 Message-ID: <6434425.l4ZxB6kK6L@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <351d1ae7-ca51-7962-0e52-38cdc69bcebd@gmail.com> References: <1483083470-15779-1-git-send-email-green.hu@gmail.com> <351d1ae7-ca51-7962-0e52-38cdc69bcebd@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:jmiH+uyX419/3uWXO8X/2Iw6EgXOnIojpY4jKuQFx8eM/ioDC1h +1kISNvjY+UN+j1UoEawD6iz8Xkw1TKJK6xNsEIuwq9uDdx/IiCrBygqEwwz7cXIiJeh4RD M1lcdFk9mox3/NteaZF6djlKwZjhhkg56Fdl5OuPFCdOpL9bceTiETvzTD4lXjJlVb/gYSC LAV6xW0OiZrvK116PORHQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:mayqHt2mkh8=:quJJmPCo4BcYHvqh9kDoPY yeqlBuFhyAoPLZP9u7QVlNeK83d6y21dy3knM8FvDt06SMNBUleZXXOgLcQKdrz9cdgIhUtLV Dw0krEAqtRgbfawkuXFUEYjyeVyg4SbBQVVVjw5OXZr6wsDRDujYsIXq7TID4+5aPZTS5qmWa PAl7+dQ3ZqxZeMfTkovG08Bk/3gIEurJ7Kq3gaIVRu+AeNns0m+0SA0jVEHOtnSaAFusYES49 KsDA36nHCTayxZOtY/OkDsd5kZswJ28nd6/sytsyxNQRFWs21MhPty/4OZih39H7coCEHRYYv 7yPCWh2NhpJCZ0D7SFc7Agnkalc2ZTO7Vu9LuvvmtLbrZscEj/M48a+ZKXhkQ5mKQwd0eJObF A9nSiy3SKz1qXVW3kxuk1zModGfx6bd0BqDdBHfoEoqwVJtebc/1ySU2FeP0Nw5VfvKqjPBio 6ajCiJzdbqarW/4L9ecxo7RVBm+S3zn0BtIHwIAos92+RYFYmojwy348rOzC/8E6nRoLmv+Km AqxBhROD1Ve10tdQDcWcBwYl/LQWQv+r1s5D2qbvO2wXcHIeo7wuJvhmjwHkZbj54uCy2aAWF aD+0yzj6rxJqzrgBZz8cXq8BjwZduFeEcSV5anrYpPx5TY/lI/B5nD6l95a0S/6sUVT0+10Gd TktZIN4rct8v8gSQ+/MbcnjMhsd2iaTce22SN08+Pcj5t8dZD3N+jy2UjzACvVNdNkwIYopiP A+PVhlZbQeCwF5/6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, December 31, 2016 10:48:39 AM CET Florian Fainelli wrote: > > On 12/29/2016 11:37 PM, Greentime Hu wrote: > > Signed-off-by: Greentime Hu > > This is not enough, you need to add a Device Tree binding document under > Documentation/devicetree/bindings/net/ which documents this compatible > string, as well as additional properties that may be required to > describe this hardware block. We already have Documentation/devicetree/bindings/net/moxa,moxart-mac.txt for the same hardware (though used by a different driver). I'd suggest renaming that one to a more generic file name and adding the new compatible string there. Aside from that, every patch should also have a changelog comment. Arnd