linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Guo Ren <guoren@kernel.org>, Guenter Roeck <linux@roeck-us.net>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Christoph Hellwig <hch@lst.de>,
	linux-arch <linux-arch@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-riscv <linux-riscv@lists.infradead.org>,
	linux-csky@vger.kernel.org,
	linux-s390 <linux-s390@vger.kernel.org>,
	sparclinux <sparclinux@vger.kernel.org>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	Parisc List <linux-parisc@vger.kernel.org>,
	"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	the arch/x86 maintainers <x86@kernel.org>,
	Guo Ren <guoren@linux.alibaba.com>
Subject: Re: [PATCH V9 20/20] riscv: compat: Add COMPAT Kbuild skeletal support
Date: Wed, 25 May 2022 12:57:30 +0200	[thread overview]
Message-ID: <6435704.4vTCxPXJkl@diego> (raw)
In-Reply-To: <20220524220646.GA3990738@roeck-us.net>

Am Mittwoch, 25. Mai 2022, 00:06:46 CEST schrieb Guenter Roeck:
> On Wed, May 25, 2022 at 01:46:38AM +0800, Guo Ren wrote:
> [ ... ]
> 
> > > The problem is come from "__dls3's vdso decode part in musl's
> > > ldso/dynlink.c". The ehdr->e_phnum & ehdr->e_phentsize are wrong.
> > >
> > > I think the root cause is from musl's implementation with the wrong
> > > elf parser. I would fix that soon.
> > Not elf parser, it's "aux vector just past environ[]". I think I could
> > solve this, but anyone who could help dig in is welcome.
> > 
> 
> I am not sure I understand what you are saying here. Point is that my
> root file system, generated with musl a year or so ago, crashes with
> your patch set applied. That is a regression, even if there is a bug
> in musl.

Also as I said in the other part of the thread, the rootfs seems innocent,
as my completely-standard Debian riscv64 rootfs is also affected.

The merged version seems to be v12 [0] - not sure how we this discussion
ended up in v9, but I just tested this revision in two variants:

- v5.17 + this v9 -> works nicely
- v5.18-rc6 + this v9 (rebased onto it) -> breaks the boot
  The only rebase-conflict was with the introduction of restartable
  sequences and removal of the tracehook include, but turning CONFIG_RSEQ
  off doesn't seem to affect the breakage.

So it looks like something changed between 5.17 and 5.18 that causes the issue.


Heiko


[0] https://lore.kernel.org/all/20220405071314.3225832-1-guoren@kernel.org/




  reply	other threads:[~2022-05-25 10:57 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-22 14:39 [PATCH V9 00/20] riscv: compat: Add COMPAT Kbuild skeletal support guoren
2022-03-22 14:39 ` [PATCH V9 01/20] uapi: simplify __ARCH_FLOCK{,64}_PAD a little guoren
2022-03-22 14:39 ` [PATCH V9 02/20] uapi: always define F_GETLK64/F_SETLK64/F_SETLKW64 in fcntl.h guoren
2022-03-22 14:39 ` [PATCH V9 03/20] compat: consolidate the compat_flock{,64} definition guoren
2022-03-22 14:39 ` [PATCH V9 04/20] kconfig: Add SYSVIPC_COMPAT for all architectures guoren
2022-03-22 14:39 ` [PATCH V9 05/20] fs: stat: compat: Add __ARCH_WANT_COMPAT_STAT guoren
2022-03-22 14:39 ` [PATCH V9 06/20] asm-generic: compat: Cleanup duplicate definitions guoren
2022-03-22 14:39 ` [PATCH V9 07/20] syscalls: compat: Fix the missing part for __SYSCALL_COMPAT guoren
2022-03-22 14:39 ` [PATCH V9 08/20] riscv: Fixup difference with defconfig guoren
2022-03-22 14:39 ` [PATCH V9 09/20] riscv: compat: Add basic compat data type implementation guoren
2022-03-22 14:39 ` [PATCH V9 10/20] riscv: compat: Re-implement TASK_SIZE for COMPAT_32BIT guoren
2022-03-22 14:39 ` [PATCH V9 11/20] riscv: compat: syscall: Add compat_sys_call_table implementation guoren
2022-03-23 13:40   ` Guo Ren
2022-03-22 14:39 ` [PATCH V9 12/20] riscv: compat: syscall: Add entry.S implementation guoren
2022-03-22 14:39 ` [PATCH V9 13/20] riscv: compat: process: Add UXL_32 support in start_thread guoren
2022-03-22 14:39 ` [PATCH V9 14/20] riscv: compat: Add elf.h implementation guoren
2022-03-22 14:39 ` [PATCH V9 15/20] riscv: compat: Add hw capability check for elf guoren
2022-03-22 14:39 ` [PATCH V9 16/20] riscv: compat: vdso: Add COMPAT_VDSO base code implementation guoren
2022-03-22 14:40 ` [PATCH V9 17/20] riscv: compat: vdso: Add setup additional pages implementation guoren
2022-03-22 14:40 ` [PATCH V9 18/20] riscv: compat: signal: Add rt_frame implementation guoren
2022-03-22 14:40 ` [PATCH V9 19/20] riscv: compat: ptrace: Add compat_arch_ptrace implement guoren
2022-03-22 14:40 ` [PATCH V9 20/20] riscv: compat: Add COMPAT Kbuild skeletal support guoren
2022-05-23  5:45   ` Guenter Roeck
2022-05-23 15:18     ` Guo Ren
2022-05-23 16:18       ` Guenter Roeck
2022-05-23 22:40         ` Heiko Stübner
2022-05-23 23:00           ` Guenter Roeck
2022-05-24 14:41             ` Heiko Stübner
2022-05-24 17:42     ` Guo Ren
2022-05-24 17:46       ` Guo Ren
2022-05-24 22:06         ` Guenter Roeck
2022-05-25 10:57           ` Heiko Stübner [this message]
2022-05-25 11:10             ` Heiko Stübner
2022-05-25 16:08               ` Guo Ren
2022-05-25 19:37                 ` Heiko Stübner
2022-05-26  0:39                   ` Guo Ren
2022-03-22 21:00 ` [PATCH V9 00/20] " Palmer Dabbelt
2022-04-02 12:53   ` Guo Ren
2022-04-02 13:16     ` Guo Ren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6435704.4vTCxPXJkl@diego \
    --to=heiko@sntech.de \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=guoren@kernel.org \
    --cc=guoren@linux.alibaba.com \
    --cc=hch@lst.de \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-csky@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=palmer@dabbelt.com \
    --cc=sparclinux@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).