From: James Smart <james.smart@broadcom.com>
To: Saurav Girepunje <saurav.girepunje@gmail.com>,
dick.kennedy@broadcom.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: saurav.girepunje@hotmail.com, Dick Kennedy <dick.kennedy@broadcom.com>
Subject: Re: [PATCH] scsi: lpfc: lpfc_attr.c: Fix Use plain integer as NULL pointer
Date: Thu, 24 Oct 2019 11:14:37 -0700 [thread overview]
Message-ID: <643cce28-6b64-0bfc-254a-52cc3efa0830@broadcom.com> (raw)
In-Reply-To: <20191024025726.GA31421@saurav>
On 10/23/2019 7:57 PM, Saurav Girepunje wrote:
> Replace assignment of 0 to pointer with NULL assignment.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
> drivers/scsi/lpfc/lpfc_attr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
> index ea62322ffe2b..f7df95963a63 100644
> --- a/drivers/scsi/lpfc/lpfc_attr.c
> +++ b/drivers/scsi/lpfc/lpfc_attr.c
> @@ -1641,7 +1641,7 @@ lpfc_set_trunking(struct lpfc_hba *phba, char *buff_out)
> {
> LPFC_MBOXQ_t *mbox = NULL;
> unsigned long val = 0;
> - char *pval = 0;
> + char *pval = NULL;
> int rc = 0;
>
> if (!strncmp("enable", buff_out,
thanks
Reviewed-by: James Smart <james.smart@broadcom.com>
-- james
next parent reply other threads:[~2019-10-24 18:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191024025726.GA31421@saurav>
2019-10-24 18:14 ` James Smart [this message]
2019-10-25 1:11 ` [PATCH] scsi: lpfc: lpfc_attr.c: Fix Use plain integer as NULL pointer Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=643cce28-6b64-0bfc-254a-52cc3efa0830@broadcom.com \
--to=james.smart@broadcom.com \
--cc=dick.kennedy@broadcom.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=saurav.girepunje@gmail.com \
--cc=saurav.girepunje@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).