From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754068AbdAZRnI (ORCPT <rfc822;w@1wt.eu>);
        Thu, 26 Jan 2017 12:43:08 -0500
Received: from fllnx210.ext.ti.com ([198.47.19.17]:52657 "EHLO
        fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753821AbdAZRnD (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 26 Jan 2017 12:43:03 -0500
Subject: Re: [PATCH v6 05/14] ARM: davinci: da850: add con_id for the SATA
 clock
To: Grygorii Strashko <grygorii.strashko@ti.com>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        Kevin Hilman <khilman@kernel.org>,
        Patrick Titiano <ptitiano@baylibre.com>,
        Michael Turquette <mturquette@baylibre.com>, Tejun Heo <tj@kernel.org>,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Russell King <linux@armlinux.org.uk>,
        David Lechner <david@lechnology.com>
References: <1485190856-4711-1-git-send-email-bgolaszewski@baylibre.com>
 <1485190856-4711-6-git-send-email-bgolaszewski@baylibre.com>
 <93a3bbb3-2d9f-bc38-c7b4-5eb3325d985d@ti.com>
CC: <linux-ide@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>
From: Sekhar Nori <nsekhar@ti.com>
Message-ID: <645778dd-6727-abd0-3dd9-a7e0d5aa4983@ti.com>
Date: Thu, 26 Jan 2017 23:10:49 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <93a3bbb3-2d9f-bc38-c7b4-5eb3325d985d@ti.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday 26 January 2017 10:26 PM, Grygorii Strashko wrote:
> 
> 
> On 01/23/2017 11:00 AM, Bartosz Golaszewski wrote:
>> The ahci-da850 SATA driver is now capable of retrieving clocks by
>> con_id. Add the connection id for the sysclk2-derived SATA clock.
>>
>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>> ---
>>  arch/arm/mach-davinci/da850.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-davinci/da850.c b/arch/arm/mach-davinci/da850.c
>> index 1d873d1..dbf1daa 100644
>> --- a/arch/arm/mach-davinci/da850.c
>> +++ b/arch/arm/mach-davinci/da850.c
>> @@ -571,7 +571,7 @@ static struct clk_lookup da850_clks[] = {
>>  	CLK("spi_davinci.0",	NULL,		&spi0_clk),
>>  	CLK("spi_davinci.1",	NULL,		&spi1_clk),
>>  	CLK("vpif",		NULL,		&vpif_clk),
>> -	CLK("ahci_da850",		NULL,		&sata_clk),
>> +	CLK("ahci_da850",	"sata",		&sata_clk),
> 
> I'm worry a bit - wouldn't this cause future problems with PM runtime
>  (if it will be the case)?
> 
> If this is functional clock - shouldn't it be "fck" to 
> follow PM domain con_id list for davinci?  (arch/arm/mach-davinci/pm_domain.c) 

I agree with Grygorii. Calling this clock "fck" will make it easy to
convert the DA850 AHCI driver to use pm_runtime at a future date (no
mach-davinci changes should be needed).

Sorry about not spotting this earlier.

Thanks,
Sekhar