From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965765AbcIHJ1g (ORCPT ); Thu, 8 Sep 2016 05:27:36 -0400 Received: from lb1-smtp-cloud2.xs4all.net ([194.109.24.21]:37409 "EHLO lb1-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965243AbcIHJ1d (ORCPT ); Thu, 8 Sep 2016 05:27:33 -0400 Subject: Re: [PATCH 0/4] Add V4L2_PIX_FMT_MT21C format for MT8173 codec driver To: Tiffany Lin , Andrew-CT Chen References: <1473231403-14900-1-git-send-email-tiffany.lin@mediatek.com> <1473325879.26612.2.camel@mtksdaap41> Cc: Hans Verkuil , Laurent Pinchart , Mauro Carvalho Chehab , Matthias Brugger , Daniel Kurtz , Pawel Osciak , Eddie Huang , Yingjoe Chen , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org From: Hans Verkuil Message-ID: <64676168-8c5f-3720-820a-17e7bdbcc735@xs4all.nl> Date: Thu, 8 Sep 2016 11:27:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1473325879.26612.2.camel@mtksdaap41> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/08/16 11:11, Tiffany Lin wrote: > Hi Hans, > > On Thu, 2016-09-08 at 09:21 +0200, Hans Verkuil wrote: >> Hi Tiffany, >> >> On 09/07/2016 08:56 AM, Tiffany Lin wrote: >>> This patch series add Mediatek compressed block format V4L2_PIX_FMT_MT21C, the >>> decoder driver will decoded bitstream to V4L2_PIX_FMT_MT21C format. >>> >>> User space applications could use MT8173 MDP driver to convert V4L2_PIX_FMT_MT21C to >>> V4L2_PIX_FMT_NV12M, V4L2_PIX_FMT_YUV420M and V4L2_PIX_FMT_YVU420. >>> >>> MDP driver[1] is stand alone driver. >>> >>> Usage: >>> MT21C -> MT8173 MDP -> NV12M/YUV420M/YVU420 >>> NV12M/NV21M/YUV420M/YVU420M -> mt8173 Encoder -> H264/VP8 >>> H264/VP8/VP9 -> mtk8173 Decoder -> MT21C >>> >>> When encode with MT21 source, the pipeline will be: >>> MT21C -> MDP driver-> NV12M/NV21M/YUV420M/YVU420M -> Encoder -> H264/VP8 >>> >>> When playback, the pipeline will be: >>> H264/VP8/VP9 -> Decoder driver -> MT21C -> MDP Driver -> DRM >>> >>> [1]https://patchwork.kernel.org/patch/9305329/ >>> >>> Tiffany Lin (4): >>> v4l: add Mediatek compressed video block format >>> docs-rst: Add compressed video formats used on MT8173 codec driver >>> vcodec: mediatek: Add V4L2_PIX_FMT_MT21C support for v4l2 decoder >>> arm64: dts: mediatek: Add Video Decoder for MT8173 >>> >>> Documentation/media/uapi/v4l/pixfmt-reserved.rst | 6 +++ >>> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 44 ++++++++++++++++++++ >>> drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 7 +++- >>> drivers/media/v4l2-core/v4l2-ioctl.c | 1 + >>> include/uapi/linux/videodev2.h | 1 + >>> 5 files changed, 58 insertions(+), 1 deletion(-) >>> >> >> So basically the video decoder is useless without support for this format and >> without the MDP driver, right? >> > Yes. It also require new vpu firmware. > Andrew will help release new vpu firmware include encode/decode/mdp > capability. OK, then I'll park this until: - the MT21C patch series is OK - the MDP patch series is OK - the new firmware is released For the record: the decoder patch series is OK as far as I am concerned. It's in my mtkdec branch. Regards, Hans