From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Huang Shijie <sjhuang@iluvatar.ai>, <vkoul@kernel.org>
Cc: <dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<dave.jiang@intel.com>, <radhey.shyam.pandey@xilinx.com>,
<appana.durga.rao@xilinx.com>, <jmkrzyszt@gmail.com>,
<gomonovych@gmail.com>, <keescook@chromium.org>,
<horms+renesas@verge.net.au>, <geert+renesas@glider.be>,
<shawnguo@kernel.org>, <baoyou.xie@linaro.org>,
<michal.simek@xilinx.com>, <baohua@kernel.org>,
<ludovic.desroches@microchip.com>, <linus.walleij@linaro.org>,
<david.brown@linaro.org>
Subject: Re: [PATCH 07/46] dmaengine: omap-dma: use dmaenginem_async_device_register to simplify the code
Date: Fri, 3 Aug 2018 10:47:30 +0300 [thread overview]
Message-ID: <646b3c1a-cf42-43ba-1f20-6c1375c78517@ti.com> (raw)
In-Reply-To: <20180803072016.21544-8-sjhuang@iluvatar.ai>
On 2018-08-03 10:19, Huang Shijie wrote:
> Use dmaenginem_async_device_register to simplify the code:
> remove dma_async_device_unregister
>
> Signed-off-by: Huang Shijie <sjhuang@iluvatar.ai>
> ---
> drivers/dma/ti/omap-dma.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/dma/ti/omap-dma.c b/drivers/dma/ti/omap-dma.c
> index a4a931ddf6f6..085748c6eb67 100644
> --- a/drivers/dma/ti/omap-dma.c
> +++ b/drivers/dma/ti/omap-dma.c
> @@ -1566,7 +1566,7 @@ static int omap_dma_probe(struct platform_device *pdev)
> }
> }
>
> - rc = dma_async_device_register(&od->ddev);
> + rc = dmaenginem_async_device_register(&od->ddev);
Why it is dmaenginem_async_device_register() and not aligned other
resource managed functions (devm_* dmam_*), like
devm_dma_async_device_register()
and in dmaenginem_async_device_register() what is the 'm' in dmaenginem ?
DMAengine Managed?
> if (rc) {
> pr_warn("OMAP-DMA: failed to register slave DMA engine device: %d\n",
> rc);
> @@ -1584,7 +1584,6 @@ static int omap_dma_probe(struct platform_device *pdev)
> of_dma_simple_xlate, &omap_dma_info);
> if (rc) {
> pr_warn("OMAP-DMA: failed to register DMA controller\n");
> - dma_async_device_unregister(&od->ddev);
> omap_dma_free(od);
> }
> }
> @@ -1606,8 +1605,6 @@ static int omap_dma_remove(struct platform_device *pdev)
> irq = platform_get_irq(pdev, 1);
> devm_free_irq(&pdev->dev, irq, od);
>
> - dma_async_device_unregister(&od->ddev);
> -
I think this is a bad idea in general.
We need to unregister the dma-device before we clean up and free resources.
> if (!od->legacy) {
> /* Disable all interrupts */
> omap_dma_glbl_write(od, IRQENABLE_L0, 0);
>
I'm sorry to say, but it is a NACK from me.
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2018-08-03 7:47 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 7:19 [PATCH 00/46] Use dmaenginem_async_device_register to simplify code Huang Shijie
2018-08-03 7:19 ` [PATCH 01/46] dmaengine: zx_dma: use dmaenginem_async_device_register to simplify the code Huang Shijie
2018-08-03 7:19 ` [PATCH 02/46] dmaengine: zynqmp_dma: " Huang Shijie
2018-08-03 7:19 ` [PATCH 03/46] dmaengine: xilinx_dma: " Huang Shijie
2018-08-03 7:19 ` [PATCH 04/46] dmaengine: xgene-dma: " Huang Shijie
2018-08-03 7:19 ` [PATCH 05/46] dmaengine: txx9dmac: " Huang Shijie
2018-08-03 7:19 ` [PATCH 06/46] dmaengine: timb_dma: " Huang Shijie
2018-08-03 7:19 ` [PATCH 07/46] dmaengine: omap-dma: " Huang Shijie
2018-08-03 7:47 ` Peter Ujfalusi [this message]
2018-08-03 7:52 ` Huang Shijie
2018-08-09 2:36 ` Vinod
2018-08-03 7:19 ` [PATCH 08/46] dmaengine: edma: " Huang Shijie
2018-08-03 7:50 ` Peter Ujfalusi
2018-08-03 7:54 ` Huang Shijie
2018-08-03 7:19 ` [PATCH 09/46] dmaengine: cppi41: " Huang Shijie
2018-08-03 7:55 ` Peter Ujfalusi
2018-08-03 8:02 ` Huang Shijie
2018-08-06 3:28 ` Huang Shijie
2018-08-07 7:01 ` Peter Ujfalusi
2018-08-07 7:16 ` Huang Shijie
2018-08-08 7:16 ` Tony Lindgren
2018-08-03 7:19 ` [PATCH 10/46] dmaengine: tegra210-adma: use helper dmaenginem_async_device_register Huang Shijie
2018-08-03 7:19 ` [PATCH 11/46] dmaengine: tegra20-apb-dma: " Huang Shijie
2018-08-03 7:19 ` [PATCH 12/46] dmaengine: sun6i-dma: " Huang Shijie
2018-08-03 7:19 ` [PATCH 13/46] dmaengine: sun4i-dma: use dmaenginem_async_device_register to simplify the code Huang Shijie
2018-08-03 7:19 ` [PATCH 14/46] dmaengine: coh901318: " Huang Shijie
2018-08-03 7:19 ` [PATCH 15/46] dmaengine: s3c24xx-dma: " Huang Shijie
2018-08-03 7:19 ` [PATCH 16/46] dmaengine: ste_dma40: " Huang Shijie
2018-08-03 7:19 ` [PATCH 17/46] dmaengine: stm32-mdma: " Huang Shijie
2018-08-03 8:10 ` Pierre Yves MORDRET
2018-08-03 7:19 ` [PATCH 18/46] dmaengine: stm32-dma: " Huang Shijie
2018-08-03 7:19 ` [PATCH 19/46] dmaengine: sprd-dma: " Huang Shijie
2018-08-03 7:19 ` [PATCH 20/46] dmaengine: sirf-dma: " Huang Shijie
2018-08-03 7:19 ` [PATCH 21/46] dmaengine: bam_dma: " Huang Shijie
2018-08-03 7:19 ` [PATCH 22/46] dmaengine: sudmac: " Huang Shijie
2018-08-03 7:19 ` [PATCH 23/46] dmaengine: sa11x0-dma: " Huang Shijie
2018-08-03 7:19 ` [PATCH 24/46] dmaengine: nbpfaxi: " Huang Shijie
2018-08-03 7:19 ` [PATCH 25/46] dmaengine: mmp_tdma: " Huang Shijie
2018-08-03 7:19 ` [PATCH 26/46] dmaengine: shdmac: " Huang Shijie
2018-08-03 7:19 ` [PATCH 27/46] dmaengine: usb-dmac: " Huang Shijie
2018-08-03 7:19 ` [PATCH 28/46] dmaengine: rcar-dmac: " Huang Shijie
2018-08-03 7:19 ` [PATCH 29/46] dmaengine: hidma: " Huang Shijie
2018-08-03 7:20 ` [PATCH 30/46] dmaengine: pxa_dma: " Huang Shijie
2018-08-03 7:20 ` [PATCH 31/46] dmaengine: moxart-dma: " Huang Shijie
2018-08-03 7:20 ` [PATCH 32/46] dmaengine: pl330: " Huang Shijie
2018-08-03 7:20 ` [PATCH 33/46] dmaengine: pch_dma: " Huang Shijie
2018-08-03 7:20 ` [PATCH 34/46] dmaengine: mxs-dma: " Huang Shijie
2018-08-03 7:20 ` [PATCH 35/46] dmaengine: mtk-hsdma: " Huang Shijie
2018-08-03 7:20 ` [PATCH 36/46] dmaengine: k3dma: " Huang Shijie
2018-08-03 7:20 ` [PATCH 37/46] dmaengine: imx-sdma: " Huang Shijie
2018-08-03 7:20 ` [PATCH 38/46] dmaengine: imx-dma: " Huang Shijie
2018-08-03 7:20 ` [PATCH 39/46] dmaengine: img-mdc-dma: " Huang Shijie
2018-08-03 7:20 ` [PATCH 40/46] dmaengine: fsl-edma: " Huang Shijie
2018-08-03 7:20 ` [PATCH 41/46] dmaengine: at_hdmac: " Huang Shijie
2018-08-03 7:20 ` [PATCH 42/46] dmaengine: at_xdmac: " Huang Shijie
2018-08-03 7:20 ` [PATCH 43/46] dmaengine: dma-jz4780: " Huang Shijie
2018-08-03 7:20 ` [PATCH 44/46] dmaengine: dma-jz4740: " Huang Shijie
2018-08-03 7:20 ` [PATCH 45/46] dmaengine: dma-axi-dmac: " Huang Shijie
2018-08-03 7:20 ` [PATCH 46/46] dmaengine: add COMPILE_TEST for the drivers Huang Shijie
2018-08-03 7:51 ` [PATCH 00/46] Use dmaenginem_async_device_register to simplify code Lars-Peter Clausen
2018-08-03 7:59 ` Huang Shijie
2018-08-03 8:20 ` Peter Ujfalusi
2018-08-03 8:48 ` Huang Shijie
2018-08-05 1:03 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=646b3c1a-cf42-43ba-1f20-6c1375c78517@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=appana.durga.rao@xilinx.com \
--cc=baohua@kernel.org \
--cc=baoyou.xie@linaro.org \
--cc=dave.jiang@intel.com \
--cc=david.brown@linaro.org \
--cc=dmaengine@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=gomonovych@gmail.com \
--cc=horms+renesas@verge.net.au \
--cc=jmkrzyszt@gmail.com \
--cc=keescook@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=michal.simek@xilinx.com \
--cc=radhey.shyam.pandey@xilinx.com \
--cc=shawnguo@kernel.org \
--cc=sjhuang@iluvatar.ai \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).