From: Guenter Roeck <linux@roeck-us.net>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>,
robh+dt@kernel.org, jdelvare@suse.com
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: add binding documentation for adt7475
Date: Tue, 6 Nov 2018 20:24:19 -0800 [thread overview]
Message-ID: <64720b73-dddf-783c-a3a4-3f32a748bf5d@roeck-us.net> (raw)
In-Reply-To: <20181107040010.27436-2-chris.packham@alliedtelesis.co.nz>
On 11/6/18 8:00 PM, Chris Packham wrote:
> With the addition of the invert-pwm property the adt7475 needs its own
> binding documentation rather being captured under trivial-devices.txt.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
> .../devicetree/bindings/hwmon/adt7475.txt | 22 +++++++++++++++++++
> .../devicetree/bindings/trivial-devices.txt | 4 ----
> 2 files changed, 22 insertions(+), 4 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/hwmon/adt7475.txt
>
> diff --git a/Documentation/devicetree/bindings/hwmon/adt7475.txt b/Documentation/devicetree/bindings/hwmon/adt7475.txt
> new file mode 100644
> index 000000000000..79255439e157
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/adt7475.txt
> @@ -0,0 +1,22 @@
> +*ADT7475 hwmon sensor.
> +
> +Required properties:
> +- compatible: One of
> + "adi,adt7473"
> + "adi,adt7475"
> + "adi,adt7476"
> + "adi,adt7490"
> +
> +- reg: I2C address
> +
> +optional properties:
> +
> +- invert-pwm: This configures the PWM to use logic low for 100% duty cycle.
> +
> +Example:
> +
> +hwmon@2e {
> + compatible = ;
> + reg = <0x2e>;
> + invert-pwm;
If I understand correctly, the flag is set per pwm channel. A single global
property seems inappropriate.
Guenter
> +};
> diff --git a/Documentation/devicetree/bindings/trivial-devices.txt b/Documentation/devicetree/bindings/trivial-devices.txt
> index 69c934aec13b..4f29100d6bbf 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.txt
> +++ b/Documentation/devicetree/bindings/trivial-devices.txt
> @@ -14,10 +14,6 @@ ad,ad7414 SMBus/I2C Digital Temperature Sensor in 6-Pin SOT with SMBus Alert an
> ad,adm9240 ADM9240: Complete System Hardware Monitor for uProcessor-Based Systems
> adi,adt7461 +/-1C TDM Extended Temp Range I.C
> adt7461 +/-1C TDM Extended Temp Range I.C
> -adi,adt7473 +/-1C TDM Extended Temp Range I.C
> -adi,adt7475 +/-1C TDM Extended Temp Range I.C
> -adi,adt7476 +/-1C TDM Extended Temp Range I.C
> -adi,adt7490 +/-1C TDM Extended Temp Range I.C
> adi,adxl345 Three-Axis Digital Accelerometer
> adi,adxl346 Three-Axis Digital Accelerometer (backward-compatibility value "adi,adxl345" must be listed too)
> ams,iaq-core AMS iAQ-Core VOC Sensor
>
next prev parent reply other threads:[~2018-11-07 4:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 4:00 [PATCH 0/2] hwmon: (adt7475): inverted PWM output Chris Packham
2018-11-07 4:00 ` [PATCH 1/2] dt-bindings: hwmon: add binding documentation for adt7475 Chris Packham
2018-11-07 4:24 ` Guenter Roeck [this message]
2018-11-07 4:27 ` Chris Packham
2018-11-07 5:07 ` Guenter Roeck
2018-11-08 19:55 ` Chris Packham
2018-11-07 4:00 ` [PATCH 2/2] hwmon: (adt7475): add support for inverting the pwm output Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64720b73-dddf-783c-a3a4-3f32a748bf5d@roeck-us.net \
--to=linux@roeck-us.net \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).