From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753544AbdEOCao (ORCPT ); Sun, 14 May 2017 22:30:44 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:34491 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751518AbdEOCam (ORCPT ); Sun, 14 May 2017 22:30:42 -0400 Subject: Re: [PATCH v3 6/6] watchdog: ts4600: add driver for TS-4600 watchdog To: Shawn Guo References: <20170505193259.16517-1-sebastien.bourdelin@savoirfairelinux.com> <20170505193259.16517-7-sebastien.bourdelin@savoirfairelinux.com> <20170511072231.GD5833@dragon> <20170515020001.GI8471@dragon> Cc: Sebastien Bourdelin , robh@kernel.org, linux-watchdog@vger.kernel.org, mark@embeddedarm.com, devicetree@vger.kernel.org, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, kris@embeddedarm.com, kernel@savoirfairelinux.com, fabio.estevam@nxp.com, linux-arm-kernel@lists.infradead.org From: Guenter Roeck Message-ID: <647826a6-7b85-997f-d283-35458a789ccc@roeck-us.net> Date: Sun, 14 May 2017 19:30:38 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170515020001.GI8471@dragon> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/14/2017 07:00 PM, Shawn Guo wrote: > On Sun, May 14, 2017 at 07:39:33AM -0700, Guenter Roeck wrote: >> On 05/11/2017 12:22 AM, Shawn Guo wrote: >>> On Fri, May 05, 2017 at 03:32:59PM -0400, Sebastien Bourdelin wrote: >>>> This watchdog is instantiated in a FPGA and can only be access using a >>>> GPIOs bit-banged bus, called the NBUS by Technologic Systems. >>>> The watchdog is made of only one register, called the feed register. >>>> Writing to this register will re-arm the watchdog for a given time (and >>>> enable it if it was disable). It can be disabled by writing a special >>>> value into it. >>>> >>>> Signed-off-by: Sebastien Bourdelin >>>> --- >>>> Changes v2 -> v3: >>>> - rebase on master >>>> - remove the timeout table to simplify the logic (suggested by >>>> Guenter Roeck) >>>> - fix the set_timeout function (suggested by Guenter Roeck) >>>> - hardcode the max_hw_heartbeat_ms value based on the ts4600 max >>>> timeout value supported (suggested by Guenter Roeck) >>>> - remove the max_timeout usage and set a default timeout value >>>> (suggested by Guenter Roeck) >>>> - use the devm_watchdog_register_device function instead of >>>> watchdog_register_device (suggested by Guenter Roeck) >>>> >>>> Changes v1 -> v2: >>>> - rebase on master >>>> - retrieve the ts_nbus instantiated by the parent node (suggested by >>>> Linus Walleij) >>>> - rename the wdt by watchdog in the device tree and in the >>>> documentation (suggested by Rob Herring) >>>> - add a dependency to the TS_NBUS driver in the Kconfig (suggested by >>>> Guenter Roeck) >>>> - simplify the set_timeout function (suggested by Guenter Roeck) >>>> - use the max_hw_heartbeat_ms callback instead of the max_timeout >>>> callback (suggested by Guenter Roeck) >>>> --- >>>> .../devicetree/bindings/watchdog/ts4600-wdt.txt | 16 ++ >>>> arch/arm/boot/dts/imx28-ts4600-common.dtsi | 5 + >>> >>> The dts change shouldn't be mixed within driver patch. >>> >> >> Maybe, but Rob Acked the devicetree changes, so I don't see a reason >> for splitting it up now. > > What Rob Acked is devicetree bindings, and ARM dts changes should > normally go via arm-soc tree, unless there is a good reason they > shouldn't. > Ok, good point. Guenter