From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751436AbcFWO67 (ORCPT ); Thu, 23 Jun 2016 10:58:59 -0400 Received: from mx5-phx2.redhat.com ([209.132.183.37]:54140 "EHLO mx5-phx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750799AbcFWO66 (ORCPT ); Thu, 23 Jun 2016 10:58:58 -0400 Date: Thu, 23 Jun 2016 10:58:55 -0400 (EDT) From: Chunyu Hu Reply-To: Chunyu Hu To: Steven Rostedt Cc: linux-kernel@vger.kernel.org Message-ID: <648023723.4701653.1466693935773.JavaMail.zimbra@redhat.com> In-Reply-To: <20160623103920.36195c3a@gandalf.local.home> References: <1466506666-28804-1-git-send-email-chuhu@redhat.com> <20160622090814.0bd039e3@gandalf.local.home> <746408767.4672536.1466691631491.JavaMail.zimbra@redhat.com> <20160623103920.36195c3a@gandalf.local.home> Subject: Re: [PATCH] tracing: Fix oops caused by graph notrace filter MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.68.5.41] X-Mailer: Zimbra 8.0.6_GA_5922 (ZimbraWebClient - FF38 (Linux)/8.0.6_GA_5922) Thread-Topic: tracing: Fix oops caused by graph notrace filter Thread-Index: H8cWu/wG4s8K4yxNqRPlrpRUcHdm9A== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- Original Message ----- > From: "Steven Rostedt" > To: "Chunyu Hu" > Cc: linux-kernel@vger.kernel.org > Sent: Thursday, June 23, 2016 10:39:20 PM > Subject: Re: [PATCH] tracing: Fix oops caused by graph notrace filter > > On Thu, 23 Jun 2016 10:20:31 -0400 (EDT) > Chunyu Hu wrote: > > > I tried the patch, if just for resolving the oops issue, it's indeed > > enough. > > But if we care about just this filter, and compare this with the > > trace_graph_entry > > filter handling, I found that, the depth 0 item will be submitted to the > > ring buffer, not > > respecting the filter. I still use the same steps. It's possible to show > > schedule entry: > > Sure, I just wanted to make sure nothing got off, and made the quick > patch. > > Want to send an updated patch that goes this route? That is, make it > such that the latency tracers fully support the set_graph_notrace. Sure, if your time allowing me to send it tomorrow, If not, feel free to fix it as your way. > -- Steve > > -- Regards, Chunyu Hu