LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Sibi Sankar <sibis@codeaurora.org>
To: Evan Green <evgreen@google.com>
Cc: David Dai <daidavid1@codeaurora.org>,
	Georgi Djakov <georgi.djakov@linaro.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	sboyd@kernel.org, Lina Iyer <ilina@codeaurora.org>,
	Sean Sweeney <seansw@qti.qualcomm.com>,
	Alex Elder <elder@linaro.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	linux-pm@vger.kernel.org, linux-kernel-owner@vger.kernel.org
Subject: Re: [PATCH v2 6/6] arm64: dts: sdm845: Redefine interconnect provider DT nodes
Date: Sun, 09 Feb 2020 23:33:11 +0530
Message-ID: <649c804c30e90088e4f7aa44cee2753e@codeaurora.org> (raw)
In-Reply-To: <CAE=gft7qtfQjKK-MGgR_sK+Lsi2GmXgPkSsysD-DdUmFW4qMQw@mail.gmail.com>

On 2020-02-04 23:48, Evan Green wrote:
> On Thu, Jan 9, 2020 at 8:33 PM David Dai <daidavid1@codeaurora.org> 
> wrote:
>> 
>> Add the DT nodes for each of the Network-On-Chip interconnect
>> buses found on SDM845 based platform and redefine the rsc_hlos
>> child node as a bcm-voter device to better represent the hardware.
>> 
>> Signed-off-by: David Dai <daidavid1@codeaurora.org>
>> ---
>>  arch/arm64/boot/dts/qcom/sdm845.dtsi | 61 
>> ++++++++++++++++++++++++++++++++++--
>>  1 file changed, 58 insertions(+), 3 deletions(-)
>> 
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi 
>> b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> index ddb1f23..7c617a9 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> @@ -1364,6 +1364,55 @@
>>                         interrupts = <GIC_SPI 582 
>> IRQ_TYPE_LEVEL_HIGH>;
>>                 };
>> 
>> +               mem_noc: interconnect@1380000 {
>> +                       compatible = "qcom,sdm845-mem-noc";
>> +                       reg = <0 0x01380000 0 0x27200>;
>> +                       #interconnect-cells = <1>;
>> +                       qcom,bcm-voters = <&apps_bcm_voter>;
>> +               };
>> +
>> +               dc_noc: interconnect@14e0000 {
>> +                       compatible = "qcom,sdm845-dc-noc";
>> +                       reg = <0 0x014e0000 0 0x400>;
>> +                       #interconnect-cells = <1>;
>> +                       qcom,bcm-voters = <&apps_bcm_voter>;
>> +               };
>> +
>> +               config_noc: interconnect@1500000 {
>> +                       compatible = "qcom,sdm845-config-noc";
>> +                       reg = <0 0x01500000 0 0x5080>;
>> +                       #interconnect-cells = <1>;
>> +                       qcom,bcm-voters = <&apps_bcm_voter>;
>> +               };
>> +
>> +               system_noc: interconnect@1620000 {
>> +                       compatible = "qcom,sdm845-system-noc";
>> +                       reg = <0 0x01620000 0 0x18080>;
>> +                       #interconnect-cells = <1>;
>> +                       qcom,bcm-voters = <&apps_bcm_voter>;
>> +               };
>> +
>> +               aggre1_noc: interconnect@16e0000 {
>> +                       compatible = "qcom,sdm845-aggre1-noc";
>> +                       reg = <0 0x016e0000 0 0xd080>;
>> +                       #interconnect-cells = <1>;
>> +                       qcom,bcm-voters = <&apps_bcm_voter>;
>> +               };
>> +
>> +               aggre2_noc: interconnect@1700000 {
>> +                       compatible = "qcom,sdm845-aggre2-noc";
>> +                       reg = <0 0x01700000 0 0x3b100>;
>> +                       #interconnect-cells = <1>;
>> +                       qcom,bcm-voters = <&apps_bcm_voter>;
>> +               };
>> +
>> +               mmss_noc: interconnect@1740000 {
>> +                       compatible = "qcom,sdm845-mmss-noc";
>> +                       reg = <0 0x01740000 0 0x1c1000>;
>> +                       #interconnect-cells = <1>;
>> +                       qcom,bcm-voters = <&apps_bcm_voter>;
>> +               };
>> +
>>                 ufs_mem_hc: ufshc@1d84000 {
>>                         compatible = "qcom,sdm845-ufshc", 
>> "qcom,ufshc",
>>                                      "jedec,ufs-2.0";
>> @@ -3100,6 +3149,13 @@
>>                         #mbox-cells = <1>;
>>                 };
>> 
>> +               gladiator_noc: interconnect@17900000 {
>> +                       compatible = "qcom,sdm845-gladiator-noc";
>> +                       reg = <0 0x17900000 0 0xd080>;
>> +                       #interconnect-cells = <1>;
>> +                       qcom,bcm-voters = <&apps_bcm_voter>;
>> +               };
>> +
>>                 apps_rsc: rsc@179c0000 {
>>                         label = "apps_rsc";
>>                         compatible = "qcom,rpmh-rsc";
>> @@ -3174,9 +3230,8 @@
>>                                 };
>>                         };
>> 
>> -                       rsc_hlos: interconnect {
>> -                               compatible = "qcom,sdm845-rsc-hlos";
>> -                               #interconnect-cells = <1>;
> 
> With this reworking of the bindings the examples in these files are now 
> broken:
> Documentation/devicetree/bindings/display/msm/gpu.txt
> Documentation/devicetree/bindings/display/msm/dpu.txt
> 
> It would be nice to fix them up in a subsequent change.

looks like most of them qcom
display bindings are in the
process of getting converted
to yaml, we'll have to make
sure that it gets addressed
then.

> -Evan

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.

      reply index

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-10  4:32 [PATCH v2 0/6] Split SDM845 interconnect nodes and consolidate RPMh support David Dai
2020-01-10  4:32 ` [PATCH v2 1/6] dt-bindings: interconnect: Convert qcom,sdm845 to DT schema David Dai
2020-01-15 14:39   ` Rob Herring
2020-01-10  4:33 ` [PATCH v2 2/6] dt-bindings: interconnect: Add YAML schemas for QCOM bcm-voter David Dai
2020-01-15 14:44   ` Rob Herring
2020-01-10  4:33 ` [PATCH v2 3/6] dt-bindings: interconnect: Update Qualcomm SDM845 DT bindings David Dai
2020-01-15 14:49   ` Rob Herring
2020-01-17  0:07     ` David Dai
2020-01-31 21:35   ` Evan Green
2020-01-10  4:33 ` [PATCH v2 4/6] interconnect: qcom: Consolidate interconnect RPMh support David Dai
2020-02-04 18:22   ` Evan Green
2020-02-09 17:58     ` Sibi Sankar
2020-01-10  4:33 ` [PATCH v2 5/6] interconnect: qcom: sdm845: Split qnodes into their respective NoCs David Dai
2020-02-04 18:21   ` Evan Green
2020-02-09 18:04     ` Sibi Sankar
2020-01-10  4:33 ` [PATCH v2 6/6] arm64: dts: sdm845: Redefine interconnect provider DT nodes David Dai
2020-02-04 18:18   ` Evan Green
2020-02-09 18:03     ` Sibi Sankar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=649c804c30e90088e4f7aa44cee2753e@codeaurora.org \
    --to=sibis@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=daidavid1@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=elder@linaro.org \
    --cc=evgreen@google.com \
    --cc=georgi.djakov@linaro.org \
    --cc=ilina@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel-owner@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=seansw@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git