From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753416AbdJPOvr (ORCPT ); Mon, 16 Oct 2017 10:51:47 -0400 Received: from osg.samsung.com ([64.30.133.232]:50915 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752709AbdJPOvp (ORCPT ); Mon, 16 Oct 2017 10:51:45 -0400 Subject: Re: [PATCH 0/2] fix lockdep warnings in s5p_mfc and exynos-gsc vb2 drivers To: Marek Szyprowski , mchehab@kernel.org, hansverk@cisco.com, kgene@kernel.org, krzk@kernel.org, s.nawrocki@samsung.com, shailendra.v@samsung.com, shuah@kernel.org, Julia.Lawall@lip6.fr, kyungmin.park@samsung.com, kamil@wypas.org, jtp.park@samsung.com, a.hajda@samsung.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, Shuah Khan References: From: Shuah Khan Message-ID: <649e7ce7-6d2a-55da-7ca4-214400dc1708@osg.samsung.com> Date: Mon, 16 Oct 2017 08:51:20 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marek, On 10/16/2017 06:48 AM, Marek Szyprowski wrote: > Hi Shuah, > > On 2017-10-14 01:13, Shuah Khan wrote: >> Driver mmap functions shouldn't hold lock when calling vb2_mmap(). The >> vb2_mmap() function has its own lock that it uses to protect the critical >> section. >> >> Reference: commit log for f035eb4e976ef5a059e30bc91cfd310ff030a7d3 > > It would make sense to add the information about the reference commit to each > commit message and also point to commit e752577ed7bf55c81e10343fced8b378cda2b63b, > as it is exactly the same case here. Anyway: I think It does make sense to add the commit information to each commit message. I can do that send v2. > > Acked-by: Marek Szyprowski Thanks. > > I wonder if makes sense to send those patches also to stable@vget.kernel.org > (maybe v4.3+, like the mentioned above commit, if they really apply?). I don't believe they will apply as is. I can work back-porting once these get into the mainline. > >> Shuah Khan (2): >> media: exynos-gsc: fix lockdep warning >> media: s5p-mfc: fix lockdep warning >> >> drivers/media/platform/exynos-gsc/gsc-m2m.c | 5 ----- >> drivers/media/platform/s5p-mfc/s5p_mfc.c | 3 --- >> 2 files changed, 8 deletions(-) >> > > Best regards thanks, -- Shuah