From: "Andy Lutomirski" <luto@kernel.org>
To: "Brian Geffon" <bgeffon@google.com>,
"Dave Hansen" <dave.hansen@intel.com>
Cc: "Thomas Gleixner" <tglx@linutronix.de>,
"Guenter Roeck" <groeck@google.com>,
"Borislav Petkov" <bp@suse.de>,
stable@vger.kernel.org,
"the arch/x86 maintainers" <x86@kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: XSAVE / RDPKRU on Intel 11th Gen Core CPUs
Date: Tue, 09 Nov 2021 06:57:47 -0800 [thread overview]
Message-ID: <649f4de7-3c91-4974-9af7-d981a2bf6224@www.fastmail.com> (raw)
In-Reply-To: <CADyq12whSxPdJhf4qg_w-7YXgEKWx4SDHByNBNZbfWDOeEY-8w@mail.gmail.com>
On Tue, Nov 9, 2021, at 5:43 AM, Brian Geffon wrote:
> Hi Dave,
>
> On Tue, Nov 9, 2021 at 1:49 AM Dave Hansen <dave.hansen@intel.com> wrote:
>> Well, gosh, it's making it back to the software init value. If you do:
>>
>> echo 0x15555554 > /sys/kernel/debug/x86/init_pkru
>>
>> do you end up with 0x15555554 as the value?
>
> What's interesting is that writing to init_pkru fails with -EINVAL for me,
> and I've traced it down to get_xsave_addr() returning NULL on the following
> check:
>
> /*
> * This assumes the last 'xsave*' instruction to
> * have requested that 'xfeature_nr' be saved.
> * If it did not, we might be seeing and old value
> * of the field in the buffer.
> *
> * This can happen because the last 'xsave' did not
> * request that this feature be saved (unlikely)
> * or because the "init optimization" caused it
> * to not be saved.
> */
> if (!(xsave->header.xfeatures & BIT_ULL(xfeature_nr)))
> return NULL;
Here's an excerpt from an old email that I, perhaps unwisely, sent to Dave but not to a public list:
static inline void write_pkru(u32 pkru)
{
struct pkru_state *pk;
if (!boot_cpu_has(X86_FEATURE_OSPKE))
return;
pk = get_xsave_addr(¤t->thread.fpu.state.xsave,
XFEATURE_PKRU);
/*
* The PKRU value in xstate needs to be in sync with the value
that is
* written to the CPU. The FPU restore on return to userland would
* otherwise load the previous value again.
*/
fpregs_lock();
if (pk)
pk->pkru = pkru;
^^^
else we just write to the PKRU register but leave XINUSE[PKRU] clear on
return to usermode? That seems... unwise.
__write_pkru(pkru);
fpregs_unlock();
}
I bet you're hitting exactly this bug. The fix ended up being a whole series of patches, but the gist of it is that the write_pkru() slow path needs to set the xfeature bit in the xsave buffer and then do the write. It should be possible to make a little patch to do just this in a couple lines of code.
next prev parent reply other threads:[~2021-11-09 14:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CADyq12yY25-LS8cV5LY-C=6_0HLPVZbSJCKtCDJm+wyHQSeVTg@mail.gmail.com>
2021-11-08 19:37 ` XSAVE / RDPKRU on Intel 11th Gen Core CPUs Dave Hansen
2021-11-08 22:00 ` Dave Hansen
2021-11-08 23:20 ` Brian Geffon
2021-11-09 1:47 ` Brian Geffon
2021-11-09 6:49 ` Dave Hansen
2021-11-09 13:43 ` Brian Geffon
2021-11-09 14:14 ` Brian Geffon
2021-11-09 14:57 ` Andy Lutomirski [this message]
2021-11-09 18:58 ` Brian Geffon
2021-11-09 19:25 ` Brian Geffon
2021-11-09 19:29 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=649f4de7-3c91-4974-9af7-d981a2bf6224@www.fastmail.com \
--to=luto@kernel.org \
--cc=bgeffon@google.com \
--cc=bp@suse.de \
--cc=dave.hansen@intel.com \
--cc=groeck@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).