From: Maxim Levitsky <mlevitsk@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, rafael.j.wysocki@intel.com,
sakari.ailus@linux.intel.com, heikki.krogerus@linux.intel.com,
gregkh@linuxfoundation.org
Subject: Re: kernel oops in 'typec_ucsi' due to commit 'drivers property: When no children in primary, try secondary'
Date: Thu, 16 Jul 2020 21:22:11 +0300 [thread overview]
Message-ID: <64a1ba836139b028936e24705eab06a032d598cf.camel@redhat.com> (raw)
In-Reply-To: <20200716182120.GS3703480@smile.fi.intel.com>
On Thu, 2020-07-16 at 21:21 +0300, Andy Shevchenko wrote:
> On Thu, Jul 16, 2020 at 09:00:00PM +0300, Maxim Levitsky wrote:
> > On Thu, 2020-07-16 at 18:47 +0300, Andy Shevchenko wrote:
> > > On Thu, Jul 16, 2020 at 11:17:03AM +0300, Maxim Levitsky wrote:
> > > > Hi!
> > > >
> > > > Few days ago I bisected a regression on 5.8 kernel:
> > > >
> > > > I have nvidia rtx 2070s and its USB type C port driver (which is open source)
> > > > started to crash on load:
> > >
> > > ...
> > >
> > > > Reverting the commit helped fix this oops.
> > > >
> > > > My .config attached.
> > > > If any more info is needed I'll be happy to provide it,
> > > > and of course test patches.
> > >
> > > Can you test below?
> > >
> > > diff --git a/drivers/base/property.c b/drivers/base/property.c
> > > index 1e6d75e65938..d58aa98fe964 100644
> > > --- a/drivers/base/property.c
> > > +++ b/drivers/base/property.c
> > > @@ -721,7 +721,7 @@ struct fwnode_handle *device_get_next_child_node(struct device *dev,
> > > return next;
> > >
> > > /* When no more children in primary, continue with secondary */
> > > - if (!IS_ERR_OR_NULL(fwnode->secondary))
> > > + if (fwnode && !IS_ERR_OR_NULL(fwnode->secondary))
> > > next = fwnode_get_next_child_node(fwnode->secondary, child);
> > >
> > > return next;
> >
> > It works (no more oops)
>
> Thanks for testing. I'm about to send formal patch, can you give your Tested-by tag there then?
Of course.
Tested-by: Maxim Levitsky <mlevitsk@redhat.com>
Best regards,
Maxim Levitsky
>
next prev parent reply other threads:[~2020-07-16 18:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 8:17 kernel oops in 'typec_ucsi' due to commit 'drivers property: When no children in primary, try secondary' Maxim Levitsky
2020-07-16 8:28 ` Greg KH
2020-07-16 8:47 ` Maxim Levitsky
2020-07-16 14:34 ` Andy Shevchenko
2020-07-16 17:59 ` Maxim Levitsky
2020-07-16 15:47 ` Andy Shevchenko
2020-07-16 18:00 ` Maxim Levitsky
2020-07-16 18:21 ` Andy Shevchenko
2020-07-16 18:22 ` Maxim Levitsky [this message]
2020-07-16 18:33 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64a1ba836139b028936e24705eab06a032d598cf.camel@redhat.com \
--to=mlevitsk@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).