From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8600C432C3 for ; Wed, 27 Nov 2019 14:32:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 73D3E20674 for ; Wed, 27 Nov 2019 14:32:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V0SJ5YXp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727205AbfK0OcR (ORCPT ); Wed, 27 Nov 2019 09:32:17 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:34581 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726591AbfK0OcR (ORCPT ); Wed, 27 Nov 2019 09:32:17 -0500 Received: by mail-lj1-f193.google.com with SMTP id m6so17353099ljc.1; Wed, 27 Nov 2019 06:32:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=G00SHIj8HaZMxGCzFcaxH3zuEzPMMLNA3auZzPKOoUg=; b=V0SJ5YXpoXsZhy2mVssl/oaUHCCkXn/uo8iwtzcSEuBCVbT4oHXaYGCkcR+iIobBqX a4YqaT9W2rA66J+T90EqjAhYy4IpewQBfA/VcgZIL8HGS0Vy+smYXUdor8c+ScoFWY9C Z8xgDJiaKj85lQvSOkDSbL+aUb1FM1vJJIjevxw2l2JV4R+dHztuePVf003G1Se+4zw5 a4pJ8d2taC5F5U7hYUeNMnQmx+fTUz4nNXyvJCCvNqX6mFE7bFlAtPdT2iSMIUhrGxtx oe2BlPE034n0YEc8gF+5PQfi7amCp6aE9U85u4fGbq/4MUx/4B2/B2kupeYLeRpF2Wdx m8xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=G00SHIj8HaZMxGCzFcaxH3zuEzPMMLNA3auZzPKOoUg=; b=SzAKscpL7HypEPTI81/UMBBtT2N3jfvFWIgPcWSTMQUwK54OaLQfPtByiwYQAwDTom 9x0Hz5VorkL4dn916qcjUUkZtSBnpzyXdFOscfzQ9NAe4EwX9B5V/W4POYO/v/X1hQbe jrchX1/+FdCDN7IcvwSU4dNmPJQycI6EOi9GE6SwFH5jWE1jKPsr1LaLOm5AH9E2ceNv ah6HBeT5dH7KXD+IBmFHXM3F804wxa2N5e3751npDBMVmRNdegSCi0Qnk5uEpfvq9j59 z5Poflt3vbO/OqvJQDPQsfPr29Y8bYxo1trWGAZEEl+CkVTB3XbZtnyMi3CMs5OV5HEf qXbw== X-Gm-Message-State: APjAAAWqYaQTVq713sMJYEKwARwiezPVSAjFtYdsFOT2eO7pOx+rUOCI cuQ5n3LAuozgB+FCBZKJ1r8Q0CXq X-Google-Smtp-Source: APXvYqxwPB997GOz8MMewM2L0dcNl3swOuQ4ZORuX65yeTj0JIcctBOZB12/uSeRhXDzH+kqZGalbg== X-Received: by 2002:a2e:3216:: with SMTP id y22mr16711520ljy.95.1574865133647; Wed, 27 Nov 2019 06:32:13 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id o15sm7373513ljc.28.2019.11.27.06.32.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Nov 2019 06:32:13 -0800 (PST) Subject: Re: [PATCH v2 02/11] soc: tegra: Add Tegra PMC clock registrations into PMC driver To: Sowjanya Komatineni , thierry.reding@gmail.com, jonathanh@nvidia.com, mperttunen@nvidia.com, gregkh@linuxfoundation.org, sboyd@kernel.org, tglx@linutronix.de, robh+dt@kernel.org, mark.rutland@arm.com Cc: allison@lohutok.net, pdeschrijver@nvidia.com, pgaikwad@nvidia.com, mturquette@baylibre.com, horms+renesas@verge.net.au, Jisheng.Zhang@synaptics.com, krzk@kernel.org, arnd@arndb.de, spujar@nvidia.com, josephl@nvidia.com, vidyas@nvidia.com, daniel.lezcano@linaro.org, mmaddireddy@nvidia.com, markz@nvidia.com, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <1574830773-14892-1-git-send-email-skomatineni@nvidia.com> <1574830773-14892-3-git-send-email-skomatineni@nvidia.com> From: Dmitry Osipenko Message-ID: <64b6a780-d06c-9a10-490b-7285d2b0e207@gmail.com> Date: Wed, 27 Nov 2019 17:32:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <1574830773-14892-3-git-send-email-skomatineni@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 27.11.2019 07:59, Sowjanya Komatineni пишет: > Tegra210 and prior Tegra PMC has clk_out_1, clk_out_2, clk_out_3 with > mux and gate for each of these clocks. > > Currently these PMC clocks are registered by Tegra clock driver using > clk_register_mux and clk_register_gate by passing PMC base address > and register offsets and PMC programming for these clocks happens > through direct PMC access by the clock driver. > > With this, when PMC is in secure mode any direct PMC access from the > non-secure world does not go through and these clocks will not be > functional. > > This patch adds these clocks registration with PMC as a clock provider > for these clocks. clk_ops callback implementations for these clocks > uses tegra_pmc_readl and tegra_pmc_writel which supports PMC programming > in secure mode and non-secure mode. > > Signed-off-by: Sowjanya Komatineni > --- > drivers/soc/tegra/pmc.c | 330 ++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 330 insertions(+) > > diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c > index ea0e11a09c12..a353f6d0a832 100644 > --- a/drivers/soc/tegra/pmc.c > +++ b/drivers/soc/tegra/pmc.c > @@ -13,6 +13,9 @@ > > #include > #include > +#include > +#include > +#include > #include > #include > #include > @@ -48,6 +51,7 @@ > #include > #include > #include > +#include > > #define PMC_CNTRL 0x0 > #define PMC_CNTRL_INTR_POLARITY BIT(17) /* inverts INTR polarity */ > @@ -100,6 +104,7 @@ > #define PMC_WAKE2_STATUS 0x168 > #define PMC_SW_WAKE2_STATUS 0x16c > > +#define PMC_CLK_OUT_CNTRL 0x1a8 > #define PMC_SENSOR_CTRL 0x1b0 > #define PMC_SENSOR_CTRL_SCRATCH_WRITE BIT(2) > #define PMC_SENSOR_CTRL_ENABLE_RST BIT(1) > @@ -155,6 +160,91 @@ > #define TEGRA_SMC_PMC_READ 0xaa > #define TEGRA_SMC_PMC_WRITE 0xbb > > +struct pmc_clk_mux { > + struct clk_hw hw; > + unsigned long offs; > + u32 mask; > + u32 shift; > +}; > + > +#define to_pmc_clk_mux(_hw) container_of(_hw, struct pmc_clk_mux, hw) > + > +struct pmc_clk_gate { > + struct clk_hw hw; > + unsigned long offs; > + u32 shift; > +}; > + > +#define to_pmc_clk_gate(_hw) container_of(_hw, struct pmc_clk_gate, hw) > + > +struct pmc_clk_init_data { > + char *mux_name; > + char *gate_name; > + const char **parents; > + int num_parents; > + int mux_id; > + int gate_id; > + char *dev_name; > + u8 mux_shift; > + u8 gate_shift; > + u8 init_parent_index; > + int init_state; > +}; > + > +static const char *clk_out1_parents[] = { "clk_m", "clk_m_div2", > + "clk_m_div4", "extern1", > +}; > + > +static const char *clk_out2_parents[] = { "clk_m", "clk_m_div2", > + "clk_m_div4", "extern2", > +}; > + > +static const char *clk_out3_parents[] = { "clk_m", "clk_m_div2", > + "clk_m_div4", "extern3", > +}; > + > +static struct pmc_clk_init_data tegra_pmc_clks_data[] = { const? [snip]