From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941537AbcKOJtU (ORCPT ); Tue, 15 Nov 2016 04:49:20 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35959 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941344AbcKOJtS (ORCPT ); Tue, 15 Nov 2016 04:49:18 -0500 Subject: Re: [PATCHv7 08/11] i2c: match vendorless strings on the internal string length To: Wolfram Sang References: <1478522866-29620-1-git-send-email-kieran@bingham.xyz> <1478522866-29620-9-git-send-email-kieran@bingham.xyz> <20161114203208.GA4207@katana> Cc: Lee Jones , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Javier Martinez Canillas , sameo@linux.intel.com From: Kieran Bingham Message-ID: <64c4a261-1097-6baa-0ab0-b9ca16bcdf66@bingham.xyz> Date: Tue, 15 Nov 2016 09:49:15 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161114203208.GA4207@katana> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/11/16 22:27, Wolfram Sang wrote: > On Mon, Nov 07, 2016 at 12:47:43PM +0000, Kieran Bingham wrote: >> If a user provides a shortened string to match a device to the sysfs i2c >> interface it will match on the first string that contains that string >> prefix. >> >> for example: >> echo a 0x68 > /sys/bus/i2c/devices/i2c-2/new_device >> will match as3711, as3722, and ak8975 incorrectly. >> >> Correct this by using sysfs_streq to match the string exactly >> >> Signed-off-by: Kieran Bingham > > Any objections that I squash this directly into patch 2? It is more like > a bugfix, no? No objection Acked-by: Kieran Bingham -- Regards Kieran Bingham