From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751375AbeAWP3H (ORCPT ); Tue, 23 Jan 2018 10:29:07 -0500 Received: from mail-qt0-f174.google.com ([209.85.216.174]:33032 "EHLO mail-qt0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751234AbeAWP3F (ORCPT ); Tue, 23 Jan 2018 10:29:05 -0500 X-Google-Smtp-Source: AH8x226bX9VgTf5csQA6bgJaXAVHV24anrWwmVw0KV4mqeO7b3i8n6edyZH0avXpTOkGeBfTbuBMDA== Subject: Re: [PATCHv5 1/5] net: dsa: Support internal phy on 'cpu' port To: Sebastian Reichel , Andrew Lunn , Vivien Didelot , Shawn Guo , Sascha Hauer , Fabio Estevam Cc: Ian Ray , Nandor Han , Rob Herring , "David S. Miller" , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@lists.collabora.co.uk References: <20180123150350.11031-1-sebastian.reichel@collabora.co.uk> <20180123150350.11031-2-sebastian.reichel@collabora.co.uk> From: Florian Fainelli Message-ID: <64d5fcf0-6bee-b28a-c5b4-ad1868d74d9f@gmail.com> Date: Tue, 23 Jan 2018 07:29:00 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180123150350.11031-2-sebastian.reichel@collabora.co.uk> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/23/2018 07:03 AM, Sebastian Reichel wrote: > This adds support for enabling the internal PHY for a 'cpu' port. > It has been tested on GE B850v3, B650v3 and B450v3, which have a > built-in MV88E6240 switch hardwired to a PCIe based network card. > On these machines the internal PHY of the i210 network card and > the Marvell switch are connected to each other and must be enabled > for properly using the switch. While the i210 PHY will be enabled > when the network interface is enabled, the switch's port is not > exposed as network interface. Additionally the mv88e6xxx driver > resets the chip during probe, so the PHY is disabled without this > patch. This looks good now, thanks for your patience Sebastian! > > Signed-off-by: Sebastian Reichel Reviewed-by: Florian Fainelli -- Florian