From: "jianchao.wang" <jianchao.w.wang@oracle.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/3] blk-mq: refactor the code of issue request directly
Date: Mon, 29 Oct 2018 13:40:54 +0800 [thread overview]
Message-ID: <64ec3df3-27f8-4d75-5ec9-6427ffcf1244@oracle.com> (raw)
In-Reply-To: <20181029024937.GC32606@ming.t460p>
Hi Ming
On 10/29/18 10:49 AM, Ming Lei wrote:
> On Sat, Oct 27, 2018 at 12:01:09AM +0800, Jianchao Wang wrote:
>> Merge blk_mq_try_issue_directly and __blk_mq_try_issue_directly
>> into one interface which is able to handle the return value from
>> .queue_rq callback. Due to we can only issue directly w/o io
>> scheduler, so remove the blk_mq_get_driver_tag.
>
> It isn't correct for dm-rq, see blk_insert_cloned_request().
>
Yes, got it.
when the original requests are issued to the underlying paths as cloned
requests, they should not pass through the io scheduler.
Thanks
Jianchao
next prev parent reply other threads:[~2018-10-29 5:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 16:01 [PATCH V2 0/3] blk-mq: refactor and fix on issue request directly Jianchao Wang
2018-10-26 16:01 ` [PATCH V2 1/3] blk-mq: refactor the code of " Jianchao Wang
2018-10-29 2:49 ` Ming Lei
2018-10-29 5:40 ` jianchao.wang [this message]
2018-10-26 16:01 ` [PATCH V2 2/3] blk-mq: issue directly with bypass 'false' in blk_mq_sched_insert_requests Jianchao Wang
2018-10-26 16:01 ` [PATCH V2 3/3] blk-mq: ensure hctx to be ran on mapped cpu when issue directly Jianchao Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64ec3df3-27f8-4d75-5ec9-6427ffcf1244@oracle.com \
--to=jianchao.w.wang@oracle.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).