From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967220AbdADBV5 (ORCPT ); Tue, 3 Jan 2017 20:21:57 -0500 Received: from mail-pg0-f52.google.com ([74.125.83.52]:33914 "EHLO mail-pg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935242AbdADBVf (ORCPT ); Tue, 3 Jan 2017 20:21:35 -0500 Subject: Re: [PATCH 3/3] scsi: hisi_sas: lock sensitive region in hisi_sas_slot_abort() To: John Garry , jejb@linux.vnet.ibm.com, martin.petersen@oracle.com References: <1483446290-185084-1-git-send-email-john.garry@huawei.com> <1483446290-185084-4-git-send-email-john.garry@huawei.com> Cc: linuxarm@huawei.com, xuwei5@hisilicon.com, john.garry2@mail.dcu.ie, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, hanjun.guo@linaro.org From: zhangfei Message-ID: <64edc70b-8ff0-a9d5-8552-167bb560cf16@linaro.org> Date: Wed, 4 Jan 2017 09:20:26 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1483446290-185084-4-git-send-email-john.garry@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017年01月03日 20:24, John Garry wrote: > When we call hisi_sas_slot_task_free() we should grab the > hisi_hba.lock, as hisi_sas_slot_task_free() accesses common > hisi_hba elements. > Function hisi_sas_slot_abort() is missing this, so add it. > > Signed-off-by: John Garry Reviewed-by: Zhangfei Gao