From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751673AbdBAK6r convert rfc822-to-8bit (ORCPT ); Wed, 1 Feb 2017 05:58:47 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:45475 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751192AbdBAK6q (ORCPT ); Wed, 1 Feb 2017 05:58:46 -0500 content-type: text/plain; charset="utf-8" in-reply-to: from: "Peter Senna Tschudin" X-Forward: 82.136.76.99 date: Wed, 01 Feb 2017 10:58:43 +0000 cc: ijc+devicetree@hellion.org.uk, "Fabio Estevam" , treding@nvidia.com, linux-kernel@vger.kernel.org, davem@davemloft.net, mark.rutland@arm.com, ykk@rock-chips.com, martin.donnelly@ge.com, mchehab@osg.samsung.com, robh+dt@kernel.org, galak@codeaurora.org, peter.senna@gmail.com, pawel.moll@arm.com, javier@dowhile0.org, gregkh@linuxfoundation.org, akpm@linux-foundation.org, shawnguo@kernel.org, "Peter Senna Tschudin" , tiwai@suse.com, linux@roeck-us.net, martyn.welch@collabora.co.uk, rmk+kernel@armlinux.org.uk, kernel@pengutronix.de, daniel.vetter@ffwll.ch, jslaby@suse.cz, devicetree@vger.kernel.org, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, enric.balletbo@collabora.com, dri-devel@lists.freedesktop.org, "Jani Nikula" to: "Archit Taneja" MIME-Version: 1.0 message-id: <64ff-5891bf80-f-117f65c0@159002012> subject: =?utf-8?q?Re=3A?==?utf-8?q?_=5BPATCH?= V7 =?utf-8?q?3=2F4=5D?= =?utf-8?q?_drm=2Fbridge=3A?= Add driver for GE B850v3 =?utf-8?q?LVDS=2FDP++?= Bridge User-Agent: SOGoMail 2.3.11 content-transfer-encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Archit, On 01 February, 2017 10:44 CET, Archit Taneja wrote: > > > On 01/30/2017 10:35 PM, Jani Nikula wrote: > > On Sat, 28 Jan 2017, Peter Senna Tschudin wrote: > >> On Thu, Jan 05, 2017 at 01:18:47PM +0530, Archit Taneja wrote: > >> Hi Archit, > >> > >> Thank you for the comments! > >> > >> [...] > >>>> + total_size = (block[EDID_EXT_BLOCK_CNT] + 1) * EDID_LENGTH; > >>>> + if (total_size > EDID_LENGTH) { > >>>> + kfree(block); > >>>> + block = kmalloc(total_size, GFP_KERNEL); > >>>> + if (!block) > >>>> + return NULL; > >>>> + > >>>> + /* Yes, read the entire buffer, and do not skip the first > >>>> + * EDID_LENGTH bytes. > >>>> + */ > >>> > >>> Is this the reason why you aren't using drm_do_get_edid()? > >> > >> Yes, for some hw specific reason, it is necessary to read the entire > >> EDID buffer starting from 0, not block by block. > > > > Hrmh, I'm planning on moving the edid override and firmware edid > > mechanisms at the drm_do_get_edid() level to be able to truly and > > transparently use a different edid. Currently, they're only used for > > modes, really, and lead to some info retrieved from overrides, some from > > the real edid. This kind of hacks will bypass the override/firmware edid > > mechanisms then too. :( > > It seems like there is a HW issue which prevents them from reading EDID > from an offset. So, I'm not sure if it is a hack or a HW limitation. > > One way around this would be to hide the HW requirement in the > get_edid_block func pointer passed to drm_do_get_edid(). This > would, however, result in more i2c reads (equal to # of extension > blocks) than what the patch currently does. > > Peter, if you think doing extra EDID reads isn't too costly on your > platform, you could consider using drm_do_get_edid(). If not, I guess > you'll miss out on the additional functionality Jani is going to add > in the future. My concern is that for almost one year now, every time I fix something one or two new requests are made. I'm happy to fix the driver, but I want a list of the changes that are required to get it upstream, before I make more changes. Can we agree on exactly what is preventing this driver to get upstream? Then I'll fix it. > > Thanks, > Archit > > > > > > BR, > > Jani. > > > > > >> > >> [...] > >> > >> I fixed all your other suggestions. Thank you! > >> _______________________________________________ > >> dri-devel mailing list > >> dri-devel@lists.freedesktop.org > >> https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project