linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Auger Eric <eric.auger@redhat.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfio: platform: reset: fix up include directives to remove ccflags-y
Date: Mon, 4 Feb 2019 13:23:43 +0100	[thread overview]
Message-ID: <650a11f0-e591-427a-ad29-c72ae0e1fe11@redhat.com> (raw)
In-Reply-To: <1548816751-32068-1-git-send-email-yamada.masahiro@socionext.com>

Hi Masahiro,

On 1/30/19 3:52 AM, Masahiro Yamada wrote:
> For the include directive with double-quotes "", the preprocessor
> searches the header in the relative path to the current file.
> 
> Fix them up, and remove the header search path option.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Eric Auger <eric.auger@redhat.com>

Thanks

Eric

> ---
> 
>  drivers/vfio/platform/reset/Makefile                     | 2 --
>  drivers/vfio/platform/reset/vfio_platform_amdxgbe.c      | 2 +-
>  drivers/vfio/platform/reset/vfio_platform_bcmflexrm.c    | 2 +-
>  drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c | 2 +-
>  4 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/vfio/platform/reset/Makefile b/drivers/vfio/platform/reset/Makefile
> index 57abd4f..7294c5e 100644
> --- a/drivers/vfio/platform/reset/Makefile
> +++ b/drivers/vfio/platform/reset/Makefile
> @@ -2,8 +2,6 @@
>  vfio-platform-calxedaxgmac-y := vfio_platform_calxedaxgmac.o
>  vfio-platform-amdxgbe-y := vfio_platform_amdxgbe.o
>  
> -ccflags-y += -Idrivers/vfio/platform
> -
>  obj-$(CONFIG_VFIO_PLATFORM_CALXEDAXGMAC_RESET) += vfio-platform-calxedaxgmac.o
>  obj-$(CONFIG_VFIO_PLATFORM_AMDXGBE_RESET) += vfio-platform-amdxgbe.o
>  obj-$(CONFIG_VFIO_PLATFORM_BCMFLEXRM_RESET) += vfio_platform_bcmflexrm.o
> diff --git a/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c b/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c
> index bcd419c..3ddb270 100644
> --- a/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c
> +++ b/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c
> @@ -25,7 +25,7 @@
>  #include <uapi/linux/mdio.h>
>  #include <linux/delay.h>
>  
> -#include "vfio_platform_private.h"
> +#include "../vfio_platform_private.h"
>  
>  #define DMA_MR			0x3000
>  #define MAC_VR			0x0110
> diff --git a/drivers/vfio/platform/reset/vfio_platform_bcmflexrm.c b/drivers/vfio/platform/reset/vfio_platform_bcmflexrm.c
> index d45c3be..16165a6 100644
> --- a/drivers/vfio/platform/reset/vfio_platform_bcmflexrm.c
> +++ b/drivers/vfio/platform/reset/vfio_platform_bcmflexrm.c
> @@ -23,7 +23,7 @@
>  #include <linux/kernel.h>
>  #include <linux/module.h>
>  
> -#include "vfio_platform_private.h"
> +#include "../vfio_platform_private.h"
>  
>  /* FlexRM configuration */
>  #define RING_REGS_SIZE					0x10000
> diff --git a/drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c b/drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c
> index 49e5df6..e0356de 100644
> --- a/drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c
> +++ b/drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c
> @@ -24,7 +24,7 @@
>  #include <linux/init.h>
>  #include <linux/io.h>
>  
> -#include "vfio_platform_private.h"
> +#include "../vfio_platform_private.h"
>  
>  #define DRIVER_VERSION  "0.1"
>  #define DRIVER_AUTHOR   "Eric Auger <eric.auger@linaro.org>"
> 

  reply	other threads:[~2019-02-04 12:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-30  2:52 [PATCH] vfio: platform: reset: fix up include directives to remove ccflags-y Masahiro Yamada
2019-02-04 12:23 ` Auger Eric [this message]
2019-02-05 20:38 ` Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=650a11f0-e591-427a-ad29-c72ae0e1fe11@redhat.com \
    --to=eric.auger@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).