From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934173AbcIRMxP (ORCPT ); Sun, 18 Sep 2016 08:53:15 -0400 Received: from mout.web.de ([212.227.17.11]:60801 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751541AbcIRMxA (ORCPT ); Sun, 18 Sep 2016 08:53:00 -0400 Subject: [PATCH 2/6] firmware-qemu_fw_cfg: Improve a size determination in fw_cfg_register_file() To: qemu-devel@nongnu.org, Gabriel Somlo , "Michael S. Tsirkin" References: <566ABCD9.1060404@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <6517cf5c-06ea-8b97-b2f2-b4e0253ed48f@users.sourceforge.net> Date: Sun, 18 Sep 2016 14:52:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:foP5tc+wIu9ZfVXltvjKKtG9wdlkpbm4E7IVekCDi9+/9iN7oD9 dSUcSO9fEEV2lxPgntw4hej7InYqQweLsPCIKSyl0WskkfNNZs3ed4iXjiJa4bCzvtYuTxA pZRUsqxWt+dtv8+khYz8CSoavbRCuj1Cc4hc3hPTRssW1zlc88jH/ebjeUtwVfCKIkvgRvf 1wbZPPK0I6ZAgEmHpxhpw== X-UI-Out-Filterresults: notjunk:1;V01:K0:Vq83L5zOWr4=:TwagUdWjlnw6eU9gp77Sa+ T3v+n1A9dbfcrypEdeLDa+e2UxGCX2Dt73qvOAjpQP2RbaBV3yv4GlG1okAGdUs0NV4LbSBgz fbPMIJfqzWwuKIiOcvQ7Ou1ZedO/KhpCpSSaP3XIYCgLvylXh6XNnlJLGJD3wbEUOS4Jba5wv SpfxmxLSEeWpBLkWEMferjZckCe9mOd3SFljIBzjQ9/KAW1N+xAWs5TBJHTiUzjrFLLQkRhrE /Q8qLqShFIFJxN2EtFBkISbr7SKlNe70WzLOt6QmfBlTC7vcn0lwkHJkbYS6Z46QAleptlK3x W1G8haPkL6QYMBLIzFoMctUIV08UoudOaS+EUZi18v2r38mE7JJKWB57MFGJQCGDSEXrmdSh/ eEmNDBeLWrkX+1HUjWF9fn0bNJlhSoxOHlh0180KCtjhU8CYPEdAgdjmeZSxc0wFqkrap4yEi AeCi0Ti3yLFl7Ix0k4o5BBSRJZMr2KXiF5DvcOEbHbNhjAxUWQNmkuryiyqy0CUZzIwsy9Jh0 6FgbZCs+KEEcl7ERcCSq714tOcjR23CfV0ZQrG5TlirIVvsisY76U0HDZhG8ahMrhkI/LZOk+ j7NneBXdkG2MalXb5aMRruvrSWjlZ5ZO1pl1vX49aDgrDtWMg6Rnv2B6p3kHjcHuVHs88QrxO RGamcgqnCtvJeveAG9gNxLuYxx3qvX/UeqQX76l8xM/kp+vP00wW5+9Dh0R1OGYnhX+TTIyLJ C2Xf5bRCmVcHyYQx7vmxgvFR5ZlRiAJ+AtuTF/DU241F+Vm5Gx7gxNnAl/CDHbK5SrgXaSy+h cWDDf+Z Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 18 Sep 2016 10:43:27 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/firmware/qemu_fw_cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index e69653e..a229df6 100644 --- a/drivers/firmware/qemu_fw_cfg.c +++ b/drivers/firmware/qemu_fw_cfg.c @@ -458,7 +458,7 @@ static int fw_cfg_register_file(const struct fw_cfg_file *f) return -ENOMEM; /* set file entry information */ - memcpy(&entry->f, f, sizeof(struct fw_cfg_file)); + memcpy(&entry->f, f, sizeof(*f)); /* register entry under "/sys/firmware/qemu_fw_cfg/by_key/" */ err = kobject_init_and_add(&entry->kobj, &fw_cfg_sysfs_entry_ktype, -- 2.10.0