From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0897C4CECD for ; Mon, 16 Sep 2019 16:28:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B7BAD2184D for ; Mon, 16 Sep 2019 16:28:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568651338; bh=qaxG10o/mGSdB6gZBOwkHnO16O1InQHAiGeEVEnCMts=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=N5WqzfoHc2QUnG1U0NstVWcUvh4spnXn0w/INU5T9E5l4EKxpRlVCKJn+3mxIptdI u2oB4oujEt9ewyYeNbQoYJ/fmrHo/sskSzPoZGnEP+m+ifHIt2sjGabRsZJvasJ7lo ljDvGTGYc+iUzeqCocJ2o40ApZP0qbRWQDC0Ujs4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389956AbfIPQ26 (ORCPT ); Mon, 16 Sep 2019 12:28:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:58960 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729041AbfIPQ25 (ORCPT ); Mon, 16 Sep 2019 12:28:57 -0400 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 68D852184D; Mon, 16 Sep 2019 16:28:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568651336; bh=qaxG10o/mGSdB6gZBOwkHnO16O1InQHAiGeEVEnCMts=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=EfRFkKp8yuNwomtvZws4mD4InYmyt/0wiDi/1ckG8Gzr8fm9ayv78k/cOml213Ja5 vd7qVsMbMEXgf8TpG532NIlK/K8MvUJBHrlzel4Rs859pGRvHkKGAbynM9FPF3N7MV Ur/JG6f7wlbCOP1bP0RHRm4c+tzukiw0iC4EjonY= Subject: Re: [PATCH 1/6] selftests/clone3: convert test modes into an enum To: Eugene Syromiatnikov , linux-kernel@vger.kernel.org, Christian Brauner , linux-kselftest@vger.kernel.org Cc: Adrian Reber , shuah References: <96cf2b235f525321a562e9727b3fa0b05675efe8.1568116761.git.esyr@redhat.com> From: shuah Message-ID: <65383c0a-90d5-ed79-284d-1c084933d860@kernel.org> Date: Mon, 16 Sep 2019 10:28:55 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <96cf2b235f525321a562e9727b3fa0b05675efe8.1568116761.git.esyr@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/10/19 6:03 AM, Eugene Syromiatnikov wrote: > * tools/testing/selftests/clone3/clone3.c (CLONE3_ARGS_NO_TEST, > CLONE3_ARGS_ALL_0, CLONE3_ARGS_ALL_1): Change into an enum. > (call_clone3): Change test_mode parameter type to enum test_mode; > use switch statement for actions that dependent on test_mode selection. > (test_clone3): Change test_mode parameter type to enum test_mode. > You don't need the file name in the commit log. Please describe what you are fixing/doing in the commit. Describing the actual code changes doesn't help. Including why these changes are needed as opposed the actual changes will be helpful. I think I know why, I would like you to tell me why. > Signed-off-by: Eugene Syromiatnikov > --- > tools/testing/selftests/clone3/clone3.c | 21 ++++++++++++++------- > 1 file changed, 14 insertions(+), 7 deletions(-) > > diff --git a/tools/testing/selftests/clone3/clone3.c b/tools/testing/selftests/clone3/clone3.c > index a0f1989..7b65ee5 100644 > --- a/tools/testing/selftests/clone3/clone3.c > +++ b/tools/testing/selftests/clone3/clone3.c > @@ -24,16 +24,18 @@ > /* V1 includes set_tid */ > #define CLONE3_ARGS_SIZE_V1 72 > > -#define CLONE3_ARGS_NO_TEST 0 > -#define CLONE3_ARGS_ALL_0 1 > -#define CLONE3_ARGS_ALL_1 2 > +enum test_mode { > + CLONE3_ARGS_NO_TEST, > + CLONE3_ARGS_ALL_0, > + CLONE3_ARGS_ALL_1, > +}; > > static pid_t raw_clone(struct clone_args *args, size_t size) > { > return syscall(__NR_clone3, args, size); > } > > -static int call_clone3(int flags, size_t size, int test_mode) > +static int call_clone3(int flags, size_t size, enum test_mode test_mode) > { > struct clone_args args = {0}; > pid_t ppid = -1; > @@ -46,7 +48,8 @@ static int call_clone3(int flags, size_t size, int test_mode) > if (size == 0) > size = sizeof(struct clone_args); > > - if (test_mode == CLONE3_ARGS_ALL_0) { > + switch (test_mode) { > + case CLONE3_ARGS_ALL_0: > args.flags = 0; > args.pidfd = 0; > args.child_tid = 0; > @@ -56,7 +59,9 @@ static int call_clone3(int flags, size_t size, int test_mode) > args. stack_size = 0; > args.tls = 0; > args.set_tid = 0; > - } else if (test_mode == CLONE3_ARGS_ALL_1) { > + break; > + > + case CLONE3_ARGS_ALL_1: > args.flags = 1; > args.pidfd = 1; > args.child_tid = 1; > @@ -66,6 +71,7 @@ static int call_clone3(int flags, size_t size, int test_mode) > args. stack_size = 1; > args.tls = 1; > args.set_tid = 1; > + break; > } > > pid = raw_clone(&args, size); > @@ -91,7 +97,8 @@ static int call_clone3(int flags, size_t size, int test_mode) > return 0; > } > > -static int test_clone3(int flags, size_t size, int expected, int test_mode) > +static int test_clone3(int flags, size_t size, int expected, > + enum test_mode test_mode) > { > int ret; > > thanks, -- Shuah