From: Randy Dunlap <rdunlap@infradead.org>
To: Stafford Horne <shorne@gmail.com>, LKML <linux-kernel@vger.kernel.org>
Cc: Openrisc <openrisc@lists.librecores.org>,
kernel test robot <lkp@intel.com>,
Jonas Bonn <jonas@southpole.se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Mike Rapoport <rppt@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH] openrisc: Fix compiler warnings in setup
Date: Thu, 5 Aug 2021 12:31:37 -0700 [thread overview]
Message-ID: <655ef6e0-defb-7467-25df-f9a13ab96694@infradead.org> (raw)
In-Reply-To: <20210805030035.2994973-1-shorne@gmail.com>
On 8/4/21 8:00 PM, Stafford Horne wrote:
> This was pointed out with the recent name change of or32_early_setup to
> or1k_early_setup. Investigating the file I found a few other warnings
> so cleaning them up here.
>
> arch/openrisc/kernel/setup.c:220:13: warning: no previous prototype for 'or1k_early_setup' [-Wmissing-prototypes]
> 220 | void __init or1k_early_setup(void *fdt)
> | ^~~~~~~~~~~~~~~~
>
> Fix this the missing or1k_early_setup prototype warning by adding an
> asm/setup.h file to define the prototype.
>
> arch/openrisc/kernel/setup.c:246:13: warning: no previous prototype for 'detect_unit_config' [-Wmissing-prototypes]
> 246 | void __init detect_unit_config(unsigned long upr, unsigned long mask,
> | ^~~~~~~~~~~~~~~~~~
>
> The function detect_unit_config is not used, just remove it.
>
> arch/openrisc/kernel/setup.c:221: warning: Function parameter or member 'fdt' not described in 'or1k_early_setup'
>
> Add @fdt docs to the function comment to suppress this warning.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Stafford Horne <shorne@gmail.com>
Hi Stafford,
Does this patch apply to your openrisc tree, but not to
linux-next? I get a patch error when trying to apply it
to linux-next-20210805 and this warning is still present:
../arch/openrisc/kernel/setup.c:221:13: warning: no previous prototype for 'or32_early_setup' [-Wmissing-prototypes]
221 | void __init or32_early_setup(void *fdt)
| ^~~~~~~~~~~~~~~~
presumably because some openrisc patches are not yet in linux-next??
thanks.
> ---
> arch/openrisc/include/asm/setup.h | 14 ++++++++++++++
> arch/openrisc/kernel/setup.c | 16 +---------------
> 2 files changed, 15 insertions(+), 15 deletions(-)
> create mode 100644 arch/openrisc/include/asm/setup.h
>
--
~Randy
next prev parent reply other threads:[~2021-08-05 19:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 3:00 [PATCH] openrisc: Fix compiler warnings in setup Stafford Horne
2021-08-05 19:31 ` Randy Dunlap [this message]
2021-08-09 1:31 ` Guenter Roeck
2021-08-09 2:28 ` Randy Dunlap
2021-08-10 21:13 ` Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=655ef6e0-defb-7467-25df-f9a13ab96694@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=jonas@southpole.se \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=openrisc@lists.librecores.org \
--cc=rppt@kernel.org \
--cc=shorne@gmail.com \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).