From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Zev Weiss" <zweiss@equinix.com>, "Adriana Kobylak" <anoo@linux.ibm.com>
Cc: "Russell King" <linux@armlinux.org.uk>,
"Joel Stanley" <joel@jms.id.au>,
"Olof Johansson" <olof@lixom.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Bruce Mitchell" <bruce.mitchell@linux.vnet.ibm.com>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"Adriana Kobylak" <anoo@us.ibm.com>,
"Eddie James" <eajames@linux.ibm.com>,
"George Liu" <liuxiwei1013@gmail.com>
Subject: Re: [PATCH] ARM: configs: aspeed: Add support for USB flash drives
Date: Mon, 15 Nov 2021 10:56:33 +1030 [thread overview]
Message-ID: <65620ec1-94fb-48f7-a8f8-8e9f409b0fc8@www.fastmail.com> (raw)
In-Reply-To: <20211113002948.GE14774@packtop>
On Sat, 13 Nov 2021, at 10:59, Zev Weiss wrote:
> On Fri, Nov 12, 2021 at 12:29:31PM PST, Adriana Kobylak wrote:
>>From: Adriana Kobylak <anoo@us.ibm.com>
>>
>>Add support to detect USB flash drives and create the /dev/sd* devices.
>>Also add support for vfat to support USB drives formatted as FAT32.
>>This support will be used to enable firmware updates via USB flash
>>drives where the firmware image is stored in the USB drive and it's
>>plugged into the BMC USB port.
>>
>
> Hmm, how common is it for BMCs to have a USB port? Perhaps it's more so
> than I realize, but at least in my (admittedly somewhat limited)
> experience I've yet to encounter one that does, so I'm wondering how
> appropriate these options are for the aspeed-g5 defconfig if they might
> just end up as a bunch of code that's never executed on most BMCs.
The intent with the Aspeed defconfigs was to enable options that
provide a broad coverage of features used by e.g. upstream OpenBMC
systems. This aids kernel maintenance for OpenBMC. The platform
configuration in OpenBMC should provide a kernel config that only
enables options relevant to that specific platform. With this in mind I
think it's fine that USB support is enabled in the defconfigs.
Andrew
prev parent reply other threads:[~2021-11-15 0:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 20:29 [PATCH] ARM: configs: aspeed: Add support for USB flash drives Adriana Kobylak
2021-11-13 0:29 ` Zev Weiss
2021-11-13 9:48 ` Richard Hughes
2021-11-15 0:26 ` Andrew Jeffery [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65620ec1-94fb-48f7-a8f8-8e9f409b0fc8@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=anoo@linux.ibm.com \
--cc=anoo@us.ibm.com \
--cc=bruce.mitchell@linux.vnet.ibm.com \
--cc=eajames@linux.ibm.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=liuxiwei1013@gmail.com \
--cc=olof@lixom.net \
--cc=openbmc@lists.ozlabs.org \
--cc=zweiss@equinix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).