From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758450AbcIMUuI (ORCPT ); Tue, 13 Sep 2016 16:50:08 -0400 Received: from mout.web.de ([212.227.17.11]:54745 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751621AbcIMUuG (ORCPT ); Tue, 13 Sep 2016 16:50:06 -0400 Subject: [PATCH 7/7] AGPGART-UniNorth: Delete an unnecessary check in uninorth_create_gatt_table() To: kernel-janitors@vger.kernel.org, David Airlie References: <566ABCD9.1060404@users.sourceforge.net> <5204ca92-2cdf-8115-567c-4ac29816fcec@users.sourceforge.net> Cc: LKML , Julia Lawall From: SF Markus Elfring Message-ID: <6565fead-21c0-59d6-2a81-fd5084123d66@users.sourceforge.net> Date: Tue, 13 Sep 2016 22:50:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <5204ca92-2cdf-8115-567c-4ac29816fcec@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:6Czqh93aBto+5KghvCUpLy6L7sKSq2Ux9/CSG72zeRHijXgZJjB DacayYbq1YjWHoPkIWzFVUN9oDPYJ4c9jdZ8/+lQuY8ZKRes79fFOtoVJ4YOaeFxfk7HYUT MKPB37iQSRLqxsuebRpL3yS2BXfPRu14nxiyItJaKNRmZu3xsU+woUfoKoezPjkPuxZMau0 tOmDzAj7O0D2leZ5FJmwQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:+RA1BFS8/AI=:nTW9ELUM8ugnnbYZGRM8Vu Fv1x+thC4gKh8j7xSjnp92qu+M2dAHs1B9FiFoxYZ2Wk+YeTIf8wur/n6JWcUSR+lK/geThNZ 1G95TvxaE05caruKMxkEDM8cnrQewX+tiE1k7H+olhzbYKYp90zbckrridhBN5Al7jwonkii7 JOLSw3o5cqsUmZRSDhtzF41qxOxlpRhLaiZcvruzTRx1wh4/pPa8UMGI7e/pUH3wpjyc/B8lV uFWpk0pJUErshbJOr1lXATsWC5bmRRsarAup/qVXWH1T8a1DcpYo9NNSBTw8YwGx8v+JxyA/N uaXQ7UABXivcsT0XyJcGSSXLBjbHGJo2tX2nLesO3bE5AX819eFplmqXm9/JP+NP3GyL5sSlM 0Wluvw5mj9r03igMyJDP5UbCsAfi60fGYgrFE0moy81z0Tb0lmlodBtb9yK6iqMrfRGT2X8Wh QHnpah+8AdZESRLDZGZ4nolOt8X+kKIX0y/p63kOizxwf7rLC4zWMTzKUFTVX7i4jrINtidUS fFU/7+2paidKHhJgOLSY91uufyFyfg22NX3LTeZzH30cHtryjvnLsAqksun8AWoOZmcRDb1pq p/QiVY1wLq6UY12doIBifRUilPTgBh/iUxV+5aaIgo9V/xXtfmT5Qm8KNYCBLkgI9CUahpw9q rfLTw27WRTfPJCVd9EkWlGTALXo2x5Qk+dnbRc3dWKBn4FTyOFZi9WpMfmsUcGUburNz6NtZv nzmYT9LEscOEBO5rLxvhOoQ0MiJ3Bh6/hEsYC1jTNLA0N15JjVKtcQyAYcIoKV6yCDcraHnw7 0sk2lrw Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 13 Sep 2016 22:15:56 +0200 The check for the local variable "table" is unnecessary at the end of this function because the corresponding source code place should only be reached with a non-zero pointer for it after a failed call of the function "kmalloc_array". Thus remove it. Signed-off-by: Markus Elfring --- drivers/char/agp/uninorth-agp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/char/agp/uninorth-agp.c b/drivers/char/agp/uninorth-agp.c index 8b1eb72..657cf17 100644 --- a/drivers/char/agp/uninorth-agp.c +++ b/drivers/char/agp/uninorth-agp.c @@ -438,8 +438,7 @@ static int uninorth_create_gatt_table(struct agp_bridge_data *bridge) return 0; free_page_array: kfree(uninorth_priv.pages_arr); - if (table) - free_pages((unsigned long)table, page_order); + free_pages((unsigned long)table, page_order); return -ENOMEM; } -- 2.10.0