From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
Adaptec OEM Raid Solutions <aacraid@microsemi.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH v3][next] scsi: aacraid: Replace one-element array with flexible-array member
Date: Mon, 10 May 2021 22:30:54 -0500 [thread overview]
Message-ID: <65719db1-b1ec-8466-5f39-27af16d8a701@embeddedor.com> (raw)
In-Reply-To: <162070348784.27567.4297596089347883095.b4-ty@oracle.com>
On 5/10/21 22:25, Martin K. Petersen wrote:
> On Wed, 21 Apr 2021 13:56:11 -0500, Gustavo A. R. Silva wrote:
>
>> There is a regular need in the kernel to provide a way to declare having
>> a dynamically sized set of trailing elements in a structure. Kernel code
>> should always use “flexible array members”[1] for these cases. The older
>> style of one-element or zero-length arrays should no longer be used[2].
>>
>> Refactor the code according to the use of a flexible-array member in
>> struct aac_raw_io2 instead of one-element array, and use the
>> struct_size() helper.
>>
>> [...]
>
> Applied to 5.14/scsi-queue, thanks!
>
> [1/1] scsi: aacraid: Replace one-element array with flexible-array member
> https://git.kernel.org/mkp/scsi/c/39107e8577ad
Awesome. :)
Thanks, Martin.
--
Gustavo
prev parent reply other threads:[~2021-05-11 3:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 18:56 [PATCH v3][next] scsi: aacraid: Replace one-element array with flexible-array member Gustavo A. R. Silva
2021-04-22 3:03 ` Martin K. Petersen
2021-04-22 3:20 ` Kees Cook
2021-04-22 3:34 ` Martin K. Petersen
2021-05-04 0:19 ` Gustavo A. R. Silva
2021-05-04 2:56 ` Martin K. Petersen
2021-05-04 3:06 ` Gustavo A. R. Silva
2021-05-11 3:25 ` Martin K. Petersen
2021-05-11 3:30 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65719db1-b1ec-8466-5f39-27af16d8a701@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=aacraid@microsemi.com \
--cc=gustavoars@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).